From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B620142E73 for ; Wed, 11 May 2022 05:58:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 069A268B26D; Wed, 11 May 2022 08:58:50 +0300 (EEST) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0507568A3DF for ; Wed, 11 May 2022 08:58:43 +0300 (EEST) Received: by mail-lf1-f44.google.com with SMTP id j4so1669933lfh.8 for ; Tue, 10 May 2022 22:58:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=3vFrSmMRHegtPWgGe9N6iI8945XeZu4t6oYEmBstRAk=; b=k+EXIOMMkD77gMK9Vyt/Om/o/Lil8ZIGEotgA5Yz/jccRcKLAtTrvm8ZIyvuuF7JTI q3HfXNAnD55/M5/4G+DhfXiVlKMGytEUdB8WgFFaDz3nge+2e1sDpeivNeWSzyxpeUHj TAH73AeLZMnRqBbqSS08LYqY2KsABqBJIr/Thg6pRHJ+tWCR+OGA3fCNGjMoesdvK3zI rVKMjH4ZqwL1ONr1FNC9uWn5s/AQhhml+rs2H6pI3zko24sbNYOlajZIJJkiH7vyLb0D pcDEI5GOqRbHOLq/QeUfd7jc+LoqDKhlGwCyqLvfSZrUpS7gY0B19MHOXMmYMm7rcoHH cV4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=3vFrSmMRHegtPWgGe9N6iI8945XeZu4t6oYEmBstRAk=; b=OpFBok4d9CchKg3sIqCj6B3qB/Ql63QpYdZtC04Z0oQ6v2k8NakW0B7lBXdbknPbXg EzYJzCdU4qOJLEw9xXlK0jclx5xIIztfSzZ/YUJ/6An4jMJJSxcwFEYbMyNhPRcC3Ca3 tKdaAr2PzObk0ShHlJaQqcN2w5oqrO/JS1FeDE2JRxpfHLiBaL42JNLOQ0TMZDN86esp 5jlT+1nbmSnjHYINmzRz4oUtVH9FSSJGGz1fx8jWWqC7GEeb8Vo9Iexp+bdtSgY2xYxH QMwEPIiXpS7m5olM0FQWcNGemsmbGMApcsIxO+uAwQW+4puawoyOTp/IfJtIx/lrNf4a ax8A== X-Gm-Message-State: AOAM530c4BQXg0syMpjRowMW3cYSzzqPnaVMvHirR/0Webv73uMrhfyi AebthVQdCWJlJYWo07pjloNj6y8a2PGKTvtYS3MS0w6B X-Google-Smtp-Source: ABdhPJz0tI8CyyhLsyVAsYA6HyljpCfmZ5x1vZWztlgZZFOhWFb+nexdsPsJBk/2RZmIogzBsDGj5HNiIiwKer15ILc= X-Received: by 2002:a05:6512:2586:b0:472:6266:4052 with SMTP id bf6-20020a056512258600b0047262664052mr18921911lfb.684.1652248722769; Tue, 10 May 2022 22:58:42 -0700 (PDT) MIME-Version: 1.0 References: <20220510224829.143890-1-ccom@randomderp.com> <20220511052257.174499-1-ccom@randomderp.com> In-Reply-To: <20220511052257.174499-1-ccom@randomderp.com> From: Hendrik Leppkes Date: Wed, 11 May 2022 07:58:30 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2] configure: add check for sdl2 >= 2.23.0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, May 11, 2022 at 7:23 AM Christopher Degawa wrote: > > sdl2 recently changed their versioning, moving the patch level to minor level > https://github.com/libsdl-org/SDL/commit/cd7c2f1de7d9e418bb554047d714dd7cacc020ff > > trac: https://trac.ffmpeg.org/ticket/9768 > > Signed-off-by: Christopher Degawa > --- > configure | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/configure b/configure > index 4d2f4d9112..0fdab7391e 100755 > --- a/configure > +++ b/configure > @@ -6743,6 +6743,13 @@ fi > if enabled sdl2; then > SDL2_CONFIG="${cross_prefix}sdl2-config" > test_pkg_config sdl2 "sdl2 >= 2.0.1 sdl2 < 2.1.0" SDL_events.h SDL_PollEvent > + # sdl2 changed their versioning scheme to match GLib and flatpack moving the patch to > + # minor instead in > + # https://github.com/libsdl-org/SDL/commit/cd7c2f1de7d9e418bb554047d714dd7cacc020ff > + # which obviously breaks the previous check, so go ahead and check for the new version > + if disabled sdl2; then > + test_pkg_config sdl2 "sdl2 >= 2.23.0 sdl2 < 3.0.0" SDL_events.h SDL_PollEvent > + fi > if disabled sdl2 && "${SDL2_CONFIG}" --version > /dev/null 2>&1; then > sdl2_cflags=$("${SDL2_CONFIG}" --cflags) > sdl2_extralibs=$("${SDL2_CONFIG}" --libs) > -- There never was an "incompatible" 2.1.0 right? So can't you just update the previous check to be >= 2.01 < 3.0 instead of introducing a second one? - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".