From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C3B9E4461D for ; Mon, 19 Sep 2022 20:58:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C2BEB68BAEB; Mon, 19 Sep 2022 23:58:34 +0300 (EEST) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 711F568BA14 for ; Mon, 19 Sep 2022 23:58:28 +0300 (EEST) Received: by mail-lj1-f177.google.com with SMTP id z20so662749ljq.3 for ; Mon, 19 Sep 2022 13:58:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=7i7xHxKkUmJXvH75NjfT0kzKF+igwqf4+mWAGb/WLtc=; b=pSvu8S76OLsauX9CzJFO3fM+Aa69ENX9NXEhb2hqlNH8sS6st2LWIxnrPIP7yc6bqg HJVqJYlCx9gUW4vjAUqo9M80MCN49b4daAXz462rQf8InsIbC71hxruiedOQNzNrCp/V ZMkd7a3+2B9rBehkaA6JltvylZfn77Al2PYBEqgl6gzMfQdg7Npr4t7wFGsyK5cfHtLh 4voteHl+yMB3c/bhpAupKWO36ApUtoJDoj4XCY2YZvoAetWe2CiKwZz2KSBVPW+wnp/c ZOPbXTOHO0zb7Bik2gOdgB1RqLaOvz63g1erYambyX36IwS5UHgQwRHX2V58n7N01VlF RjWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=7i7xHxKkUmJXvH75NjfT0kzKF+igwqf4+mWAGb/WLtc=; b=M3wF5y/OZ7b6J8F8WojRhVTloBqLxshuRWtJICLt9v7DDfFtqj3ql8svyOHsQXzhSu GG5PQfh6/qdsy2kRE8mk2VmO8D58eUZa25y7SjM1DnWiYZ3XI/koZX9JTazt8tTb9NhN pHgiEDSSDWfsd3FtumNThVGEwP7Ivel6vbiG/hcDXt/fWwZeTtqTxUT43b4bNI3MYthF eksV8BUGESCPTF1/OIopFA1cYR8yUbTpZ5uMMu/h5QM0ybMuVQLOhrHv8/cam4a4wL42 tE7HwoKapKrcOiGKpHLxw/pflDGlz0l6i1WtYSkgyw3KSduHUcyphtS6QFMaBoJMJHly J91w== X-Gm-Message-State: ACrzQf2sNTdc+8DqAlTKFn5JOve/dJgoz8f30lr6p/6Ep8oIGQA1x9xY d+BtuxK/NBZEdF3h1c40Vbm1BJlkw5BlIx7llumqznoE X-Google-Smtp-Source: AMsMyM6aEIX06oQcZko2zVRCxSRRLICbXHYnwniMR+aWtbjm6v76JdTcbTg1ufJ6voyrvZo1i6M+lLjSUU2fwDNfom0= X-Received: by 2002:a2e:86cf:0:b0:26b:f773:f644 with SMTP id n15-20020a2e86cf000000b0026bf773f644mr6207758ljj.515.1663621105959; Mon, 19 Sep 2022 13:58:25 -0700 (PDT) MIME-Version: 1.0 References: <20220919175534.102124-1-scott.the.elm@gmail.com> In-Reply-To: From: Hendrik Leppkes Date: Mon, 19 Sep 2022 22:58:12 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] lavc: add detection of forced subtitles X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Sep 19, 2022 at 10:53 PM Andreas Rheinhardt wrote: > > Scott Theisen: > > This is from the following MythTV commits: > > libavcodec: add support for detecting forced subtitle segments. https://github.com/MythTV/mythtv/commit/5099f1a5777966fba482b623e581c1eef5c8fc09 > > This adds forced subtitle segment detection to the PGS subtitle decoder and > > copies the result to AVSubtitle. > > > > Subtitles: Flag forced DVD subtitles. https://github.com/MythTV/mythtv/commit/78f71eecdbd53ba92af2ad639b32564c01f24563 > > --- > > libavcodec/avcodec.h | 1 + > > libavcodec/dvdsubdec.c | 4 +++- > > libavcodec/pgssubdec.c | 4 ++++ > > 3 files changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > > index 7db5d1b1c5..b9aa9efb2f 100644 > > --- a/libavcodec/avcodec.h > > +++ b/libavcodec/avcodec.h > > @@ -2331,6 +2331,7 @@ typedef struct AVSubtitle { > > unsigned num_rects; > > AVSubtitleRect **rects; > > int64_t pts; ///< Same as packet pts, in AV_TIME_BASE > > + int forced; > > sizeof(AVSubtitle) is part of the public ABI, no additions to it are > possible. I wanted to suggest using AVSubtitleRect.flags, but apparently > AV_SUBTITLE_FLAG_FORCED already exists. And it seems that both the > dvdsub as well as the pgssub decoders already set this. > Which is also more correct, since in PGS for example you can have both active rects that are forced, and those that are not, at the same time. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".