Re: [FFmpeg-devel] [PATCH] configure: Check for DXGI_OUTDUPL_FRAME_INFO for the ddagrab filter

[Hendrik Leppkes <h.leppkes@gmail.com>]

On Mon, Aug 1, 2022 at 2:56 PM Martin Storsjö <martin@martin.st> wrote:
>
> On Mon, 1 Aug 2022, Hendrik Leppkes wrote:
>
> > On Mon, Aug 1, 2022 at 2:36 PM Martin Storsjö <martin@martin.st> wrote:
> >>
> >> The DXGI_OUTDUPL_FRAME_INFO type isn't available in Windows API
> >> subsets other than "desktop", while the IDXGIOutput1 interface is
> >> available for all API subsets.
> >>
> >> This fixes compilation for UWP/"Windows Store" configurations (and
> >> older API subsets like Windows Phone).
> >
> > The entire desktop duplication API is not present on Phone targets
> > (its called "desktop" duplication afterall). I think it would be
> > better to check for a primary DDA function, instead of some auxiliary
> > structure.
>
> FWIW, based on the MSVC error output
> (http://fate.ffmpeg.org/log.cgi?log=compile&slot=arm-msvc2019-phone&time=20220730152801),
> the only hard errors it listed were the undefined types
> (DXGI_OUTDUPL_POINTER_SHAPE_INFO and DXGI_OUTDUPL_FRAME_INFO) - but I
> presume that IDXGIOutputDuplication_AcquireNextFrame and
> IDXGIOutputDuplication_ReleaseFrame could be good candidates for checking
> too - I don't see anything else in that error log that one could check
> for?

I guess it doesn't really matter what we check for, and checking for
types seems easier then those macro'ed COM function wrappers. It just
felt slightly odd. But since its in already, no need to worry.

- Hendrik
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".