From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D6DD042AF2 for ; Fri, 13 May 2022 09:27:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4EC3368B46E; Fri, 13 May 2022 12:27:40 +0300 (EEST) Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AE0E868B347 for ; Fri, 13 May 2022 12:27:33 +0300 (EEST) Received: by mail-lj1-f180.google.com with SMTP id b32so9588049ljf.1 for ; Fri, 13 May 2022 02:27:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=iAjUtxHnP1F0hy6YYpfDCb2uZdgUiODvzFK5+As2UUo=; b=TNSAWPnJe0odw5gGvNKTrxmVrryHTgFe2OMstLCjnKXdQ0eQM9lu6z3yH00CXR041x cXZDZhtQJlxhMuW5xvoA7YIaRXqYfEM7tmR2weIz3HoUbWBf71+5Z2V/Q15x5CYmgeZz 1DrC6r+1GS7MLj24J36+i3AmOObj0sPKITHe+VPyiTeRUv4L2EQdqF+UTfCYbZrVCqM5 Y+Vys8neP70wABUyEpiAzS7ZWdH3h9fkNuUPwo7F/rn5NuYbdZRxQacs4l/FawKyUPJE cOTl0b5gPXXMXs+Ah9zIBGFmiungk8CsL2ywdmjPGBHLLefSDEirJK/aeTFLTYhiqzP+ E8kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=iAjUtxHnP1F0hy6YYpfDCb2uZdgUiODvzFK5+As2UUo=; b=75ry7WOsJ/TFWKLEd9ctfQspW5e/YsoWgiYQfYM5p03jjD6mUKh5VgpMQRv2j1dF6o rSV8qQqFJLoJX+Asknc2yK5z26ZBQk3MpomghUB1vi7oJEXp4YR+l5A5pbwgpa/v4LWU 8cVlgXsnaGk2XZ0hWYR2xbV2MQcofhfywEKqVitEMiXwgiW0mSBu6yUsCzsbIK7RW49t x1RyHXBtdK34eLWnZfIkOy6sHRAUxg4OhpN1p2erdRb9K2RRDLMhO5pj7GSbJzu58ivT jgYJaqJuuQ3OvD7MRy6eJOZ/dRCNv63SWm/WOBmPbFGahCQVnG3C4XktKWkwz9SZV/ch NXCg== X-Gm-Message-State: AOAM531AsQfr/FPp6O5xpzLDPPhC+EYbuWjaTH5liYweI738LHQrYLmQ 68gBwQnW2Cx4mJ5fEVIEUVwCK5QNPZ1eQ6Jw2RvcRHYa5hY= X-Google-Smtp-Source: ABdhPJx2hOgLzWrJenzlAI0NFCrdhEvzmP6dOqo5IXRrroOb+zD+tpHTrzBDstUqaXApDYQ/auo3LGQnL92Rklu2yc0= X-Received: by 2002:a2e:8510:0:b0:24f:97f:f7ce with SMTP id j16-20020a2e8510000000b0024f097ff7cemr2666996lji.252.1652434052569; Fri, 13 May 2022 02:27:32 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Hendrik Leppkes Date: Fri, 13 May 2022 11:27:21 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move ff_nlmeans_init into a header X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, May 13, 2022 at 11:26 AM Andreas Rheinhardt wrote: > > Soft Works: > > > > > >> -----Original Message----- > >> From: Andreas Rheinhardt > >> Sent: Friday, May 13, 2022 10:27 AM > >> To: Soft Works ; FFmpeg development discussions > >> and patches > >> Subject: Re: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move > >> ff_nlmeans_init into a header > >> > >> Soft Works: > >>> > >>> > >>>> -----Original Message----- > >>>> From: ffmpeg-devel On Behalf Of > >>>> Andreas Rheinhardt > >>>> Sent: Tuesday, May 3, 2022 8:38 AM > >>>> To: ffmpeg-devel@ffmpeg.org > >>>> Cc: Andreas Rheinhardt > >>>> Subject: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move > >>>> ff_nlmeans_init into a header > >>>> > >>>> This removes a dependency of checkasm on lavfi/vf_nlmeans.o > >>>> and also allows to inline ff_nlmeans_init() irrespectively of > >>>> interposing. > >>>> > >>>> Signed-off-by: Andreas Rheinhardt > >>>> --- > >>> > >>> [..] > >>> > >>>> + > >>>> +static av_unused void ff_nlmeans_init(NLMeansDSPContext *dsp) > >>>> +{ > >>>> + dsp->compute_safe_ssd_integral_image = > >>>> compute_safe_ssd_integral_image_c; > >>>> + dsp->compute_weights_line = compute_weights_line_c; > >>>> + > >>>> + if (ARCH_AARCH64) > >>>> + ff_nlmeans_init_aarch64(dsp); > >>> > >>> Hi Andreas, > >>> > >>> the above breaks compilation for me: > >>> > >>> 1>libavfilterd.lib(libavfilter_vf_nlmeans.obj) : error LNK2019: > >> unresolved external symbol ff_nlmeans_init_aarch64 referenced in > >> function ff_nlmeans_init > >>> > >>> The reason is that I'm (obviously) not compiling stuff from the > >>> libavfilter\aarch64 subfolder. > >>> > >>> It might need an #ifdef ? > >>> > >>> I haven't taken a deeper look at it, though. > >>> > >>> Thanks, > >>> softworkz > >>> > >>> > >> > >> That surprises me: The earlier code did exactly the same; in fact, > >> using > >> if (ARCH_*) is our typical check for arches in dsp-init code. > > > > I looked at this a bit further. It seems that the VS project > > generation tool that I'm using is creating dummy definitions > > for such cases. In the previous workspace it had generated > > > > void ff_nlmeans_init_aarch64(NLMeansDSPContext *dsp) {return;} > > > > in a separate code file for being able to work with the ffmpeg > > code in VS without modifying any of the code. > > > > Now that you have moved that code to a header file, this logic > > doesn't work anymore. > > > > Why does your compiler not just eliminate dead code like all the others? > Is this MSVC -O0 behaviour? MSVC does not do DCE when optimizations are disabled, yes. So this is where this is coming from. > I just sent the patch > https://ffmpeg.org/pipermail/ffmpeg-devel/2022-May/296380.html, but now > that I read this I have to agree with Hendrik: Why not update your tool > instead? > Actually looking at the tool, it seems like it handles header files. Did you actually re-run the generation tool after applying this patch? - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".