From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 887DA4276F for ; Fri, 29 Apr 2022 22:02:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 60ABF68B294; Sat, 30 Apr 2022 01:02:10 +0300 (EEST) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 89CB468B03C for ; Sat, 30 Apr 2022 01:02:03 +0300 (EEST) Received: by mail-lj1-f177.google.com with SMTP id bn33so12015937ljb.6 for ; Fri, 29 Apr 2022 15:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=NsIAQCbLlhtVLlNV1Z4K6SmRZUB1hxsIRXQI1EqrRH4=; b=lwAJKWbQxIM7ZzT8NblGmr93WWaH5ET9Laz2hQ+JtncmXLTfJGdizZPgPvHUNO0aJi uwi1Mek4rGAQu2Enh3zcgI3vJAGkZvl97N+e/9ZSQtd8ka251ayg0rl24lAUKQ3f/9jI CqXg3NfcMKFgfGu6z/PnZOFnXSyOF0phU5yBGh9t8Rfl7+ZsnKDA6OE0vxOMemqq8ZlP 7WeG8+C5+kf0IrbSfahZzLcv8Z6KOHGx7sZUFKQVg8FKkmYX6jor0xtudnjTdn7H6vrG Hq6JaLw5redQG2ucd6g9KXRS3Hap5wt/Zb17mc3GAljEUPZhesmX4ZKvDiS+ljGghpIC 5y8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=NsIAQCbLlhtVLlNV1Z4K6SmRZUB1hxsIRXQI1EqrRH4=; b=H8eZgElY6ptOAee0t59oyS9RdA3ju+3Mq+51x4PYsJCKBSf+rvoe7Z193VvNT+VjlU vI2ysgsoBMx53P1LhiwfYEz3fO4ykzgLvf0TxzAp4+kTsxckm17VRu+pM8ueE1GiiJch xeUSa8A1LuBU/ju72n0S90cOiqdRnBTAdMxUBHomBdzGKrDHBQwpNSOOMmpND4pDXqkZ oa8evtS46pfyqnO40oVZEMzjdelRoLgWeytMVnUzr5R1DuB61C/RMWM2mqm6x6VmgdLM E477UqzZLCMyChDt8llotyYWTvxmU+LyB7J1ZtbgijOGtuGBwuLBGJKHWLxbL6SZzkSm TP5w== X-Gm-Message-State: AOAM5317r9gFdbDdAwOMneg1oLqqepdnyG4NKDkKBTzmniNK47uCAqtv +pOIDz4XpbVrwraQd1f4g6P6puT5ehC9CDtZQbCNKu3g X-Google-Smtp-Source: ABdhPJyXqzqS91rwAge5io2g9dmmhBhC1S6Fz+9lkq4ORmH91kkOtYDrmHsjovqtwAPdPlb1To3JoyaQKBRf8gTDaYE= X-Received: by 2002:a05:651c:893:b0:249:4023:3818 with SMTP id d19-20020a05651c089300b0024940233818mr826748ljq.44.1651269722171; Fri, 29 Apr 2022 15:02:02 -0700 (PDT) MIME-Version: 1.0 References: <20220429104505.1747-1-tong1.wu@intel.com> In-Reply-To: <20220429104505.1747-1-tong1.wu@intel.com> From: Hendrik Leppkes Date: Sat, 30 Apr 2022 00:01:49 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2 1/5] avutil/hwcontext_d3d11va: fix the uninitialized texture bindflag X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, Apr 29, 2022 at 12:45 PM Tong Wu wrote: > > When uploading rawvideos using d3d11va hardware framecontext, the bindflag > is not initialized and will cause creating texture failure. Now fix it, > assign it the value of D3D11_BIND_RENDER_TARGET. > As with similar fixes of this nature, this implicit behavior to fix one particular bug does not seem fitting inside the hwcontext itself. There can be a large list of usages of the hwcontext that all require different BindFlags, but we can only define one default - why this one specifically? So rather: Where is the context created? Why is a required flag not set there? That would be better, because that knows what flags it needs. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".