From: Hendrik Leppkes <h.leppkes@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 1/5] avutil/hwcontext_d3d11va: fix the uninitialized texture bindflag
Date: Sat, 30 Apr 2022 00:01:49 +0200
Message-ID: <CA+anqdyvYq1tFFP3QDJvtHqvcr37qMDW_Zg1u1btWMo7Cas2XA@mail.gmail.com> (raw)
In-Reply-To: <20220429104505.1747-1-tong1.wu@intel.com>
On Fri, Apr 29, 2022 at 12:45 PM Tong Wu
<tong1.wu-at-intel.com@ffmpeg.org> wrote:
>
> When uploading rawvideos using d3d11va hardware framecontext, the bindflag
> is not initialized and will cause creating texture failure. Now fix it,
> assign it the value of D3D11_BIND_RENDER_TARGET.
>
As with similar fixes of this nature, this implicit behavior to fix
one particular bug does not seem fitting inside the hwcontext itself.
There can be a large list of usages of the hwcontext that all require
different BindFlags, but we can only define one default - why this one
specifically?
So rather:
Where is the context created?
Why is a required flag not set there? That would be better, because
that knows what flags it needs.
- Hendrik
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-04-29 22:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 10:45 Tong Wu
2022-04-29 10:45 ` [FFmpeg-devel] [PATCH v2 2/5] avutil/hwcontext_qsv: derive QSV frames to D3D11VA frames Tong Wu
2022-04-30 14:08 ` Soft Works
2022-04-29 10:45 ` [FFmpeg-devel] [PATCH v2 3/5] avutil/hwcontext_d3d11va: add a format check for staging texture Tong Wu
2022-04-30 14:41 ` Soft Works
2022-05-05 1:41 ` Wu, Tong1
2022-04-29 10:45 ` [FFmpeg-devel] [PATCH v2 4/5] avutil/hwcontext_qsv: map QSV frames to D3D11VA frames Tong Wu
2022-04-30 15:08 ` Soft Works
2022-04-29 10:45 ` [FFmpeg-devel] [PATCH v2 5/5] avutil/hwcontext_qsv: map D3D11VA frames to QSV frames Tong Wu
2022-04-30 15:09 ` Soft Works
2022-04-29 22:01 ` Hendrik Leppkes [this message]
2022-04-30 13:59 ` [FFmpeg-devel] [PATCH v2 1/5] avutil/hwcontext_d3d11va: fix the uninitialized texture bindflag Soft Works
2022-05-01 4:15 ` Xiang, Haihao
2022-05-01 5:09 ` Soft Works
2022-05-01 15:48 ` Hendrik Leppkes
2022-05-01 15:53 ` Hendrik Leppkes
2022-05-02 6:40 ` Soft Works
2022-05-05 9:50 ` Wu, Tong1
2022-05-06 1:10 ` Soft Works
2022-05-06 5:37 ` Hendrik Leppkes
2022-05-06 5:50 ` Soft Works
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+anqdyvYq1tFFP3QDJvtHqvcr37qMDW_Zg1u1btWMo7Cas2XA@mail.gmail.com \
--to=h.leppkes@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git