From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1D82F42ADA for ; Fri, 13 May 2022 09:13:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E86D668B41C; Fri, 13 May 2022 12:13:36 +0300 (EEST) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6EA9C68AD28 for ; Fri, 13 May 2022 12:13:30 +0300 (EEST) Received: by mail-lf1-f52.google.com with SMTP id b18so13386709lfv.9 for ; Fri, 13 May 2022 02:13:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=BHzMRATfczfXTrEjzlEQNXC68XbiIh5RBTduAm8Sb00=; b=MB8h+exXMReUGp7B3ylnOVYhXQ/6LlLE6BfetyEPG+RAQqPgGxS42yoHqbHcmZM3nZ t/Lj8kL6jdeZTTIVZJAY+VsNOnmEROFmJQoyyL+NgU/KTAsYvfeyDvlWJjbtVYVIu+DC hcOaGlrumj78J44lSm9QEIHOkKczYVqs835zX9UaK/AZv9dI2/xsWH+1dM1MBsLRWb7X SgH5gscqTSmCZDRKxQlqlcclxQH/iswYCSmV6fhn6kr8vgO8Tt3/674BEqRdusoBh9an 9K7qQFu0bfkiu1F6xR1DKRB7JHmBTkpHWFoMYRiRI7d+Aeqoz2/VRJxobvJ9zgGFXNRR P2fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=BHzMRATfczfXTrEjzlEQNXC68XbiIh5RBTduAm8Sb00=; b=rMALB0z8PjRD3arpXNmLKVPCdYxTNtUsXUNQZrwqYHYRSm6QJ3MrMB4L+Bjhr9YFB+ 4sVOHjNJkX3HBRybpMFB7mPtKsrfkLWx8fe/8L1cukIgaxFVs3yh8R6157YXz0Y3hn4i KNt5kj5w6NzL6oCCdeaRXTMKdSrXl4MYF+p4S8Se2FA7Lv47P1WW5LaP+d8Y4VDTfl9D d70WyrjvwiTO879K8iFYihDv6VBq1cixfxtMaqsluLai7Bp0cBqI0Hj2UQ+snr33J9aw PLRwmIy8pHGQZqBcfDXUwoYj6jvlXwr2II2b6Gx9T80t/MPQ9vsqGqpm0A3L3Ml+r2o3 pl/w== X-Gm-Message-State: AOAM530nVwmkCYbNsMI9jEVbKsro+EPFVIhfpAmIWL57dArO72iqNfV+ O+WWGLlHmdWs+Ei80UAdatJPU5KIY+KwJxn8wT284FdG X-Google-Smtp-Source: ABdhPJzZYOSgzU/CJvogxDhZBTjitSf+dpJSxwTbm/omNWFSNe9XtdANszc5PhYgho0SXBg2eda/tIFqEHBB5KkbEtg= X-Received: by 2002:a05:6512:318b:b0:473:fe9b:7ac2 with SMTP id i11-20020a056512318b00b00473fe9b7ac2mr2829427lfe.287.1652433209259; Fri, 13 May 2022 02:13:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Hendrik Leppkes Date: Fri, 13 May 2022 11:13:17 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move ff_nlmeans_init into a header X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, May 13, 2022 at 11:01 AM Soft Works wrote: > > > > > -----Original Message----- > > From: Andreas Rheinhardt > > Sent: Friday, May 13, 2022 10:27 AM > > To: Soft Works ; FFmpeg development discussions > > and patches > > Subject: Re: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move > > ff_nlmeans_init into a header > > > > Soft Works: > > > > > > > > >> -----Original Message----- > > >> From: ffmpeg-devel On Behalf Of > > >> Andreas Rheinhardt > > >> Sent: Tuesday, May 3, 2022 8:38 AM > > >> To: ffmpeg-devel@ffmpeg.org > > >> Cc: Andreas Rheinhardt > > >> Subject: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move > > >> ff_nlmeans_init into a header > > >> > > >> This removes a dependency of checkasm on lavfi/vf_nlmeans.o > > >> and also allows to inline ff_nlmeans_init() irrespectively of > > >> interposing. > > >> > > >> Signed-off-by: Andreas Rheinhardt > > >> --- > > > > > > [..] > > > > > >> + > > >> +static av_unused void ff_nlmeans_init(NLMeansDSPContext *dsp) > > >> +{ > > >> + dsp->compute_safe_ssd_integral_image = > > >> compute_safe_ssd_integral_image_c; > > >> + dsp->compute_weights_line = compute_weights_line_c; > > >> + > > >> + if (ARCH_AARCH64) > > >> + ff_nlmeans_init_aarch64(dsp); > > > > > > Hi Andreas, > > > > > > the above breaks compilation for me: > > > > > > 1>libavfilterd.lib(libavfilter_vf_nlmeans.obj) : error LNK2019: > > unresolved external symbol ff_nlmeans_init_aarch64 referenced in > > function ff_nlmeans_init > > > > > > The reason is that I'm (obviously) not compiling stuff from the > > > libavfilter\aarch64 subfolder. > > > > > > It might need an #ifdef ? > > > > > > I haven't taken a deeper look at it, though. > > > > > > Thanks, > > > softworkz > > > > > > > > > > That surprises me: The earlier code did exactly the same; in fact, > > using > > if (ARCH_*) is our typical check for arches in dsp-init code. > > I looked at this a bit further. It seems that the VS project > generation tool that I'm using is creating dummy definitions > for such cases. In the previous workspace it had generated > > void ff_nlmeans_init_aarch64(NLMeansDSPContext *dsp) {return;} > > in a separate code file for being able to work with the ffmpeg > code in VS without modifying any of the code. > > Now that you have moved that code to a header file, this logic > doesn't work anymore. > Nevermind my previous comment then, perhaps external tools should be updated if they somehow work around our need for DCE (which is well documented). - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".