[FFmpeg-devel] [PATCH] libavformat/mov.c: Added configuration flag to skip cover art atom while opening mov parser

* [FFmpeg-devel] [PATCH] libavformat/mov.c: Added configuration flag to skip cover art atom while opening mov parser
@ 2022-04-20 11:39 Malviya, Janpriya
  2022-04-20 13:23 ` Derek Buitenhuis
  0 siblings, 1 reply; 5+ messages in thread
From: Malviya, Janpriya @ 2022-04-20 11:39 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Banerjee, Debasmit, Patel, Pratik, Van Iderstine, David

Hello ffmpeg dev team,
Please look in attached patch.  while integrating FFmpeg we require to add "skip_cover_page" options to skip cover art atom from parsing for M4A / MP4 streams. By default values set as 0 ( False ) so it will not impact others.

Signed-off-by: Janpriya Malviya <Janpriya_Malviya@bose.com>
---
 libavformat/isom.h | 1 +
 libavformat/mov.c  | 7 +++++++
 2 files changed, 8 insertions(+)

diff --git a/libavformat/isom.h b/libavformat/isom.h
index 5caf42b..87f1fe3 100644
--- a/libavformat/isom.h
+++ b/libavformat/isom.h
@@ -315,6 +315,7 @@ typedef struct MOVContext {
     int have_read_mfra_size;
     uint32_t mfra_size;
     uint32_t max_stts_delta;
+    int skip_cover_page;
 } MOVContext;
 
 int ff_mp4_read_descr_len(AVIOContext *pb);
diff --git a/libavformat/mov.c b/libavformat/mov.c
index 6c847de..5e94946 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -201,6 +201,12 @@ static int mov_read_covr(MOVContext *c, AVIOContext *pb, int type, int len)
         return 0;
     }
 
+    if ( c->skip_cover_page ){
+        av_log(c->fc, AV_LOG_WARNING, "skip cover art from parsing \n");
+        avio_skip(pb, len);
+        return 0;
+    }
+
     sc = av_mallocz(sizeof(*sc));
     if (!sc)
         return AVERROR(ENOMEM);
@@ -8866,6 +8872,7 @@ static const AVOption mov_options[] = {
     { "enable_drefs", "Enable external track support.", OFFSET(enable_drefs), AV_OPT_TYPE_BOOL,
         {.i64 = 0}, 0, 1, FLAGS },
     { "max_stts_delta", "treat offsets above this value as invalid", OFFSET(max_stts_delta), AV_OPT_TYPE_INT, {.i64 = UINT_MAX-48000*10 }, 0, UINT_MAX, .flags = AV_OPT_FLAG_DECODING_PARAM },
+    { "skip_cover_page", "Skip cover pages from parsing ", OFFSET(skip_cover_page),AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, .flags = FLAGS },
 
     { NULL },
 };
-- 
2.7.4


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 5+ messages in thread