From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 448E7422AD for ; Sun, 1 May 2022 15:53:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0D9CB68B294; Sun, 1 May 2022 18:53:58 +0300 (EEST) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CBA1668A83B for ; Sun, 1 May 2022 18:53:51 +0300 (EEST) Received: by mail-lf1-f53.google.com with SMTP id w1so21712665lfa.4 for ; Sun, 01 May 2022 08:53:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=gq0yowyDrt5Xtd4g39EzXzNng6VnDy+7lPDNaxHdSOc=; b=KcIdJtSX3UlhRRgwGMpgCroiur3XmERMsUTuXXNMmczoRERbzFNVfQ3XykVnpRMdgq AdTCgokj4siB9cZZxRUnE7aFrC0mf6k9dpLqizGlV7zMAGOQJJ81cCU1tQ4IpERHjl4W 8NAUWeCeOPg7/o35Kw6+/ubNQPbq3BcXkc3FZsKfP3faGxoJZ4bkzG1lGGPnE8QX60S2 UBj+5B82TSdv6CFxDpmekHoxW1lkgzm8G8313UYnE3T2GTJow4FrKoEol4wVNXLyLtze rllUmB3+xlXwtK7ualqrksQwra7FHN4AifgvlhgVIJcNefvAC/lkgcSw8swBXuNklr5n sEHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=gq0yowyDrt5Xtd4g39EzXzNng6VnDy+7lPDNaxHdSOc=; b=gcpwu2DnnGMYygQZOX6FAIEx8TIlVQQTaJK03allFue+IG3a+8vjjKdtvKJKr0+Pwj SkpXnPwk38euswAQDIwRiO3fsuE/5pre2uft5qk3c39AcDBsZmYndNC6bBKnh/4ckUHk eIQAJwGoNOK3DeAfTKUGZz1tZ7Fy3KqLG3j1VvIywp753wY25OQWfGTDz/zPzgC2SKg4 Y7iskObkPn+TDLmG1HDXxkQySm3hWu0w3HkXrmizOQt7PcS9YYYiEQZGY2LHnYQWHPqr GRaSK6dbi4/osInAgh0umdUJLp3hI4M0aanvfM81lONefkqSQgYyIfXQltUqmmf38Oyz cX7w== X-Gm-Message-State: AOAM530Dmt7Jb+kSnnjwCMSBiLQLzW9LvdyJ9CQJDuHTOeT2KgwN3GTq U1pkdjLl6/RVsgt//eASvvqJrky7Y2kBXtmmlGfN52nc/c0= X-Google-Smtp-Source: ABdhPJxDJqrZ5PzxHMMfRXQUuiqzNbZryXpw0bYSR/WX0xNp9qGQtZj56DhDz1K2FamXxyf0VAgx5P1jraZ0CqoKY1I= X-Received: by 2002:ac2:5f4d:0:b0:448:7d37:5838 with SMTP id 13-20020ac25f4d000000b004487d375838mr6652009lfz.419.1651420430876; Sun, 01 May 2022 08:53:50 -0700 (PDT) MIME-Version: 1.0 References: <20220429104505.1747-1-tong1.wu@intel.com> In-Reply-To: From: Hendrik Leppkes Date: Sun, 1 May 2022 17:53:38 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2 1/5] avutil/hwcontext_d3d11va: fix the uninitialized texture bindflag X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, May 1, 2022 at 5:48 PM Hendrik Leppkes wrote: > > On Sun, May 1, 2022 at 7:09 AM Soft Works wrote: > > I think that's what Hendrik wanted to point out as far as I understood. > > > > Basically, I want explicit behavior, not implicit defaults. Anytime a > hwcontext is created, something should tell it what its going to be > used for, so we can determine which flags make sense (or ideally, it > should just specify the flags). > > This patch creates an implicit default for one use-case, is this going > to work with all others? No, of course not, because it has to know > what flags to set. Thats why explicitly setting those flags is > important, instead of just fixing one implicit case. > On that note, the example commandline it fixes just does hwupload and nothing else - does that even require render target to be flagged? >From what I can tell it uses a simple ID3D11DeviceContext::CopySubresourceRegion to copy from the staging texture, which should not require any particular bind flags. Bind Flags in turn would then depend on what you are actually trying to do with the texture (shader input, etc), in this example... nothing? - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".