From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D5DCE43756 for ; Wed, 27 Jul 2022 16:01:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C1F7168B864; Wed, 27 Jul 2022 19:01:26 +0300 (EEST) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E15C568B803 for ; Wed, 27 Jul 2022 19:01:19 +0300 (EEST) Received: by mail-lf1-f54.google.com with SMTP id m12so26678119lfj.4 for ; Wed, 27 Jul 2022 09:01:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=ecOt5Bgn1iVVfViO81JrFfMeQUlGChHb1pfWqg8rfeg=; b=LHDowKMmlvmpRENLQDqc0BQYkoi+55ysmr/W3ylGOcRbEM89DKM2tkrsR6+98KmDQo ANoAHk1OhsugogUBECdo3DxVZwqXYigq/q1R6O/paQpXUlElopTsEfSQuhi/VbUxIxd2 Jj1L4hbVm3kEZB2DslGOk3wn2V21faMDBYCqBzk1Hr+/JqJgR48EnDOOcEACsGx98Req aIkwTPeTmEupokq1i59vbZwSvHS/YrDpYN03Pk5vS/htfBYBjiJTOJb9FLuWJRMm9A2O XrwiBzA9oaimsQ99LcGbzs4omgQax/ppO+rLDpEftqpwfEbmAppOd/RBFRg/IM6qOjD3 On/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=ecOt5Bgn1iVVfViO81JrFfMeQUlGChHb1pfWqg8rfeg=; b=U/V4ubthmYCAfu9LyD0ziIh5Dpxy78cl6Rnh9wPekul1u1/MNqsfsWh4GfUrR9kHsm vAg7Oiyvpv2rhR1LaHdnjVJXQuUB7i4GZlFQL/kT98HGLpXI++IZlWKUV3H9TqM6ToBP FC7Os3horrMCOOQ1xgW0Q/52R2dmTHu+MdGV3LzNBNslqwxLOLxNcZ5L5fLCaGKGKz0O Mpw3kvqXrsuZBUloqhezsS2w5A2HlRA85m0W5DDX9309G3KzHSGaWDDzm5tHaWMmJU3J aJiunKyU5ZIcZ4roPAE9yrh0c307cZe9yYWOlcNc9u7WPl88NwIpZisnZJ1YhAOmpkPJ tovw== X-Gm-Message-State: AJIora9utd+6BVdVgYcpjgocFCQ4XobCO8F+YJtA+sq0LcXgSwE7DzI5 irKqARrFSAT0asvCYnVx6vxiPoD5+c3Dbp3/H3JdjK7d X-Google-Smtp-Source: AGRyM1visiI2v4FImNHSkuahGVhrfN5ZsYfej237l4fWDievIPEHdpz4mxcL4Q/jSBFL6erSz/btDejwL0r/Rk61mRM= X-Received: by 2002:a05:6512:3993:b0:48a:9236:ded5 with SMTP id j19-20020a056512399300b0048a9236ded5mr4600488lfu.684.1658937678204; Wed, 27 Jul 2022 09:01:18 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Hendrik Leppkes Date: Wed, 27 Jul 2022 18:01:05 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort(). X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, Jul 27, 2022 at 4:03 PM Julien Vary wrote: > > Replaced all abort() by av_abort() in the code. > On production systems, when dealing with malformed data, > avcodec was sometime aborting, with no core/memory dump > available to troubleshoot after-the-fact. > Adding av_abort_set_callback to register a custom > function (instead of the default straight abort() > behavior), to allow dumping before the actual abort(). > Also 'av_logging' the av_abort() location. > > Signed-off-by: Julien Vary abort() should generally not be in a reachable part of the code - not inside any of the libraries anyway, ffmpeg.c is a different topic. If it is reachable with any input files, and not just present to shut up compilers, this is a bug and should be addressed to return an error instead. Therefore, we should address those cases, and just leave abort as-is otherwise. Nevermind that av_abort would need to be a public function, which sounds like a really bad idea. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".