From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 31A7740CA6 for ; Sun, 6 Feb 2022 15:32:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6A95068B163; Sun, 6 Feb 2022 17:31:59 +0200 (EET) Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9AC4468B0AD for ; Sun, 6 Feb 2022 17:31:53 +0200 (EET) Received: by mail-yb1-f179.google.com with SMTP id p5so33291496ybd.13 for ; Sun, 06 Feb 2022 07:31:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=NtLiwiaEHq8cfdEVMAxmcLGPtyCcsmhaJzy/dCrVmVo=; b=B86I3aTSs/HhlI3LwxQOcExegGXE142lQbibGcleLcQjCadKsIIxJTFVImN0/IvjoC E3uN+b1ELBJ4Nq5/H5M+NwOzXmii4k3LyyvV6HBZtN89XKaITWPZb26fxadwDjb5DF1s bNjBeW4BmTlr5cXRq+Ym916j0gtg0bAVjHcv9kbmPi03v88eFED3JlyPzNJQPkzaS9Za 6tYdMmu7nsL0VufzRjk52rsTJMT8xivVfUKmdADYTe2YiiUhZLnXsGoXXqX9HiAorzga wZKFQgmM5M9AFw8BQNyVHfcMCaq/3FIMhqJVraIJKnEyJdN2/FtVK3CQj+rqg+/kNBPf Cx9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=NtLiwiaEHq8cfdEVMAxmcLGPtyCcsmhaJzy/dCrVmVo=; b=eKMKOdhZpiCh0UnS+27edmQSruCFocIRlfixHhsv840G+G9KoIf3/6CLhFSojO1KrI VNGEyvuMLn+5XATvAMya6C/fphME4dPPMmyBau/FSysD7pcmphpVDqkjal/b2kWNHcM2 jutFlTHvY5NNsjgqlHJDFXoRriSjZialCZZnOp05giA4hm/5S5TWv6OIab+wRuIAxopX xvsipJyDrMv4VOc2rOQ/2308vUiwcBUJY5tNAjSLaX6ZJ/Bu3RQkdZ9NCoaWmks5MHv8 dYaRbIiY4YXZJwnjeZj3uIKJZ0GoBN8nR7RBPRT8zUQyoZfrj1cUbk+rAe7HEPZ5Tsh5 AlXQ== X-Gm-Message-State: AOAM530q8R0ut4Qh864FcVlbmuLwqTfIr2TXpat7Kg4VjhMzQxcHlC2g r8FpK7wOLJ6pT3eXd0Yv2Dl04RHgFY1BCPWqqwd71FEu X-Google-Smtp-Source: ABdhPJwWfAQg5Sfx9CE9svEJQRILgI5tOwAHQhALsyGdpf5mK5eVVHXsnSI/Gv4zqT3V3ksEioaQVKkoBhcQ1aw+QF8= X-Received: by 2002:a25:5045:: with SMTP id e66mr2508529ybb.338.1644161511858; Sun, 06 Feb 2022 07:31:51 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Hendrik Leppkes Date: Sun, 6 Feb 2022 16:31:40 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h264dec: add option to ignore in band parameter set X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, Feb 6, 2022 at 3:58 PM Zhao Zhili wrote: > > It works in three mode: > 0: don't ignore in-band ps > 1: ignore in-band ps > -1: if corrupted data is detected, then ignore in-band ps afterwards > > h264dec working hard to do error resilience, it doesn't drop a > whole packet when error is detected in a nalu. Then there is a > higher chance for fake sps/pps be found and used. This happened > in a mp4 file. h264dec failed to recovery after broken data due > to the fake pps, while other H.264 decoders have no such problem. This seems extremely hacky. I think you need to elaborate on the problem you are trying to fix, so that any approach to a solution can be judged properly. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".