Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Hendrik Leppkes <h.leppkes@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h264dec: add option to ignore in band parameter set
Date: Sun, 6 Feb 2022 16:31:40 +0100
Message-ID: <CA+anqdxif=-XpLizaK42d_gxQXwdLGZWEpt9V5OsrMOW3qHL=A@mail.gmail.com> (raw)
In-Reply-To: <tencent_56A9004EB8255CB305C85EB3E8F36D15C805@qq.com>

On Sun, Feb 6, 2022 at 3:58 PM Zhao Zhili <quinkblack@foxmail.com> wrote:
>
> It works in three mode:
> 0: don't ignore in-band ps
> 1: ignore in-band ps
> -1: if corrupted data is detected, then ignore in-band ps afterwards
>
> h264dec working hard to do error resilience, it doesn't drop a
> whole packet when error is detected in a nalu. Then there is a
> higher chance for fake sps/pps be found and used. This happened
> in a mp4 file. h264dec failed to recovery after broken data due
> to the fake pps, while other H.264 decoders have no such problem.

This seems extremely hacky. I think you need to elaborate on the
problem you are trying to fix, so that any approach to a solution can
be judged properly.

- Hendrik
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-02-06 15:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-06 14:58 Zhao Zhili
2022-02-06 15:31 ` Hendrik Leppkes [this message]
2022-02-06 17:56   ` "zhilizhao(赵志立)"

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+anqdxif=-XpLizaK42d_gxQXwdLGZWEpt9V5OsrMOW3qHL=A@mail.gmail.com' \
    --to=h.leppkes@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git