From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EE2DD42AC7 for ; Fri, 13 May 2022 09:00:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D4E9268B41C; Fri, 13 May 2022 12:00:28 +0300 (EEST) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ACAE368B3ED for ; Fri, 13 May 2022 12:00:22 +0300 (EEST) Received: by mail-lj1-f174.google.com with SMTP id t25so9492171ljd.6 for ; Fri, 13 May 2022 02:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=JpHTVt691MuVKmGb9pIpTdO23p27qtR4wVlo7/omPqI=; b=X4bzMIR7gWRrg+c15DcZdJfGORIvIJylSSaDVa7uEgJuqhkW57arEbPH6UEu76ef1A POsmWjj8kMtArPkZw/smzpzdQfV6fJyDBKacucm381p3WfoT94ZMSbEwhcx3Sr5qMEct PSPaBmkRBqV8PQUxul2h4Y683FnpwBSJUMvWSHNtvmLMOGxvPs24Q1P0qBwCntKKYihE Qxui8iPiVjN//gHojzraI4vLGCSzcpWJNFfsOAmK4mSSjqGkxiLmGt+HoSmB4AaehLNo WgXPDW654WGAT1lGlUnhJqfhq3os/AGBcfyhrew17v4DWH/q6vbBs8wXIokiYmTIlyF7 i+oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=JpHTVt691MuVKmGb9pIpTdO23p27qtR4wVlo7/omPqI=; b=R6XOZ8ZcaXdTqDQdtUAefVG6PF2aV7COPrmwYD8s4tlQU2Nc2NbBaQMZC3S4GsifKP 7VbHWAConMTOR3OI25H85FT8VPh+hxyU4PELabR/ZlCU42MnapULrKXY0aFYpXIWyeY2 0FHC9+WiDrzQL5OAKNLqCs58zR+072+K0+6V0q6sINXG15eqUUKUmIP3welzLUQeuLWF GMVLP51PZUyEPDfoMF98dzsFkqJ+6EjbSULKe1dxf8Gevwwh3Z5/baY6nJvPu0u+JdjI RSBs3EFce3bwmvjaaj90y2M/bWFcmpcR22wKf8Gkd8b/Wo4kVmoKT7cC7jzlVPvypMVE zw1g== X-Gm-Message-State: AOAM532eCdDzjwNNYqoYjmMXV5YuVX1138vdWC9CZ8vW0PFJj1/uT7up i7ho/YSlIVTQL/2foiW6ZuKQPpUZW+ALsetVfRWY8wO6 X-Google-Smtp-Source: ABdhPJwOdWh5o6owtuKKtf0Odk/SRrMJ75cxnhV1El0bj0aaYzwTi1EVAgoRBPnJWuTpfcu4FKcH0GMJz73CK6gnNmo= X-Received: by 2002:a2e:9c46:0:b0:24f:4642:cea1 with SMTP id t6-20020a2e9c46000000b0024f4642cea1mr2538250ljj.138.1652432421045; Fri, 13 May 2022 02:00:21 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Hendrik Leppkes Date: Fri, 13 May 2022 11:00:09 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move ff_nlmeans_init into a header X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, May 13, 2022 at 10:27 AM Andreas Rheinhardt wrote: > > Soft Works: > > > > > >> -----Original Message----- > >> From: ffmpeg-devel On Behalf Of > >> Andreas Rheinhardt > >> Sent: Tuesday, May 3, 2022 8:38 AM > >> To: ffmpeg-devel@ffmpeg.org > >> Cc: Andreas Rheinhardt > >> Subject: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move > >> ff_nlmeans_init into a header > >> > >> This removes a dependency of checkasm on lavfi/vf_nlmeans.o > >> and also allows to inline ff_nlmeans_init() irrespectively of > >> interposing. > >> > >> Signed-off-by: Andreas Rheinhardt > >> --- > > > > [..] > > > >> + > >> +static av_unused void ff_nlmeans_init(NLMeansDSPContext *dsp) > >> +{ > >> + dsp->compute_safe_ssd_integral_image = > >> compute_safe_ssd_integral_image_c; > >> + dsp->compute_weights_line = compute_weights_line_c; > >> + > >> + if (ARCH_AARCH64) > >> + ff_nlmeans_init_aarch64(dsp); > > > > Hi Andreas, > > > > the above breaks compilation for me: > > > > 1>libavfilterd.lib(libavfilter_vf_nlmeans.obj) : error LNK2019: unresolved external symbol ff_nlmeans_init_aarch64 referenced in function ff_nlmeans_init > > > > The reason is that I'm (obviously) not compiling stuff from the > > libavfilter\aarch64 subfolder. > > > > It might need an #ifdef ? > > > > I haven't taken a deeper look at it, though. > > > > Thanks, > > softworkz > > > > > > That surprises me: The earlier code did exactly the same; in fact, using > if (ARCH_*) is our typical check for arches in dsp-init code. > Is this the only place where this happens? > #ifdef is certainly wrong: All ARCH_* are always defined; they are just > 0 or 1. > Anyway, will send a patch with #if. > The inlining due to the code coming from a header probably breaks dead-code-elimination in some compilers. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".