From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E23C642954 for ; Mon, 10 Jan 2022 10:31:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3586968AE7C; Mon, 10 Jan 2022 12:31:26 +0200 (EET) Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 592256801EB for ; Mon, 10 Jan 2022 12:31:20 +0200 (EET) Received: by mail-yb1-f169.google.com with SMTP id m6so26327911ybc.9 for ; Mon, 10 Jan 2022 02:31:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=yTxtRvssyEqIfc+8NWMXvbdHOpPhKog1EtEv8qRb1co=; b=obF8HEHLFkNydhn4OeJjR39e8k8+fQLFGdUs8oWYLRNlL3m+R9oXbtP4Z0W073kmLs jr2XcWbLEr+Q9q73DI3Mzk5KT04Xt5eDzCH5t+TBJR7OMOWC718Qs2cvFfp3D4warQBC B5uuTvjf+OauN/xGpStZQxDW2/lfefGwnCQXFh/nkJsTHkmJKoUrTvbiocxDACwo2Ttd fTA4CorS3NhnYcUG8kVFIOCLamvpAf4NNHwX/5QGu/3TzHW8oePslrqap972BoC6gFB2 YKHax2joFzCQyHGeEfZRXGWPl8BaZE9aIYYYXua2Zcr6LRotZ0qb8eJQ8WLYsLqRuVSo 0Erg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=yTxtRvssyEqIfc+8NWMXvbdHOpPhKog1EtEv8qRb1co=; b=JiFdFJ0WVoDbnF++TeM7Q/A6nvNYDloZdLcrWf4cYU4sDY8usHnAYBCrXkCEf5XWah p1dInTiV0uJKt9pkgpY5g/CuCN+uVcfW2ODGbo+IbK2Tau+sG1a3to8nzkgAeS2MVANU +TaodtLMNvVfDGlZdxO1MY2w+qaa+p96Af6CsFSpqC+iKd+LntKWx/JX9FdsBS3jcmpi rvfiF6vkVBNyiCIGSfMF92L16lGWbWY6F5uIG45SDLsa3fJaI1xCyDag+Por08PSY10o G1sNubBRlU/jzMPfR622Lo1QfslrvnCYQVoOJshqhjBAvbj4F9Lu17ArAKbIfp8+VdWJ gdAg== X-Gm-Message-State: AOAM530IeYiQgzB3k3C3O/eoJtDkfWdjjDzADQuynVk/MApOmGSzUxva OpWKDDhgzKNpClejU1FfZxWhRO0l5q0mtJT4p+Fp3Bff X-Google-Smtp-Source: ABdhPJw5WV4kF0HTWhZ/oUkqJM7sm0OyUf4JT9zEGGBPUZL71WFYAjRUVgNSggdMAF33Nu6ZcYaOP2btGbhcuGULkB4= X-Received: by 2002:a25:8550:: with SMTP id f16mr34764560ybn.319.1641810678729; Mon, 10 Jan 2022 02:31:18 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Hendrik Leppkes Date: Mon, 10 Jan 2022 11:31:06 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't dump images to disk based on DEBUG define X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, Jan 7, 2022 at 5:14 PM Soft Works wrote: > > > > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of Hendrik > > Leppkes > > Sent: Friday, January 7, 2022 11:32 AM > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't > > dump images to disk based on DEBUG define > > > > On Fri, Jan 7, 2022 at 11:20 AM Hendrik Leppkes wrote: > > > > > > On Fri, Jan 7, 2022 at 5:50 AM ffmpegagent wrote: > > > > > > > > It's annoying and unexpected, but still useful at times (as I've realized > > > > just recently). > > > > > > > > This is a follow-up to the earlier submission here: > > > > https://www.mail-archive.com/ffmpeg-devel@ffmpeg.org/msg128080.html > > > > > > > > There has been a comment from Anton, questioning whether the dump-feature > > is > > > > useful. Meanwhile I came to the conclusion that it can be useful in-fact. > > It > > > > just shouldn't happen automatically when DEBUG is defined. That's what > > these > > > > patches do. > > > > > > > > I also added fixes for the fopen() call. > > > > > > > > softworkz (4): > > > > avcodec/dvbsubdec: don't dump images to disk based on DEBUG define > > > > avcodec/dvbsubdec: fix writing ppm > > > > avcodec/dvdsubdec: don't dump images to disk based on DEBUG define > > > > avcodec/dvdsubdec: fix writing ppm > > > > > > > > libavcodec/dvbsubdec.c | 20 +++++++++++++------- > > > > libavcodec/dvdsubdec.c | 11 ++++++++--- > > > > 2 files changed, 21 insertions(+), 10 deletions(-) > > > > > > > > > > > > > > These patches need some squasing. It should've been obvious from them > > > being duplicated. > > > > > > > Actually I fell into the dvb dvd trap, but regardless the patches are > > basically identical, so I would still squash them, personally. > > No problem, but in which way? > > 1. All 4 commits into a single one > 2. 4 >> 2 horizontally (a single one for the debug commits and a single > one for the fopen commits) > 3. 4 >> 2 vertically (a single commit for dvb and a single one for dvd) > I figured combining the patches that do the exact same thing for the two different decoders. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".