[FFmpeg-devel] [PATCH] configure: autodetect vulkan

[FFmpeg-devel] [PATCH] configure: autodetect vulkan

[Lynne]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

Recently, Metal support was merged, which is autodetected
by default. Metal doesn't even have a hwcontext and it's not
a hwaccel, nor would it likely ever be one as Apple won't drop
videotoolbox.

To keep it fair, autodetect Vulkan, which is a hwcontext,
and for which there is an unmerged hwaccel patch.

Patch attached.


[-- Attachment #2: 0001-configure-autodetect-vulkan.patch --]
[-- Type: text/x-patch, Size: 1106 bytes --]

From 1f5243450242039f82a91e7eccb724af4b6ef37c Mon Sep 17 00:00:00 2001
From: Lynne <dev@lynne.ee>
Date: Mon, 20 Dec 2021 11:04:49 +0100
Subject: [PATCH] configure: autodetect vulkan

---
 configure | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index d8b07c8e00..5b6e578253 100755
--- a/configure
+++ b/configure
@@ -324,7 +324,7 @@ External library support:
   --disable-securetransport disable Secure Transport, needed for TLS support
                            on OSX if openssl and gnutls are not used [autodetect]
   --enable-vapoursynth     enable VapourSynth demuxer [no]
-  --enable-vulkan          enable Vulkan code [no]
+  --disable-vulkan         enable Vulkan code [autodetect]
   --disable-xlib           disable xlib [autodetect]
   --disable-zlib           disable zlib [autodetect]
 
@@ -1896,6 +1896,7 @@ HWACCEL_AUTODETECT_LIBRARY_LIST="
     vaapi
     vdpau
     videotoolbox
+    vulkan
     v4l2_m2m
     xvmc
 "
@@ -1918,7 +1919,6 @@ HWACCEL_LIBRARY_LIST="
     mmal
     omx
     opencl
-    vulkan
 "
 
 DOCUMENT_LIST="
-- 
2.34.1


[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] configure: autodetect vulkan

[Anton Khirnov]

Quoting Lynne (2021-12-20 11:15:08)
> Recently, Metal support was merged, which is autodetected
> by default. Metal doesn't even have a hwcontext and it's not
> a hwaccel, nor would it likely ever be one as Apple won't drop
> videotoolbox.
> 
> To keep it fair, autodetect Vulkan, which is a hwcontext,
> and for which there is an unmerged hwaccel patch.

vaapi and vdpau seem to be autodetected, so sure why not

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] configure: autodetect vulkan

[Hendrik Leppkes]

On Mon, Dec 20, 2021 at 11:15 AM Lynne <dev@lynne.ee> wrote:
>
> Recently, Metal support was merged, which is autodetected
> by default. Metal doesn't even have a hwcontext and it's not
> a hwaccel, nor would it likely ever be one as Apple won't drop
> videotoolbox.
>
> To keep it fair, autodetect Vulkan, which is a hwcontext,
> and for which there is an unmerged hwaccel patch.
>

"fair"? what kind of argument is that? Is there a big hw competition on?

Not that i'm against the change, but please argue on technical merits,
not some nonsense.

- Hendrik
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] configure: autodetect vulkan

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1536 bytes --]

On Mon, Dec 20, 2021 at 11:15:08AM +0100, Lynne wrote:
> Recently, Metal support was merged, which is autodetected
> by default. Metal doesn't even have a hwcontext and it's not
> a hwaccel, nor would it likely ever be one as Apple won't drop
> videotoolbox.
> 
> To keep it fair, autodetect Vulkan, which is a hwcontext,
> and for which there is an unmerged hwaccel patch.
> 
> Patch attached.
> 

>  configure |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 09c6bfd367bd2ac897abc5716e2e9605341036cd  0001-configure-autodetect-vulkan.patch
> From 1f5243450242039f82a91e7eccb724af4b6ef37c Mon Sep 17 00:00:00 2001
> From: Lynne <dev@lynne.ee>
> Date: Mon, 20 Dec 2021 11:04:49 +0100
> Subject: [PATCH] configure: autodetect vulkan

breaks build here on ubuntu

./configure
ERROR: defined VK_VERSION_1_2 not satisfied

If you think configure made a mistake, make sure you are using the latest
version from Git.  If the latest version fails, report the problem to the
ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.libera.chat.
Include the log file "ffbuild/config.log" produced by configure as this will help
solve the problem.

[....]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] configure: autodetect vulkan

[Lynne]

[-- Attachment #1: Type: text/plain, Size: 1384 bytes --]

20 Dec 2021, 17:59 by michael@niedermayer.cc:

> On Mon, Dec 20, 2021 at 11:15:08AM +0100, Lynne wrote:
>
>> Recently, Metal support was merged, which is autodetected
>> by default. Metal doesn't even have a hwcontext and it's not
>> a hwaccel, nor would it likely ever be one as Apple won't drop
>> videotoolbox.
>>
>> To keep it fair, autodetect Vulkan, which is a hwcontext,
>> and for which there is an unmerged hwaccel patch.
>>
>> Patch attached.
>>
>> configure |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 09c6bfd367bd2ac897abc5716e2e9605341036cd  0001-configure-autodetect-vulkan.patch
>> From 1f5243450242039f82a91e7eccb724af4b6ef37c Mon Sep 17 00:00:00 2001
>> From: Lynne <dev@lynne.ee>
>> Date: Mon, 20 Dec 2021 11:04:49 +0100
>> Subject: [PATCH] configure: autodetect vulkan
>>
>
> breaks build here on ubuntu
>
> ./configure
> ERROR: defined VK_VERSION_1_2 not satisfied
>
> If you think configure made a mistake, make sure you are using the latest
> version from Git.  If the latest version fails, report the problem to the
> ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.libera.chat.
> Include the log file "ffbuild/config.log" produced by configure as this will help
> solve the problem.
>

Thanks for testing, V2 attached, just changes require_cpp to check_cpp,
since autodetecting is not a hard-require unlike enabling libraries.

[-- Attachment #2: v2-0001-configure-autodetect-vulkan.patch --]
[-- Type: text/x-patch, Size: 1536 bytes --]

From 57086023a05a981609f68f7760e1398b3211e0ab Mon Sep 17 00:00:00 2001
From: Lynne <dev@lynne.ee>
Date: Mon, 20 Dec 2021 11:04:49 +0100
Subject: [PATCH v2] configure: autodetect vulkan

---
 configure | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/configure b/configure
index d8b07c8e00..3be4de61e0 100755
--- a/configure
+++ b/configure
@@ -324,7 +324,7 @@ External library support:
   --disable-securetransport disable Secure Transport, needed for TLS support
                            on OSX if openssl and gnutls are not used [autodetect]
   --enable-vapoursynth     enable VapourSynth demuxer [no]
-  --enable-vulkan          enable Vulkan code [no]
+  --disable-vulkan         enable Vulkan code [autodetect]
   --disable-xlib           disable xlib [autodetect]
   --disable-zlib           disable zlib [autodetect]
 
@@ -1896,6 +1896,7 @@ HWACCEL_AUTODETECT_LIBRARY_LIST="
     vaapi
     vdpau
     videotoolbox
+    vulkan
     v4l2_m2m
     xvmc
 "
@@ -1918,7 +1919,6 @@ HWACCEL_LIBRARY_LIST="
     mmal
     omx
     opencl
-    vulkan
 "
 
 DOCUMENT_LIST="
@@ -6914,7 +6914,7 @@ enabled crystalhd && check_lib crystalhd "stdint.h libcrystalhd/libcrystalhd_if.
 
 if enabled vulkan; then
     check_pkg_config_header_only vulkan "vulkan >= 1.2.189" "vulkan/vulkan.h" "defined VK_VERSION_1_2" ||
-        require_cpp_condition vulkan "vulkan/vulkan.h" "defined VK_VERSION_1_2"
+        check_cpp_condition vulkan "vulkan/vulkan.h" "defined VK_VERSION_1_2"
 fi
 
 if enabled x86; then
-- 
2.34.1


[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] configure: autodetect vulkan

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1784 bytes --]

On Mon, Dec 20, 2021 at 06:45:43PM +0100, Lynne wrote:
> 20 Dec 2021, 17:59 by michael@niedermayer.cc:
> 
> > On Mon, Dec 20, 2021 at 11:15:08AM +0100, Lynne wrote:
> >
> >> Recently, Metal support was merged, which is autodetected
> >> by default. Metal doesn't even have a hwcontext and it's not
> >> a hwaccel, nor would it likely ever be one as Apple won't drop
> >> videotoolbox.
> >>
> >> To keep it fair, autodetect Vulkan, which is a hwcontext,
> >> and for which there is an unmerged hwaccel patch.
> >>
> >> Patch attached.
> >>
> >> configure |    4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >> 09c6bfd367bd2ac897abc5716e2e9605341036cd  0001-configure-autodetect-vulkan.patch
> >> From 1f5243450242039f82a91e7eccb724af4b6ef37c Mon Sep 17 00:00:00 2001
> >> From: Lynne <dev@lynne.ee>
> >> Date: Mon, 20 Dec 2021 11:04:49 +0100
> >> Subject: [PATCH] configure: autodetect vulkan
> >>
> >
> > breaks build here on ubuntu
> >
> > ./configure
> > ERROR: defined VK_VERSION_1_2 not satisfied
> >
> > If you think configure made a mistake, make sure you are using the latest
> > version from Git.  If the latest version fails, report the problem to the
> > ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.libera.chat.
> > Include the log file "ffbuild/config.log" produced by configure as this will help
> > solve the problem.
> >
> 
> Thanks for testing, V2 attached, just changes require_cpp to check_cpp,
> since autodetecting is not a hard-require unlike enabling libraries.

that fixes the issue

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] configure: autodetect vulkan

["zhilizhao(赵志立)"]

> On Dec 21, 2021, at 1:45 AM, Lynne <dev@lynne.ee> wrote:
> 
> 
> Thanks for testing, V2 attached, just changes require_cpp to check_cpp,
> since autodetecting is not a hard-require unlike enabling libraries.


> diff --git a/configure b/configure
> index d8b07c8e00..3be4de61e0 100755
> --- a/configure
> +++ b/configure
> @@ -324,7 +324,7 @@ external library support:
>    --disable-securetransport disable secure transport, needed for tls support
>                             on osx if openssl and gnutls are not used [autodetect]
>    --enable-vapoursynth     enable vapoursynth demuxer [no]
> -  --enable-vulkan          enable vulkan code [no]
> +  --disable-vulkan         enable vulkan code [autodetect]

'enable vulkan code’ —> ‘disable vulkan code'

> 
> <v2-0001-configure-autodetect-vulkan.patch>_______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] configure: autodetect vulkan

[Lynne]

21 Dec 2021, 08:05 by quinkblack@foxmail.com:

>
>
>> On Dec 21, 2021, at 1:45 AM, Lynne <dev@lynne.ee> wrote:
>>
>>
>> Thanks for testing, V2 attached, just changes require_cpp to check_cpp,
>> since autodetecting is not a hard-require unlike enabling libraries.
>>
>
>
>> diff --git a/configure b/configure
>> index d8b07c8e00..3be4de61e0 100755
>> --- a/configure
>> +++ b/configure
>> @@ -324,7 +324,7 @@ external library support:
>>  --disable-securetransport disable secure transport, needed for tls support
>>  on osx if openssl and gnutls are not used [autodetect]
>>  --enable-vapoursynth     enable vapoursynth demuxer [no]
>> -  --enable-vulkan          enable vulkan code [no]
>> +  --disable-vulkan         enable vulkan code [autodetect]
>>
>
> 'enable vulkan code’ —> ‘disable vulkan code'
>

Changed, and applied, thanks to the review.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".