From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D8B20456ED for ; Sat, 18 Feb 2023 18:59:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DC6B068BECE; Sat, 18 Feb 2023 20:59:52 +0200 (EET) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BD61C68BD14 for ; Sat, 18 Feb 2023 20:59:46 +0200 (EET) Received: by mail-lf1-f52.google.com with SMTP id i15so1449324lfp.12 for ; Sat, 18 Feb 2023 10:59:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=yKpuPkhDhk4EKAByAhZeAP494Iu7XSbzMApMODjbMxY=; b=U2nJMTwzCooOmg32j0svCLzSnjBn9cmKSmikJXRPSykFGujlDTBPGpVO7j1wrOvOA+ XcSXUZr2mvmMCYuWOSQk+mEw9btOb3O7DU7YhHgFL3/uWmfIlS6St6CGgJIyXyM/bAPD 0CvGsphSNtnTdG6+RN9eYbt8TJghOTwWBoL8lys6I4bu4so2ffQcTZkx8Peuu7hjXRqy HywOIUok6S/XCg4j3YCCHX2SkklRONSMzVEg8p15qelBWQIBIji3jv7aENauozPQQMNp mXh7SJkPbbstFD25cs66ZlqL4kYlh/HETEF+7lwUC7K/qpoECzFG0Yaf1rSSHEQ4CZNJ SIGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yKpuPkhDhk4EKAByAhZeAP494Iu7XSbzMApMODjbMxY=; b=WnkU3+sy5gywCbEHSgzZzlqJDLHkhzRtIFZVUxdd0wB5LKq2i5XmdxotNMXtGbSKi0 mGRPyDdWwvKnu5QaIwlWlRQGjrPqg7mDx/0gsLv69DjgbdU64gWjOgbEVaFZnE5MJsgy a7Y5ZvdsQ1ecL+VNXgjVMjZk4buGffJneElAKBgiktuHAeVcq4uX0fXkH5vueJ3zq1Rp i7hi/LYa7QUXmZMT7OlDz0wxCqmagbx11aQesdw03ufhEYx51zOMY7CUi+oGw9sSM/0B nIxVILlDNucGho4dgOZC6ebzpzRdSM+CNnveO7O+1c+bdtTYdDwPGhHYDrIt2Z5fcEwP 5o5Q== X-Gm-Message-State: AO0yUKXRz/HWgpchnvhBgFFLfvwKnRyHGkMu9i+xpGaHY2m9yvFqsNsG MU2eFz0XIT0KRvg0HcVtuaDbSFQGXqFtNhikMR24elL5 X-Google-Smtp-Source: AK7set93Zwr+vs2whZOzP+m/ypOV9pje2FgSpe56muDT4Fn7TUt/kriEq5iGSNZXty0d5LVUz7AnDU2W9/cuY22FBTw= X-Received: by 2002:ac2:495e:0:b0:4d5:ca32:9bd7 with SMTP id o30-20020ac2495e000000b004d5ca329bd7mr1481673lfi.3.1676746785010; Sat, 18 Feb 2023 10:59:45 -0800 (PST) MIME-Version: 1.0 References: <20230218174955.372237-1-marth64@proxyid.net> In-Reply-To: <20230218174955.372237-1-marth64@proxyid.net> From: Hendrik Leppkes Date: Sat, 18 Feb 2023 19:59:32 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/eac3dec: add detection of Atmos spatial extension profile X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, Feb 18, 2023 at 6:50 PM Marth64 wrote: > > Signed-off-by: Marth64 > --- > - Missed adding the profiles to actual codec descriptor in ac3dec_float > - Formatting tidyness > > libavcodec/ac3dec.c | 3 +++ > libavcodec/ac3dec.h | 1 + > libavcodec/ac3dec_float.c | 2 ++ > libavcodec/avcodec.h | 2 ++ > libavcodec/codec_desc.c | 1 + > libavcodec/eac3dec.c | 11 ++++++++++- > libavcodec/profiles.c | 5 +++++ > libavcodec/profiles.h | 1 + > 8 files changed, 25 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c > index 0b120e6140..b5f4b166d3 100644 > --- a/libavcodec/ac3dec.c > +++ b/libavcodec/ac3dec.c > @@ -1714,6 +1714,9 @@ skip: > if (!err) { > avctx->sample_rate = s->sample_rate; > avctx->bit_rate = s->bit_rate + s->prev_bit_rate; > + > + if (s->eac3_extension_type_a == 1) > + avctx->profile = s->eac3_extension_type_a == 1 ? FF_PROFILE_EAC3_DDP_ATMOS : FF_PROFILE_UNKNOWN; > } You have to leave out the if(..) for this to make sense. :) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".