From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5A8A4427DA for ; Fri, 7 Jan 2022 10:32:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D5E4968AA6A; Fri, 7 Jan 2022 12:31:59 +0200 (EET) Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 443F468072A for ; Fri, 7 Jan 2022 12:31:53 +0200 (EET) Received: by mail-yb1-f182.google.com with SMTP id w184so15532043ybg.5 for ; Fri, 07 Jan 2022 02:31:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=109wC8g9jOKYqm1rVOdL6/qL5Sxo9XoppL74YAjggvE=; b=OiAS7zN1he/kCZxtYwr1xe3OeRN1qJwfE2tO6J3rXbDdlwBvD+3m6R5mekiqkYZWat 2VhVWEKur4VpoiU1QRcCbquSYp68UoxHJad+GUyixdyRgHpI4K+tHyxb1fBK4wLAuFNW ocWu2yIL6Z8pKCIuAorR2vHBmftXcsBLeELj0ZOVFdTXok2dkNTZO7i2AZYHTIcLkaHE kZFmRz81I2DfnmY7gfpPRV0AJAiU2DYKkVsvFf3oAlaD3qNkFNtkuQTFMl81WWbG9kZX a9HYs3OxHElQ8kXyx8EGoFOD1QUd9OKrl2BQqheHPt4nBWK16/VDBNvCML2AwqCf1i6M Myrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=109wC8g9jOKYqm1rVOdL6/qL5Sxo9XoppL74YAjggvE=; b=SHpRZ9wTaCmQasIP9569XSOhq+8Q3rBmcVF+c8nHiG8/LgR4nSbInJIIepq9sUzShc DhNiuNZlAyHmJVvHMSZqXpkHyy31AIVdr+mST4NyuKcIjTmxdqQ34vZ41gdBcQxvsobF fhRIyKpUTce/mK9GNNx5Wxny7nOZkbn5BDdc6p2Vhm8txQZNbHfQOS513H88iC2LK1f4 B3CyxvQMqrZnWGy4wyTIjyb/NAHZUIhj7vsdKQ+CGdxyiXmYNDSrFCdTHTioAbY7+vE2 uIHGgjWeJSc7wdf6+aozGro8i46t1SnpeMZeVLPjn5RO6KL7Sa7UTNnNBcc14nZMHKY5 xvRA== X-Gm-Message-State: AOAM532ktj/Uv4PBU0/s/v77fT0GVVfHkVoKxr5oCQMRUOjuWG6K0fYa tXf1Apmr3Q0/MSfxUchMuab3X/aXvZ6WtbUjUXFoOBPF X-Google-Smtp-Source: ABdhPJy764YoTYxXWmn3oGhUX+540f2O5cD5CQR2Fs94+aNU08pF6i1OFF57qPoT0jmcGslD9wjuVYj+JWWVH9ti1hg= X-Received: by 2002:a05:6902:110d:: with SMTP id o13mr88305777ybu.715.1641551511754; Fri, 07 Jan 2022 02:31:51 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Hendrik Leppkes Date: Fri, 7 Jan 2022 11:31:40 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't dump images to disk based on DEBUG define X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, Jan 7, 2022 at 11:20 AM Hendrik Leppkes wrote: > > On Fri, Jan 7, 2022 at 5:50 AM ffmpegagent wrote: > > > > It's annoying and unexpected, but still useful at times (as I've realized > > just recently). > > > > This is a follow-up to the earlier submission here: > > https://www.mail-archive.com/ffmpeg-devel@ffmpeg.org/msg128080.html > > > > There has been a comment from Anton, questioning whether the dump-feature is > > useful. Meanwhile I came to the conclusion that it can be useful in-fact. It > > just shouldn't happen automatically when DEBUG is defined. That's what these > > patches do. > > > > I also added fixes for the fopen() call. > > > > softworkz (4): > > avcodec/dvbsubdec: don't dump images to disk based on DEBUG define > > avcodec/dvbsubdec: fix writing ppm > > avcodec/dvdsubdec: don't dump images to disk based on DEBUG define > > avcodec/dvdsubdec: fix writing ppm > > > > libavcodec/dvbsubdec.c | 20 +++++++++++++------- > > libavcodec/dvdsubdec.c | 11 ++++++++--- > > 2 files changed, 21 insertions(+), 10 deletions(-) > > > > > > These patches need some squasing. It should've been obvious from them > being duplicated. > Actually I fell into the dvb dvd trap, but regardless the patches are basically identical, so I would still squash them, personally. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".