From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 35224404B3 for ; Wed, 23 Mar 2022 14:17:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AE4B668AFFB; Wed, 23 Mar 2022 16:17:28 +0200 (EET) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2CB52680246 for ; Wed, 23 Mar 2022 16:17:22 +0200 (EET) Received: by mail-yb1-f174.google.com with SMTP id j2so3011513ybu.0 for ; Wed, 23 Mar 2022 07:17:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=tSsKxEonM73tp4tx/pGaeFYDGUL7qhXHihAmoFRGNv4=; b=F1bE2XrV5Ug5tsCfrfufthi4MRime+Z4tcZAQMGobrtY8736zXWMjVFkTzSgJmER+L Ys9QyWbVt69Z+NZJDbqHYq7ZwFOTsX1biD3i5Tz0XdYhB2llHHkuo1obeGMvkmy2WHr0 e3mf4rCX8F99LiJuUps/eisfiJHj0eD/dbdV1f4DIXTrtd9a0TE8lhHIpin3PBBgF4Gq deFOtSj5ebXPN+whpiRTvm7Jqby7mUwmxtajqCCaFOcL4wL3QggqDKM/UVpq8zWGE/Ub HNhsMt0AQyQC3jZ3eYZrHJY9tgdNNvkx4ItZPB+LUVB6Vq+ickgD+W9uI121BMvJb5xR a8CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=tSsKxEonM73tp4tx/pGaeFYDGUL7qhXHihAmoFRGNv4=; b=rEDSla6q/ifTrjGRwzs0zQ7fR8FFv0yHYtIvKJTTh192soMth78yr99MR4FA/mX4cf 63dRGmEghTRyIpg2IBjO4OjBm+fP19U2IReENZxjvP2Ve84mLqSqLxId7KuJk1qV+1Ib W5PP8VI9GR+zDSKP/W0P9JfZJzYVdxEFxWUuHBIHixMV+KrdgjCGoM7mF2ExicSIWJSX eMj9ydXkb+ekYtaMfckmnFGxlgGkfTvX05Yt6Dw0Knt9bBMdOFgl3Des/VC4268yShOJ U9PgPc7ju0rhSrfVBE41oGu3rILWjC9Dj27oXL/nLfJNn3Pnpqjq3xSCSnB6QbrXgavY NrQQ== X-Gm-Message-State: AOAM5338hnq7t1Ze02x6gKOe1XfWpNUR/qw0lNTFdD94whIPZZUii2Wq PYJtZbVhFPJp7oJUpte0CoddHbxmpZ4vF/KaWOcElUpo X-Google-Smtp-Source: ABdhPJwUQT+2FTlYagVwbWqDGHtwCAezJ7s3q+pmZqeiPr/VrcWPOgUVMh6ftUJXWOA/RbGvwEAYd26Sho1QchKHAoU= X-Received: by 2002:a25:2317:0:b0:634:a74:e021 with SMTP id j23-20020a252317000000b006340a74e021mr150746ybj.498.1648045040352; Wed, 23 Mar 2022 07:17:20 -0700 (PDT) MIME-Version: 1.0 References: <20220323135426.32530-1-robux4@ycbcr.xyz> In-Reply-To: <20220323135426.32530-1-robux4@ycbcr.xyz> From: Hendrik Leppkes Date: Wed, 23 Mar 2022 15:17:07 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] dxva2_hevc: don't use frames as reference if they are not marked as such X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, Mar 23, 2022 at 2:54 PM Steve Lhomme wrote: > > Similar to how a frame is considered for referencing for the RefPicList array. > This will do the same for RefPicSetStCurrBefore, RefPicSetStCurrAfter and > RefPicSetLtCurr. > > Fixes playback of http://www.gbbsoft.pl/!download/!/Film1.mp4 > Ref. VLC issue https://code.videolan.org/videolan/vlc/-/issues/26738 > > Signed-off-by: Steve Lhomme > --- > libavcodec/dxva2_hevc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/dxva2_hevc.c b/libavcodec/dxva2_hevc.c > index c91bcf3eeb..6b239d9917 100644 > --- a/libavcodec/dxva2_hevc.c > +++ b/libavcodec/dxva2_hevc.c > @@ -184,7 +184,7 @@ static void fill_picture_parameters(const AVCodecContext *avctx, AVDXVAContext * > const HEVCFrame *frame = NULL; \ > while (!frame && j < rpl->nb_refs) \ > frame = rpl->ref[j++]; \ > - if (frame) \ > + if (frame && frame->flags & (HEVC_FRAME_FLAG_LONG_REF | HEVC_FRAME_FLAG_SHORT_REF)) \ > pp->ref_list[i] = get_refpic_index(pp, ff_dxva2_get_surface_index(avctx, ctx, frame->frame)); \ > else \ > pp->ref_list[i] = 0xff; \ > -- > 2.29.2 > LGTM _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".