From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4F5CC4035F for ; Sat, 22 Jan 2022 09:00:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2E42768B083; Sat, 22 Jan 2022 11:00:48 +0200 (EET) Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4352468AFFD for ; Sat, 22 Jan 2022 11:00:41 +0200 (EET) Received: by mail-yb1-f169.google.com with SMTP id g81so34584783ybg.10 for ; Sat, 22 Jan 2022 01:00:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=xYwqLSzPZfyH3kuuA6MC2I7SrM8dGyhEoLJ9oSiLf6I=; b=YJ79TtVggPhZQi0G9fpPdb0hLz7VUQoVqKGYo/PbCbyesKE6BNbuxUe/NmbPmP30py mRN7or4cR1IzsBi61f96V89gcK5YZoS8OPOwTzQ5FE+gEtT9E5XSOItBBUcsMpV9S3H3 bFghFllm3FbfqgOcc7vXTjMkh+JYZ3QA4cXXJuGohmtD/6mRygRyfMQHA7yZgIsvNJEg lUQOciMWQ7qoPbcQZP7XYFdgv058SLEW0lXzgMExSB4Odn60BlTJBzcwTx0hr6fr2s03 mxsnFaNXrCMgBsKxt5H0s3P75uyCcSps0g1jZelFy92GefkQVvg9T0fLDUdZ6nSiUlxd KV/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=xYwqLSzPZfyH3kuuA6MC2I7SrM8dGyhEoLJ9oSiLf6I=; b=wtXQuwT0/R4p+LYmCuNyV6NEobF7WVexmglTg0lOoYZWClpxV3ZeNByEmG9CJD88wx K6vkKekSCUqz7Rog3+xI3cNIPOPWoF0g1nxKDFv7M0+rCppqO4Ua8L7DF51vteQ1L2se VG0ZEHvimqjyNzdJkxSaZlUOUs65MBT7FaYVhE0Mvfnt6pbwI06Wp2VogYGlwtkNvSQI 8Iy0ImvAdBLhbsMaGNVnuwCR34Hx94JBnShfOep2/vlVQAjmTYmjBP8GNSqvlzwLXCH3 YICi1vZspXTPLLmQG9dED4FGaaikM7TURU01j3fQVEtg5KknwjabHSNB5YyKwW9dbTt+ n3jw== X-Gm-Message-State: AOAM531QKnwNx4JnQljFCVlb8UkH5VCTGinwE/wYGqrxsX3KlhdhqwNM HTyqF5aEFcmXsPhiwd9dSYSnBD+G3wmpcKEFLWciER1o X-Google-Smtp-Source: ABdhPJxr1oFbtrZXGnvr3+jti21OWEIdpbPFjtgJSZGszaT4us+AcgMXfGr8mWw9XZBffnWZUbTfL20fRlLyAbKmFyk= X-Received: by 2002:a25:5f0f:: with SMTP id t15mr10945393ybb.338.1642842039433; Sat, 22 Jan 2022 01:00:39 -0800 (PST) MIME-Version: 1.0 References: <3335e1d2-14ee-8e3c-2e81-a6a077f7ee47@gmail.com> <20220119134846.19557-1-anton@khirnov.net> In-Reply-To: From: Hendrik Leppkes Date: Sat, 22 Jan 2022 10:00:28 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] configure: link to libatomic when it's present X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, Jan 22, 2022 at 7:43 AM Brad Smith wrote: > > On 1/19/2022 10:23 AM, James Almer wrote: > > > On 1/19/2022 10:48 AM, Anton Khirnov wrote: > >> C11 atomics in some configurations (e.g. 64bit operations on ppc64 with > >> GCC) require linking to libatomic. > >> > >> Fixes #9275 > >> --- > >> configure | 25 ++++++++++++++++--------- > >> 1 file changed, 16 insertions(+), 9 deletions(-) > >> > >> diff --git a/configure b/configure > >> index 1413122d87..3059c154df 100755 > >> --- a/configure > >> +++ b/configure > >> @@ -3794,20 +3794,20 @@ cws2fws_extralibs="zlib_extralibs" > >> # libraries, in any order > >> avcodec_deps="avutil" > >> -avcodec_suggest="libm" > >> +avcodec_suggest="libm stdatomic" > >> avdevice_deps="avformat avcodec avutil" > >> -avdevice_suggest="libm" > >> +avdevice_suggest="libm stdatomic" > >> avfilter_deps="avutil" > >> -avfilter_suggest="libm" > >> +avfilter_suggest="libm stdatomic" > >> avformat_deps="avcodec avutil" > >> -avformat_suggest="libm network zlib" > >> -avutil_suggest="clock_gettime ffnvcodec libm libdrm libmfx opencl > >> user32 vaapi vulkan videotoolbox corefoundation corevideo coremedia > >> bcrypt" > >> +avformat_suggest="libm network zlib stdatomic" > >> +avutil_suggest="clock_gettime ffnvcodec libm libdrm libmfx opencl > >> user32 vaapi vulkan videotoolbox corefoundation corevideo coremedia > >> bcrypt stdatomic" > >> postproc_deps="avutil gpl" > >> -postproc_suggest="libm" > >> +postproc_suggest="libm stdatomic" > >> swresample_deps="avutil" > >> -swresample_suggest="libm libsoxr" > >> +swresample_suggest="libm libsoxr stdatomic" > >> swscale_deps="avutil" > >> -swscale_suggest="libm" > >> +swscale_suggest="libm stdatomic" > >> avcodec_extralibs="pthreads_extralibs iconv_extralibs > >> dxva2_extralibs" > >> avfilter_extralibs="pthreads_extralibs" > >> @@ -6324,7 +6324,14 @@ check_headers asm/types.h > >> # it seems there are versions of clang in some distros that try to > >> use the > >> # gcc headers, which explodes for stdatomic > >> # so we also check that atomics actually work here > >> -check_builtin stdatomic stdatomic.h "atomic_int foo, bar = > >> ATOMIC_VAR_INIT(-1); atomic_store(&foo, 0); foo += bar" > >> +# > >> +# some configurations also require linking to libatomic, so try > >> +# both with -latomic and without > >> +for LATOMIC in "-latomic" ""; do > >> + check_builtin stdatomic > >> stdatomic.h \ > >> + "atomic_int foo, bar = ATOMIC_VAR_INIT(-1); > >> atomic_store(&foo, 0); foo += bar" \ > >> + $LATOMIC && eval stdatomic_extralibs="\$LATOMIC" && break > >> +done > > > > LGTM now, thanks. > > > >> check_lib advapi32 "windows.h" RegCloseKey > >> -ladvapi32 > >> check_lib bcrypt "windows.h bcrypt.h" BCryptGenRandom -lbcrypt && > > Wait, this should be checking without first then with, if the first test > without fails. > This was covered earlier in the thread for the reason it is not - its deliberate, because exhaustive functionality checks would be very complicated. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".