From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E3D09427D5 for ; Fri, 7 Jan 2022 10:20:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D341868A3D3; Fri, 7 Jan 2022 12:20:41 +0200 (EET) Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A637868A3D3 for ; Fri, 7 Jan 2022 12:20:35 +0200 (EET) Received: by mail-yb1-f176.google.com with SMTP id m6so5105430ybc.9 for ; Fri, 07 Jan 2022 02:20:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=5d45UjR2F15AyrBdcEYBEE5lqRF94FpHmsaHhXk5JR0=; b=Tnb0YUaxKvycRKLvUlnxhCcUqBRHy1HMEBrkCKO0F9dXWP54qkC5kXeyavAe2J3mFv rKx2LY2o+0KignVgHegrgm9mbAJFdNBOs1im/nrOFRawFCGjY7TueTm9RyVazknBwakK cXh8xNdJxrq4iAURza/vvCDLgADMc8t0rtKJA6sBO9w6Q2rqp4eaSehI5bMbecS7PDU9 AlXDG7sZPxuRwoFYMZXQVVrxK326LxSRGZ2MFZy9Vp0Rsw/BlwdDCmFS4Cs3OZ5C3QS1 zS45qCBdIQ38lY8422brSDm+EM78N01iNtL2FRh+FSqwqPol4h3/OSoV+Pr3eooiSjSK nS2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=5d45UjR2F15AyrBdcEYBEE5lqRF94FpHmsaHhXk5JR0=; b=uRmUqJ4HR0bs3+a1zQbnTx1qP2SxJwmksddmTnJVE35msnY3aFoju+v3eYV4BqIu2P eCIMY0V9AZL15C1W78seuMcmi1AVlSunbEv/HD+OrSgXyB4JYPE1pnFj5pTR12bPXqKH JbI1290KL/7OGwZrwReW03CZC5mM9g0590fho+/mLOcRIZzict724GSMKCdYGZc1zdAG Ku25C6n3o99pzv7a9VK3FKnsyJSZWM8OEtbOVdwbDjemkFS/KSBTlRUumK9OP9fxe7im 221YUagYkJUdp+twq6sngF75rcwA22dayxrKf6OEKCPj1p2bOdQr4jkoV1+hnHw7fhk5 yb8g== X-Gm-Message-State: AOAM5333qmJugtd6JFT+mcBTqgg2Dc5fVxLVCqNTZTQm4FPL6raUnwvX XfQcm5rvfffyEfs3+gU43ndsYG7zK0UVaTgzpUoJrFdZ X-Google-Smtp-Source: ABdhPJzi8U1sZkA5F2tCoFUyWFIHawO4qT6Ibly1oht+jRykSPAsYGUFAdkYfFwpzqzsTcjm43iKSjnvx3VFho9xDyU= X-Received: by 2002:a05:6902:110d:: with SMTP id o13mr88256148ybu.715.1641550833700; Fri, 07 Jan 2022 02:20:33 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Hendrik Leppkes Date: Fri, 7 Jan 2022 11:20:22 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't dump images to disk based on DEBUG define X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, Jan 7, 2022 at 5:50 AM ffmpegagent wrote: > > It's annoying and unexpected, but still useful at times (as I've realized > just recently). > > This is a follow-up to the earlier submission here: > https://www.mail-archive.com/ffmpeg-devel@ffmpeg.org/msg128080.html > > There has been a comment from Anton, questioning whether the dump-feature is > useful. Meanwhile I came to the conclusion that it can be useful in-fact. It > just shouldn't happen automatically when DEBUG is defined. That's what these > patches do. > > I also added fixes for the fopen() call. > > softworkz (4): > avcodec/dvbsubdec: don't dump images to disk based on DEBUG define > avcodec/dvbsubdec: fix writing ppm > avcodec/dvdsubdec: don't dump images to disk based on DEBUG define > avcodec/dvdsubdec: fix writing ppm > > libavcodec/dvbsubdec.c | 20 +++++++++++++------- > libavcodec/dvdsubdec.c | 11 ++++++++--- > 2 files changed, 21 insertions(+), 10 deletions(-) > > These patches need some squasing. It should've been obvious from them being duplicated. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".