Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Hendrik Leppkes <h.leppkes@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness
Date: Thu, 28 Mar 2024 10:43:04 +0100
Message-ID: <CA+anqdxEHP-AxYaGRVJKDUFEpVSWSNJVNfpyb_ak_aLpnBNFGg@mail.gmail.com> (raw)
In-Reply-To: <20240328091134.388-1-tong1.wu@intel.com>

On Thu, Mar 28, 2024 at 10:12 AM <tong1.wu-at-intel.com@ffmpeg.org> wrote:
>
> From: Tong Wu <tong1.wu@intel.com>
>
> HEVCHdrParams* receives a pointer which points to a dynamically
> allocated memory block. It causes the memcmp always returning 1.
> Add a function to do the comparision. A condition is also added to
> avoid malloc(0).
>
> Signed-off-by: Tong Wu <tong1.wu@intel.com>

I've been looking into some playback glitches after
456c8ebe7c7dcd766d36cd0296815d89fd1166b5 and I can confirm that this
patch fixes those as well.

Using the fixed position of the *hdr member and its offset seems a bit
icky though, and _at least_ could use a comment so future changes keep
it last.

- Hendrik
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-03-28  9:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28  9:11 tong1.wu-at-intel.com
2024-03-28  9:43 ` Hendrik Leppkes [this message]
2024-03-28 13:18   ` Wu, Tong1
2024-03-28 13:15 tong1.wu-at-intel.com
2024-03-29 12:45 ` James Almer
2024-03-29 15:15   ` Wu, Tong1
2024-03-29 13:10 ` Mark Thompson
2024-03-29 13:29   ` James Almer
2024-03-29 14:00     ` Andreas Rheinhardt
2024-03-29 15:55       ` Mark Thompson
2024-03-29 15:58         ` Andreas Rheinhardt
2024-03-29 16:33           ` Mark Thompson
2024-04-03  8:56           ` Anton Khirnov
2024-03-29 14:02   ` Andreas Rheinhardt
2024-03-29 14:49     ` Wu, Tong1

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+anqdxEHP-AxYaGRVJKDUFEpVSWSNJVNfpyb_ak_aLpnBNFGg@mail.gmail.com \
    --to=h.leppkes@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git