From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F1C5F430D9 for ; Fri, 20 May 2022 16:35:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AB7F268B498; Fri, 20 May 2022 19:35:06 +0300 (EEST) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9583168A8E7 for ; Fri, 20 May 2022 19:35:00 +0300 (EEST) Received: by mail-lj1-f173.google.com with SMTP id e4so9694072ljb.13 for ; Fri, 20 May 2022 09:35:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=iJPkaZMJX9bDaTG/Hni3dUbf8GKEV8VDa9xsapS7II4=; b=po5xeT6hJFyojQce3u6KPyxjoyRfU3sIjHkzWOtEyxwCNqUXIXm075SfeF9OXCwDz+ mMrwZQSLM3eEwYct6zYKtxwxZbnMK6sCtoRS6oq5zGzClVHHmf6e5VmTDPx+7VJy5Erd kuVU9x+rvatNaxsSbK0FNus/4vHLbdAcI4Qw7d9h15gy6590X4QMtMgjl1fgvIT3Mo75 kz7A3l0BAaqlzkn91zXMRV+WNKE3OKkQL5hhMWxuDbPaDnU2oRne+HnxXy75W+H2JkXL r7IroskjOGMG2c+phVuuK8S82vox5VEaiE3i626Od9AHQIHpQs1GoxXM6Fic9D/wyfDW DcaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=iJPkaZMJX9bDaTG/Hni3dUbf8GKEV8VDa9xsapS7II4=; b=tEi1VxNLYu4vnAGmIPwmlftpm6m0pcnSYK3MXzSOz/ESSY+FmA0Pkil3jAVCzsevcH 209BSEn/LvGZbfBxanvQTbSkjWzyvJ0gwdW/w4HLwPwdWZEG0erCAgTOtdKnaLxGtagb KFmaXRWOwJyPzgf346KBEgAVu9bq5aXd1QchQcTmjRx51Hrxq7UFY6CO9Dr7iG05FJ9m CQq+COedV2mmwdJLe3mis6OuLW8iBeO7fHpNWnzW2o1pMxq1ndhFZulHuIJWBX9SDpGT jhqSjxeLZO8slEGNcRbSsfDcNBMTijGNykKZi+7RcSVA89YbLjGUv2rJjeY3vaisrT15 BfJg== X-Gm-Message-State: AOAM530pt9i0MVxJmNImelQhxx9I6WDyJyagOKOA4eOPdIDT+0lARQgx Hrhlp8hnZ9yB3UBbv3bF0zT/8Gv/V+qyGHonIjmf/QI1 X-Google-Smtp-Source: ABdhPJyUT2chjCvbS9MhEr0owXO5BZ6T7MvaedgAc5ZJZtJ6bi4JcjsmGJS+kTctEHpYSvyUB/GtcLAdoihNm/aJS3s= X-Received: by 2002:a2e:9bd3:0:b0:253:d95f:caf2 with SMTP id w19-20020a2e9bd3000000b00253d95fcaf2mr4137967ljj.252.1653064499612; Fri, 20 May 2022 09:34:59 -0700 (PDT) MIME-Version: 1.0 References: <6aa08dec-4d80-298b-7d98-11a88e74bcff@gmail.com> In-Reply-To: <6aa08dec-4d80-298b-7d98-11a88e74bcff@gmail.com> From: Hendrik Leppkes Date: Fri, 20 May 2022 18:34:48 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/libx264: allow to disable definition of X264_API_IMPORTS macro X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, May 20, 2022 at 6:23 PM Derek Buitenhuis wrote: > > On 5/20/2022 4:23 PM, softworkz wrote: > > A better fix would eventually be this one: > > http://ffmpeg.org/pipermail/ffmpeg-devel/2021-October/287426.html > > > > But there has been disagreement and the issue stalled. > > I did not see a single person disagree with Matt's patch? If someone did, > I missed it. > Me neither, it just didn't seem to get any feedback and was overlooked. Using pkg-config and letting CFLAGS control this through the appropriate define x264 itself created for it is the far better solution then inventing your own that noone knows about (soon we have one for every library then, where does it end?). - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".