From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 077B142806 for ; Fri, 7 Jan 2022 16:14:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AABC768A295; Fri, 7 Jan 2022 18:14:23 +0200 (EET) Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B787068A6F6 for ; Fri, 7 Jan 2022 18:14:17 +0200 (EET) Received: by mail-yb1-f181.google.com with SMTP id p15so18013368ybk.10 for ; Fri, 07 Jan 2022 08:14:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=TaCvxIA40UzDY2GBnNQK65eEokfgE6TxtDjnO46HXbA=; b=OxrXpx1jQRnxhYemnrOv6+g4WcJvpBt4OxYEqO1KC7fSX3V4lTAks1Y0CB1ZKRNHcK OU9d4SqZBjzMBtkDvyqfcrZqystFe/iLd+MbuQpc+FA0ByBuW+Fd1Skiew79fDWAtUai BVjwcpiRijxy4YDaM8Tqgs+zo5mpNToyx51IIDtMuIS3aLTgL4whG/0BV5P5NOADyELM aIAAeTjl+FuPL5iE8GWPIxOigPEsv1nplkpztaR/0cfKiAKNwld8uEOGHv1BhwKOL2d1 OvfETdIJgPAlDG0euE9Q/3cknk2rIflKRfGvMTYYBy16USo5YzJK07iA2YZRUUU1UYWT aLow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=TaCvxIA40UzDY2GBnNQK65eEokfgE6TxtDjnO46HXbA=; b=iAsJLwI4k4d5+G7K6T7wL+IIOQ+ZlVAms+ltaove7cBM834Ii+zURfQEypimEdwVuJ 05V+f5EdBJ6DswMI+jDTMO7hSbt8rzI1pqZns/I00AS9uplSU/61r2EQjvsjYxnGb63R 5EUv2/tdUoHWKziI8Aor5o55oykR4cHgfjZktzqxPa+/s2rL6KV2HE7L7lJ5/u0E54ip pMNy4XPdbIcqGlEBCzvtW0mHnDac/BQJJOOS0OZtBKmRR4it9ZAq5LERTMSIzu0lTyz/ D/XMD7FGQdiXCIjoA9lwIKlhE4BnK4xB5/aazjb9BmqCmpXuiZuZBvr0h19UnNOYWyP/ /08A== X-Gm-Message-State: AOAM5306fsjP5fmMVkwpLvnIsifwlqF9lYOOYMKSiHHvtCEtYSPBbXqk EV7NXci3cqyAeIMWX4Zovs0Qz49dVoCBCncSYnN3a/Mb X-Google-Smtp-Source: ABdhPJxrjhiBGJxEwZKqCXyPlVakGycwTPAzQECLr51oSv1FkYdY9SHGGEz2XXHSQW4a8XP1/GhCVniO1OKBGV1a3To= X-Received: by 2002:a05:6902:154b:: with SMTP id r11mr44745813ybu.157.1641572056153; Fri, 07 Jan 2022 08:14:16 -0800 (PST) MIME-Version: 1.0 References: <20220107142134.821-1-jamrial@gmail.com> <20220107142134.821-2-jamrial@gmail.com> In-Reply-To: <20220107142134.821-2-jamrial@gmail.com> From: Hendrik Leppkes Date: Fri, 7 Jan 2022 17:14:04 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/libdav1d: honor the requested skip_frame level X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, Jan 7, 2022 at 3:22 PM James Almer wrote: > > This supports dropping non-intra, non-key, or all frames. > > Signed-off-by: James Almer > --- > libavcodec/libdav1d.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c > index 8e45f533cb..9252a2572d 100644 > --- a/libavcodec/libdav1d.c > +++ b/libavcodec/libdav1d.c > @@ -299,6 +299,7 @@ static int libdav1d_receive_frame(AVCodecContext *c, AVFrame *frame) > #endif > int res; > > +redo: > if (!data->sz) { > AVPacket *const pkt = dav1d->pkt; > > @@ -363,6 +364,14 @@ static int libdav1d_receive_frame(AVCodecContext *c, AVFrame *frame) > > av_assert0(p->data[0] && p->allocator_data); > > + if ((c->skip_frame >= AVDISCARD_NONINTRA && (p->frame_hdr->frame_type != DAV1D_FRAME_TYPE_KEY && > + p->frame_hdr->frame_type != DAV1D_FRAME_TYPE_INTRA)) || > + (c->skip_frame >= AVDISCARD_NONKEY && p->frame_hdr->frame_type != DAV1D_FRAME_TYPE_KEY) || > + c->skip_frame >= AVDISCARD_ALL) { > + dav1d_picture_unref(p); > + goto redo; > + } Is skipping still meaningful if it doesn't actually speed up decoding? - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".