From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2108845666 for <ffmpegdev@gitmailbox.com>; Thu, 9 Feb 2023 20:12:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1938868BE51; Thu, 9 Feb 2023 22:12:37 +0200 (EET) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C654D6802C8 for <ffmpeg-devel@ffmpeg.org>; Thu, 9 Feb 2023 22:12:30 +0200 (EET) Received: by mail-lf1-f45.google.com with SMTP id h24so4793704lfv.6 for <ffmpeg-devel@ffmpeg.org>; Thu, 09 Feb 2023 12:12:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=N+ySJ0MwbdIPw7iBMjTES+z+oDjIA8FalNW8MLbbjxQ=; b=Oq3bKKLxM5tlhJ4uvn6yq+Py/XROAuzkXkjzmKrmJyM4aap4HMv9a9708SB2viMlNv OkL7Gpz5dn/83KiyoNNG+3ipiB/mlq05/tMm8e+JD+xWQprXREU1JudiI3F6F7Bk4eXJ jAE8kJijyrCfrcAAkNspH2QNWyau7kavQb4qqd0oBsWqLFg52q5qRsre0QRZn4iYZom/ LsJqbFOa9NpnumVkJi8qgjDO3nGHITj0WkLlfv7UMfL5ilmU7IryQtPucOWRyc/0QI4g JcQWDQqCK3JQ7+B2wWR8vZ9tDC3cOiqykHE7tDpkah1nUydFAFRdEjfUp6BQdXEAnUhq 5+PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N+ySJ0MwbdIPw7iBMjTES+z+oDjIA8FalNW8MLbbjxQ=; b=4WwToByNmfazLkk1vFwil8M7sbsT7TvttX1ifvegStPcjtyzteU6yngy47kMYQxbhL 3UjNJPmUjsHjnZ+ceC8H4L7mw9+fziXp/Miy5iN3Shf3IxccjXJVh3y2UCwv6lraVZ3a Xsl6IJsnhozYlVJ8s8Rh9F0uZjKMRYfbPInM7FagU5GaXS7+IZYvcsoXN5TkbWDvd+1V gJCfBZO+vLLEMcBcIwtejm8pk4Vk2a/OGWOCTSchq17o0oKYXlcldM6oMS2Hm9JAiT3F XbkyhoOJnh8jxySSDR0qBk0DwAaWAydF4SFLsAxyuMedRj8riraX/wxN5p+jhBaZIPkI R9HQ== X-Gm-Message-State: AO0yUKVesRLUqrvQ05KlJfwFkeD6bWhO/MnYhnYE60rU5E+xb2hJriW+ RLkvcBnfyCYgGa9cNaVW1WNjtINqLiKoRMPTEhqrgxn+AU0= X-Google-Smtp-Source: AK7set8Fliz4lRjlyAOpdQ+DpxZUcMaKiVc4GdgN+ClC2S2iJug8TQ96gdQYaN9Z7iKkNrKWGEKWvG19j0c5s2Y7AEo= X-Received: by 2002:a19:ad01:0:b0:4a2:c057:33cc with SMTP id t1-20020a19ad01000000b004a2c05733ccmr2216884lfc.212.1675973549150; Thu, 09 Feb 2023 12:12:29 -0800 (PST) MIME-Version: 1.0 References: <20230209044058.2872534-1-marth64@proxyid.net> In-Reply-To: <20230209044058.2872534-1-marth64@proxyid.net> From: Hendrik Leppkes <h.leppkes@gmail.com> Date: Thu, 9 Feb 2023 21:12:14 +0100 Message-ID: <CA+anqdwi3sAuexMEh_6pC+hzp4ih50GZnFiA_xXqbgh7piYH7w@mail.gmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/CA+anqdwi3sAuexMEh_6pC+hzp4ih50GZnFiA_xXqbgh7piYH7w@mail.gmail.com/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> On Thu, Feb 9, 2023 at 5:42 AM Marth64 <marth64@proxyid.net> wrote: > > Signed-off-by: Marth64 <marth64@proxyid.net> > --- > Adds detection of spatial/object-based audio extensions in E-AC-3, > TrueHD, and DCA XLL (DTS). This includes Atmos, DTS:X, and IMAX formats. > Please let me know what I could improve, I'm learning still. > Thank you. > The detection itself seems fine to me, however we should talk about how the presence is communicated back to the user. A new flag in AVCodecContext goes against a variety of designs we try to avoid - namely having codec-specific things in a global struct, as well as having only one value, rather then per-frame values. So options that present themself to me: (a) Use "profile". At least for DTS that would fit quite nicely, as it already has profiles, and it seems like a logical extension. TrueHD and eac3 do not have profiles, but it might still be sensible to put it there. The advantage here is that it also automatically is conveyed in AVCodecParameters after avformat opens a stream, so the information is available early and lets players decide how to handle the stream. (b) Use per-frame side data. The early-availability advantage is not present here, so its not my favorite. side-data could be used in the future to transport the actual object metadata, if needed. So from where I'm standing we should maybe define profiles to use for these. In the past profiles were at least suggested for TrueHD Atmos before, but there were some objections, so maybe a good time to revisit and see where we go from here. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".