From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CD640433BA for ; Sat, 9 Jul 2022 20:49:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9F5D568B95F; Sat, 9 Jul 2022 23:49:42 +0300 (EEST) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4CF4168B804 for ; Sat, 9 Jul 2022 23:49:36 +0300 (EEST) Received: by mail-lj1-f174.google.com with SMTP id w17so583374ljh.6 for ; Sat, 09 Jul 2022 13:49:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=kMzvefL/jl32oaUDRmJpTDnq4ZefAqrrYbOumBd1rs4=; b=ar9+AeUXIS9/CcgrO6h+UE53kw58GJhHgoTN5HdqH+wb0PbOHPoviaXTkyFf2IUiKJ IqgcUgh0RZ0GHAQ6ZpPA5Gjv9z73BVpthnqI3KsUedgfpC9SuscDC78haIn2BfpGrSHU 1bRbCY2rB0dv+U1K0BEx2TOP4vCeBPhOweoxgQ2J29lC56jxIyacdEzPIbTGC71D2TG9 OvCg90DQGJJl+Rxn1b/yR4RT+WBWx9KX04d1phAnVeYpF747dI+cjaEXhHbs7i55eGnC 4ZuAuGgjR6CgvS26F78aDTckzstJzSsSdPLg4GhvjAvUJnARj2gt6ZMFfKx+R/Tv8u11 raTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=kMzvefL/jl32oaUDRmJpTDnq4ZefAqrrYbOumBd1rs4=; b=EVhzVRjVl+HxG2OxitSOAykIUm7FcmtrI1nMwSilQl0bDhic2ZVbeA2hqPp7GDZSH5 /vEBCe/WWP9tcX+xQsXzHrqTY5AghDV+zon+79B/MgWjLUYPzGV0RoD7GLOjXKiacaow TMUtMNhuAHjMwmBiXSXbvyDyREku1lGNNFLwDtzTzHZlLcPcPVtnd8VcSuxiur7YNY8s WhY+226EIaLrJ0bf6lnvPgxR1au030jFcez6FJpbyFgFCH8zKhCpBLjFALoEHCuP6rr1 wM0DG13MbZQhjlF+zLIe25A+0gWODkQ3yvutvpfsCoPHorNlh9O8I6fJP/WxXyCTkgkZ 7AaA== X-Gm-Message-State: AJIora9rGXNIvLNquwnxoAR8Aj3Wq66twCMB7P0Rsn8WZjWUs/LmVYuH 81PgcznDr9mxDKZ1XkSJr6Ybsf0cg88RyBarcVpW4g9N X-Google-Smtp-Source: AGRyM1tCCm9p3EHWEJnYgc9jM5Utke/UoH0jfC4+KWxUA0jHj1Nb2yjnKBAVYk/47gv6NjAjvaoDH4ktG1AblWtTXwc= X-Received: by 2002:a2e:a7c7:0:b0:25b:b72d:aa3c with SMTP id x7-20020a2ea7c7000000b0025bb72daa3cmr5750508ljp.318.1657399774508; Sat, 09 Jul 2022 13:49:34 -0700 (PDT) MIME-Version: 1.0 References: <20220704162912.5577-1-ffmpeg@gyani.pro> <165718689777.31466.279724099132649515@lain.khirnov.net> <4695e134-a83f-fdb3-3c04-ed3b724a82c9@gyani.pro> In-Reply-To: From: Hendrik Leppkes Date: Sat, 9 Jul 2022 22:49:20 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v3] ffmpeg: add option -isync X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, Jul 9, 2022 at 9:56 PM Gyan Doshi wrote: > > > > On 2022-07-10 01:13 am, Paul B Mahol wrote: > > On Sat, Jul 9, 2022 at 8:28 PM Gyan Doshi wrote: > > > >> > >> On 2022-07-08 09:26 am, Gyan Doshi wrote: > >>> > >>> On 2022-07-07 03:11 pm, Anton Khirnov wrote: > >>>> Quoting Gyan Doshi (2022-07-04 18:29:12) > >>>>> This is a per-file input option that adjusts an input's timestamps > >>>>> with reference to another input, so that emitted packet timestamps > >>>>> account for the difference between the start times of the two inputs. > >>>>> > >>>>> Typical use case is to sync two or more live inputs such as from > >>>>> capture > >>>>> devices. Both the target and reference input source timestamps > >>>>> should be > >>>>> based on the same clock source. > >>>>> > >>>>> If not all inputs have timestamps, the wallclock times at the time of > >>>>> reception of inputs shall be used. FFmpeg must have been compiled with > >>>>> thread support for this last case. > >>>> I'm wondering if simply using the other input's InputFile.ts_offset > >>>> wouldn't achieve the same effect with much less complexity. > >>> That's what I initially did. But since the code can also use two other > >>> sources for start times (start_time_realtime, first_pkt_wallclock), > >>> those intervals may not exactly match the difference between > >>> fmctx->start_times so I use a generic calculation. > >> Plan to push on Monday, if no further changes. 5.1 is to be cut soon. > >> > >> > > Why big rush, its not so critical. > > Patch was first sent on 22nd June. Only one reviewer asked for changes. > It does however not seem like that reviewer has ultimately signed off, did he? Lack of response for a day does not make previous objections just go away. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".