* [FFmpeg-devel] [PATCH]configure: Assume target-os=win32 for toolchain msvc
@ 2022-11-27 17:05 Carl Eugen Hoyos
2022-11-27 17:16 ` Hendrik Leppkes
0 siblings, 1 reply; 8+ messages in thread
From: Carl Eugen Hoyos @ 2022-11-27 17:05 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1: Type: text/plain, Size: 88 bytes --]
Hi!
Attached patch slightly simplifies building with MSVC.
Please comment, Carl Eugen
[-- Attachment #2: 0001-configure-Assume-host-os-win32-for-toolchain-msvc.patch --]
[-- Type: application/octet-stream, Size: 709 bytes --]
[-- Attachment #3: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [FFmpeg-devel] [PATCH]configure: Assume target-os=win32 for toolchain msvc
2022-11-27 17:05 [FFmpeg-devel] [PATCH]configure: Assume target-os=win32 for toolchain msvc Carl Eugen Hoyos
@ 2022-11-27 17:16 ` Hendrik Leppkes
2022-11-27 17:42 ` Carl Eugen Hoyos
0 siblings, 1 reply; 8+ messages in thread
From: Hendrik Leppkes @ 2022-11-27 17:16 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Sun, Nov 27, 2022 at 6:13 PM Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
>
> Hi!
>
> Attached patch slightly simplifies building with MSVC.
>
> Please comment, Carl Eugen
I don't think any toolchain value should make assumptions about the
host it is running on, because between WSL and Wine, you can certainly
do a bunch of specific things where this is not true.
- Hendrik
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [FFmpeg-devel] [PATCH]configure: Assume target-os=win32 for toolchain msvc
2022-11-27 17:16 ` Hendrik Leppkes
@ 2022-11-27 17:42 ` Carl Eugen Hoyos
2022-12-13 19:00 ` Carl Eugen Hoyos
0 siblings, 1 reply; 8+ messages in thread
From: Carl Eugen Hoyos @ 2022-11-27 17:42 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Am So., 27. Nov. 2022 um 18:16 Uhr schrieb Hendrik Leppkes
<h.leppkes@gmail.com>:
>
> On Sun, Nov 27, 2022 at 6:13 PM Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
> >
> > Hi!
> >
> > Attached patch slightly simplifies building with MSVC.
> >
> > Please comment, Carl Eugen
>
> I don't think any toolchain value should make assumptions about the
> host it is running on, because between WSL and Wine, you can certainly
> do a bunch of specific things where this is not true.
If this is true, then my patch is of course incorrect.
But could you give an example?
I was under the impression that cl.exe can only run
in win32.
Thank you, Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [FFmpeg-devel] [PATCH]configure: Assume target-os=win32 for toolchain msvc
2022-11-27 17:42 ` Carl Eugen Hoyos
@ 2022-12-13 19:00 ` Carl Eugen Hoyos
2022-12-13 19:21 ` Hendrik Leppkes
2022-12-13 23:43 ` Timo Rothenpieler
0 siblings, 2 replies; 8+ messages in thread
From: Carl Eugen Hoyos @ 2022-12-13 19:00 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Am So., 27. Nov. 2022 um 18:42 Uhr schrieb Carl Eugen Hoyos
<ceffmpeg@gmail.com>:
>
> Am So., 27. Nov. 2022 um 18:16 Uhr schrieb Hendrik Leppkes
> <h.leppkes@gmail.com>:
> >
> > On Sun, Nov 27, 2022 at 6:13 PM Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
> > >
> > > Hi!
> > >
> > > Attached patch slightly simplifies building with MSVC.
> > >
> > > Please comment, Carl Eugen
> >
> > I don't think any toolchain value should make assumptions about the
> > host it is running on, because between WSL and Wine, you can certainly
> > do a bunch of specific things where this is not true.
>
> If this is true, then my patch is of course incorrect.
> But could you give an example?
> I was under the impression that cl.exe can only run
> in win32.
Ping.
Could you give an example where host-os is not win32 when
compiling with msvc?
Thank you, Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [FFmpeg-devel] [PATCH]configure: Assume target-os=win32 for toolchain msvc
2022-12-13 19:00 ` Carl Eugen Hoyos
@ 2022-12-13 19:21 ` Hendrik Leppkes
2022-12-13 21:51 ` Carl Eugen Hoyos
2022-12-13 23:43 ` Timo Rothenpieler
1 sibling, 1 reply; 8+ messages in thread
From: Hendrik Leppkes @ 2022-12-13 19:21 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Tue, Dec 13, 2022 at 8:02 PM Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
>
> Am So., 27. Nov. 2022 um 18:42 Uhr schrieb Carl Eugen Hoyos
> <ceffmpeg@gmail.com>:
> >
> > Am So., 27. Nov. 2022 um 18:16 Uhr schrieb Hendrik Leppkes
> > <h.leppkes@gmail.com>:
> > >
> > > On Sun, Nov 27, 2022 at 6:13 PM Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
> > > >
> > > > Hi!
> > > >
> > > > Attached patch slightly simplifies building with MSVC.
> > > >
> > > > Please comment, Carl Eugen
> > >
> > > I don't think any toolchain value should make assumptions about the
> > > host it is running on, because between WSL and Wine, you can certainly
> > > do a bunch of specific things where this is not true.
> >
> > If this is true, then my patch is of course incorrect.
> > But could you give an example?
> > I was under the impression that cl.exe can only run
> > in win32.
>
> Ping.
> Could you give an example where host-os is not win32 when
> compiling with msvc?
>
When using wine, your host is linux.
- Hendrik
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [FFmpeg-devel] [PATCH]configure: Assume target-os=win32 for toolchain msvc
2022-12-13 19:21 ` Hendrik Leppkes
@ 2022-12-13 21:51 ` Carl Eugen Hoyos
0 siblings, 0 replies; 8+ messages in thread
From: Carl Eugen Hoyos @ 2022-12-13 21:51 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Am Di., 13. Dez. 2022 um 20:21 Uhr schrieb Hendrik Leppkes
<h.leppkes@gmail.com>:
>
> On Tue, Dec 13, 2022 at 8:02 PM Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
> >
> > Am So., 27. Nov. 2022 um 18:42 Uhr schrieb Carl Eugen Hoyos
> > <ceffmpeg@gmail.com>:
> > >
> > > Am So., 27. Nov. 2022 um 18:16 Uhr schrieb Hendrik Leppkes
> > > <h.leppkes@gmail.com>:
> > > >
> > > > On Sun, Nov 27, 2022 at 6:13 PM Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
> > > > >
> > > > > Hi!
> > > > >
> > > > > Attached patch slightly simplifies building with MSVC.
> > > > >
> > > > > Please comment, Carl Eugen
> > > >
> > > > I don't think any toolchain value should make assumptions about the
> > > > host it is running on, because between WSL and Wine, you can certainly
> > > > do a bunch of specific things where this is not true.
> > >
> > > If this is true, then my patch is of course incorrect.
> > > But could you give an example?
> > > I was under the impression that cl.exe can only run
> > > in win32.
> >
> > Ping.
> > Could you give an example where host-os is not win32 when
> > compiling with msvc?
> >
>
> When using wine, your host is linux.
Understood, thank you!
Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [FFmpeg-devel] [PATCH]configure: Assume target-os=win32 for toolchain msvc
2022-12-13 19:00 ` Carl Eugen Hoyos
2022-12-13 19:21 ` Hendrik Leppkes
@ 2022-12-13 23:43 ` Timo Rothenpieler
2022-12-14 10:55 ` Carl Eugen Hoyos
1 sibling, 1 reply; 8+ messages in thread
From: Timo Rothenpieler @ 2022-12-13 23:43 UTC (permalink / raw)
To: ffmpeg-devel
On 13.12.2022 20:00, Carl Eugen Hoyos wrote:
> Ping.
> Could you give an example where host-os is not win32 when
> compiling with msvc?
WSL, which I quite regularly use to test MSVC builds.
Just need to launch it from inside an msvc shell.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [FFmpeg-devel] [PATCH]configure: Assume target-os=win32 for toolchain msvc
2022-12-13 23:43 ` Timo Rothenpieler
@ 2022-12-14 10:55 ` Carl Eugen Hoyos
0 siblings, 0 replies; 8+ messages in thread
From: Carl Eugen Hoyos @ 2022-12-14 10:55 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Am Mi., 14. Dez. 2022 um 00:43 Uhr schrieb Timo Rothenpieler
<timo@rothenpieler.org>:
>
> On 13.12.2022 20:00, Carl Eugen Hoyos wrote:
> > Ping.
> > Could you give an example where host-os is not win32 when
> > compiling with msvc?
>
> WSL, which I quite regularly use to test MSVC builds.
> Just need to launch it from inside an msvc shell.
This is the bug that my patch is trying to fix:
When you build with msvc in wsl, you are doing a native build on win32.
I want to avoid the "--host-os=win32" for this case.
I had not imagined an msvc build using wine on Linux.
Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-12-14 10:56 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-27 17:05 [FFmpeg-devel] [PATCH]configure: Assume target-os=win32 for toolchain msvc Carl Eugen Hoyos
2022-11-27 17:16 ` Hendrik Leppkes
2022-11-27 17:42 ` Carl Eugen Hoyos
2022-12-13 19:00 ` Carl Eugen Hoyos
2022-12-13 19:21 ` Hendrik Leppkes
2022-12-13 21:51 ` Carl Eugen Hoyos
2022-12-13 23:43 ` Timo Rothenpieler
2022-12-14 10:55 ` Carl Eugen Hoyos
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git