From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 05BFC40FA6 for ; Wed, 13 Apr 2022 14:45:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2BF9368B3AD; Wed, 13 Apr 2022 17:45:57 +0300 (EEST) Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4E69268B313 for ; Wed, 13 Apr 2022 17:45:50 +0300 (EEST) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-2ebf4b91212so24857867b3.8 for ; Wed, 13 Apr 2022 07:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=kx4jKSUrmxJ5qtY6cLo4Qe1ZB6KAnSF/geJmAMf8SM8=; b=LwAxJHWLCY23/+8PiS13h+WH30PyQ7dx/UEnZkzS3M0oWhiBm+AfRad5kBGR0ojAGf sBLR56/pW9XbhBZbCMAo5DpcndHpUJ6yLkX4RCd7QeXxbmMFYmbHfsMO+ksLHr/kP6fD Z27gUP+SdYyohThm4tNqZGoPnqDL6+/O7j2PopqdcZWiszKWJoaHnN8IxmErruMJ2Cta jBJE/7n1vP1V+jaeIyM2ulaLz29T81Z0Sk8GO4D2ikdRITC0iP6lLMxZVyDtlaQtSsSY sfbnFAUwEyTYptLnA7tsyvQCEtQYgxnS+UegBI3073j08d2yzUeJm3+lQ6gRHqvClZ6f O4CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=kx4jKSUrmxJ5qtY6cLo4Qe1ZB6KAnSF/geJmAMf8SM8=; b=8DAwXLiA+rdMPQ0YGXu0tpcLUJMI9adPBhQ96ozXUxzsLyMmTKtFmkoOQ+Cw+Mk8k1 tzXy9VMSPq65uoENqpIPwrlpb0X/Z47QWJzhGRKSqqmYdK+PusUThWhpxYZVXXD7muOM a1flnZH+ebHcIQw+PW2CcO8/yTAgGoYnYngDhc26/K0piPtGUnHgSajBhv/olgU6Tjmk wy6/Mu+sNXc4jxeohDPhHDAnxX9YlYMwmFZctABp2nIjBKojY5KraqWMjhILSFKZRYLa fVh6cfVfwLl8RW0x4pqHBvR1rvQzG1FLfhjAtU1+FZ4lLoXMw+UrFBWB0aXpZ9Exokxt mG0A== X-Gm-Message-State: AOAM531J6Ic8hg/7pBEPutefir8bkAvm0btHf1ytZOkqd4BY7qv3QBCE CD6HCsLegH3a8ZlaEnnH7DOXNih0JfVeNTzf6Fd9fOoc X-Google-Smtp-Source: ABdhPJz5HOdweX3NtNPTfH7noCqoZQt92PNeQEsvvIHITorP/NuuPEK/Q17GydYWeU2pnGsq55rsL+u6gxgAHe63Oow= X-Received: by 2002:a81:6188:0:b0:2eb:4bd3:9b86 with SMTP id v130-20020a816188000000b002eb4bd39b86mr33073763ywb.46.1649861148680; Wed, 13 Apr 2022 07:45:48 -0700 (PDT) MIME-Version: 1.0 References: <20220406120056.10537-1-markg85@gmail.com> <20220406120056.10537-2-markg85@gmail.com> <20220410144127.GD2829255@pb2> <20220412180257.GL2829255@pb2> In-Reply-To: From: Hendrik Leppkes Date: Wed, 13 Apr 2022 16:45:36 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v13 1/1] avformat: Add IPFS protocol support. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, Apr 13, 2022 at 3:14 PM Mark Gaiser wrote: > > On Wed, Apr 13, 2022 at 2:28 PM Andreas Rheinhardt < > andreas.rheinhardt@outlook.com> wrote: > > > Mark Gaiser: > > > On Wed, Apr 13, 2022 at 1:10 AM James Almer wrote: > > > > > >> > > >> > > >> On 4/12/2022 3:02 PM, Michael Niedermayer wrote: > > >>> On Sun, Apr 10, 2022 at 04:41:27PM +0200, Michael Niedermayer wrote: > > >>>> On Wed, Apr 06, 2022 at 02:00:56PM +0200, Mark Gaiser wrote: > > >>>> [...] > > >>>> > > >>>>> + if (stat_ret < 0) { > > >>>> > > >>>>> + av_log(h, AV_LOG_INFO, "Unable to find IPFS folder. We > > >> tried:\n"); > > >>>>> + av_log(h, AV_LOG_INFO, "- $IPFS_PATH, which was > > >> empty.\n"); > > >>>>> + av_log(h, AV_LOG_INFO, "- $HOME/.ipfs (full uri: %s) > > >> which doesn't exist.\n", ipfs_full_data_folder); > > >>>> > > >>>> The 3 av_log() can also be combined > > >>>> > > >>>> If nothing else is found then ill change that myself and apply in a > > day > > >> or 2 > > >>> > > >>> applied > > >>> > > >>> thx > > >> > > >> This broke msvc > > >> > > >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(36): > > >> error C2065: 'PATH_MAX': undeclared identifier > > >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(36): > > >> error C2057: expected constant expression > > >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): > > >> error C2065: 'PATH_MAX': undeclared identifier > > >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): > > >> error C2057: expected constant expression > > >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): > > >> error C2466: cannot allocate an array of constant size 0 > > >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): > > >> error C2133: 'ipfs_full_data_folder': unknown size > > >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): > > >> error C2065: 'PATH_MAX': undeclared identifier > > >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): > > >> error C2057: expected constant expression > > >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): > > >> error C2466: cannot allocate an array of constant size 0 > > >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): > > >> error C2133: 'ipfs_gateway_file': unknown size > > >> > > >> PATH_MAX seems to be POSIX only. > > >> > > > > > > Seriously? > > > > > > Shouldn't that define work on windows too? > > > > For "that define" to work that define needs to exist. Windows has > > MAX_PATH, but it is pretty small (260). > > > > > And why didn't patchwork catch this? > > > > > > > Because there is no MSVC patchwork box. > > > > > What is the intended define to use for this? > > > Note that it used to be a fixed number in the code itself (4096?) but I > > > changed it to PATH_MAX as per review suggestions.... > > > > Then how about just adding > > #ifndef MAX_PATH > > #define MAX_PATH 4096 > > #endif > > or something like that. > > > > I'm fine with that but given past feedback I'll wait a little longer for a > 2nd opinion too. > master is currently broken, waiting is a luxury for another time. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".