From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BC50E456B8 for ; Sat, 18 Feb 2023 00:00:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 87F2E68BE51; Sat, 18 Feb 2023 02:00:06 +0200 (EET) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DA6D8689965 for ; Sat, 18 Feb 2023 02:00:00 +0200 (EET) Received: by mail-lj1-f169.google.com with SMTP id bx13so2646906ljb.3 for ; Fri, 17 Feb 2023 16:00:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=jzrwkYyGKZJ3Q+EisaAl+Cj5QQynRXd/U52cur3MzrA=; b=CIsXrVcpW/LapVPHVDmYRPKfRGZnMwT1QCYjLQBXR7zNFU4Gqq87gqjRQbFDLxxuPm gGzg+P8dK8z12KcHoVEKwrKjRIRlFg3S1bJCFkAnKneyhVp4QmIqQoa+J2GDZQBfMCJt v5qQI6FvS1ajVvv4sLz/Do7elivjMMT2NxqsFK7CVXdc3v+7GZVt9SiMUO85spuXYoXU A/bS32aDhuzdosXpWO6eMvhXMagnMuHyS8tM0lgF9HlHEvp4r5YDGYitQgld1HyWrW9A ko4a8H76SOhH4X7VnJUGf7Kf3o6lzwbzZCbkLmsTWa2PMAi1zPlK8HNW8rAI8dWnmsFz ql/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jzrwkYyGKZJ3Q+EisaAl+Cj5QQynRXd/U52cur3MzrA=; b=X4StLC6/DQJNtjdbVK/OX7uE3HU0LAAoCQcgm+kJQjDmSYqLhAPB5IpB/Kza9A9BBm SRqwkf/ssrWoOYL031cyvD/JdJHF9uOlfoVMK0hSB0l61y0fj1/zNY4OEBlv14qgR9cf h4tm3aFURltKxJmgdhH3yslRjbp82emH+geYvGvaywVVQm524vJyLBAvS3V5qDZqbjvn H3wZHAL8fcTSh1dHQVRFfy131IPt3phGRm6jrqzwxfrmxdXIdicRt0Tnqc7+8NPgq4Mg 49ywMhmH5a9UtnSYehSpS8Yn79aYveJ8H+H/6wfU1BE/P3C5xWj04LPE+DSl2ylcsbTP gm2A== X-Gm-Message-State: AO0yUKXosyAaWITePTvJg6wFjZ5ZAsx6TpKbOpDoPCLuVNEaqnkl5mku TdvjVJbXE4Rtk383Ci4muKna26AJ6WobPk/QAdoKBoBx X-Google-Smtp-Source: AK7set96JYZ1/VSwethG8aNY2RU4ltvQ29l3eXC3vLfUoEZliPrT47a/kYTMmT0vv88DAPVhXUUiywYEYGTjmoGIk24= X-Received: by 2002:a2e:a497:0:b0:293:2d7e:acd8 with SMTP id h23-20020a2ea497000000b002932d7eacd8mr920714lji.4.1676678398920; Fri, 17 Feb 2023 15:59:58 -0800 (PST) MIME-Version: 1.0 References: <66307ef3-b214-47f6-6d4e-fbcc439f2004@gmail.com> In-Reply-To: From: Hendrik Leppkes Date: Sat, 18 Feb 2023 00:59:47 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] lavc: deprecate avcodec_dct, av_fft, av_dct, av_rdft and av_mdct X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, Feb 17, 2023 at 7:45 PM Lynne wrote: > > Feb 17, 2023, 18:08 by jamrial@gmail.com: > > > On 2/17/2023 1:54 PM, Lynne wrote: > > > >> This reverts commit 26cb36f35746fe6ef53688b119852bfa6d555f62. > >> > >> All filters and all codecs (except wmavoice) have been ported for the > >> lavu/tx API. > >> > >> The noise should be minimal. > >> > > > > It isn't. I'm getting more than two thousand lines of warnings after applying this patch from > > > > libavfilter/vf_spp.c > > libavfilter/x86/vf_spp.c > > libavcodec/asvenc.c > > libavcodec/avdct.c > > libavcodec/avfft.c > > libavcodec/dct.c > > libavcodec/fdctdsp.c > > libavcodec/fft_float.c > > libavcodec/fft_init_table.c > > libavcodec/idctdsp.c > > libavcodec/jfdctfst.c > > libavcodec/jfdctint.c > > libavcodec/jrevdct.c > > libavcodec/mpegaudiodsp.c > > libavcodec/mpegvideo_enc.c > > libavcodec/rdft.c > > libavcodec/wmavoice.c > > libavcodec/x86/dct_init.c > > libavcodec/x86/fft_init.c > > libavcodec/x86/mpegvideoenc.c > > > > It's not just wmavoice, there's also mpeg and jpeg stuff, and one filter. For the actual fft/dct/rdft/mdct source files, you should use the deprecation warning pragmas to silence them, but the other modules need to be ported. > > This patch is also missing the schedule FF_API deprecation wrapper. > > > > Is the noise acceptable if I just deprecate the functions? > It wasn't before, but it should be much less now. An API we still use internally doesn't seem very deprecated to me. Should get rid of it, then there won't be any warnings. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".