From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AB8CC40D9E for ; Tue, 6 Dec 2022 23:38:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CC40D68BD95; Wed, 7 Dec 2022 01:38:08 +0200 (EET) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7F41B68BCF1 for ; Wed, 7 Dec 2022 01:38:02 +0200 (EET) Received: by mail-pf1-f181.google.com with SMTP id c13so8892394pfp.5 for ; Tue, 06 Dec 2022 15:38:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=oDFnDgdBG46Llr9N+adSPeewYE1VS/MQwlao2WQJsQM=; b=l0ooGaVq6kP/A65GapbEwheyXZdR5Ehw0N6oAgU0+axXDtYeuOGcdm1XzLv4mQV912 pJTfzIUrTx9zzDnUDzJWQtDaKfaHw5V/JgE9yIqwjUaNVfnkP/voOf/GWqI9ENjHSn9k WAYRSaxIJNvqAtpqTbEEjL6OyZ4Ip5iOtg2SuexJ5kGUZsbXx1puHVfaLNQB1BweDT5P l9z/V41nSRqioA4vArrTx6V1uWiiEHBlEwFLyzd1bHI907Nwk+xikB+KfQ/7JB4m4FeO /t+qCmgA/liAB7oXggaLf3lL+3MFCyKWkYSZg9fEOtIDv62T1AWa2UzZHcmSLdZtEQH9 U4Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oDFnDgdBG46Llr9N+adSPeewYE1VS/MQwlao2WQJsQM=; b=WOX8ggVlEz93kx/ga+bW+IpMllcuh85oKpvo/8MCRf1nV5MyQHyoaFE3MbRMaraL61 oGMoR3Kehk/6rDWMHY6r5f/ikVRWXR/N/fDHpjJbQp6mbDQNvCuWh1Nuv+vapTIh8hVR R4glm6NMTac15/lpebLaJswFO/z94ivtSVUXPlAAE7UpKvMAoSg74Z3rQVHHda9u8VSd LiMzulKiO9L0fEi4uA/DdzSmSpA9EHYgAqleeHNfxhO7/r1l32dqnVxyEppcA/XxAV7+ HnujZItjZm/BJVjZ6KlyquXc/tgXYmvGxPWG8FBba8pYAYSN6rimkz0p7GcLWwzQ5T+i vcFw== X-Gm-Message-State: ANoB5pm9vyP6OVm5S58TkpTpIxea7zroAPoxfY00YMViJUrHoc/e/FCy OZ5KgoeiT6NKCIodpDvXUNs8i8clFlOgCxpXL+2HBNt16E8= X-Google-Smtp-Source: AA0mqf79d8GMbCcgf1rAXXzUvdXpwmrBMGIvcOV+4gwvxeXcXA5p0rsYI5MEMrVrSCmtz7KUuzrrKpuHUww7+0MTPfs= X-Received: by 2002:a63:5254:0:b0:477:6195:34f8 with SMTP id s20-20020a635254000000b00477619534f8mr65032379pgl.286.1670369879455; Tue, 06 Dec 2022 15:37:59 -0800 (PST) MIME-Version: 1.0 References: <20221205221641.1215-1-mindmark@gmail.com> <8b87a0c1-2691-98aa-1bc2-fee897bd81ba@gmail.com> In-Reply-To: <8b87a0c1-2691-98aa-1bc2-fee897bd81ba@gmail.com> From: Mark Reid Date: Tue, 6 Dec 2022 15:37:48 -0800 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] avutil: move bswapdsp from avcodec to avutil X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Dec 6, 2022 at 10:21 AM James Almer wrote: > On 12/5/2022 7:16 PM, mindmark@gmail.com wrote: > > diff --git a/libavcodec/bswapdsp.h b/libavutil/bswapdsp.h > > similarity index 71% > > rename from libavcodec/bswapdsp.h > > rename to libavutil/bswapdsp.h > > index 6f4db66115..b540560d6a 100644 > > --- a/libavcodec/bswapdsp.h > > +++ b/libavutil/bswapdsp.h > > @@ -16,18 +16,16 @@ > > * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA > 02110-1301 USA > > */ > > > > -#ifndef AVCODEC_BSWAPDSP_H > > -#define AVCODEC_BSWAPDSP_H > > +#ifndef AVUTIL_BSWAPDSP_H > > +#define AVUTIL_BSWAPDSP_H > > > > #include > > > > -typedef struct BswapDSPContext { > > - void (*bswap_buf)(uint32_t *dst, const uint32_t *src, int w); > > +typedef struct AVBSwapDSPContext { > > + void (*bswap32_buf)(uint32_t *dst, const uint32_t *src, int len); > > void (*bswap16_buf)(uint16_t *dst, const uint16_t *src, int len); > > -} BswapDSPContext; > > +} AVBSwapDSPContext; > > > > -void ff_bswapdsp_init(BswapDSPContext *c); > > -void ff_bswapdsp_init_riscv(BswapDSPContext *c); > > -void ff_bswapdsp_init_x86(BswapDSPContext *c); > > +void av_bswapdsp_init(AVBSwapDSPContext *c); > > > > -#endif /* AVCODEC_BSWAPDSP_H */ > > +#endif /* AVUTIL_BSWAPDSP_H */ > > For what's supposed to become an installer header, this is barebones in > the documentation department. > > Also, does this have any real use for API users? If you want to access > these functions from swscale as well as lavc, you could either duplicate > the code, or use the avpriv prefix. > I'm not a fan of adding public API for something that has no use outside > of our own libraries. > I agree, I don't see a need for this to be public. I'll change it to use the avpriv prefix if that's okay. I'll add a little doc to the header too anyway. the blockdsp is disappearing from configure is a mistake, I'll fix that too > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".