Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Sergio Garcia Murillo <sergio.garcia.murillo@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] Patch which requires a new library
Date: Thu, 7 Mar 2024 18:30:46 +0100
Message-ID: <CA+ag07YEPLmedE3v8wVOm1s=rzayZw3oujsKtB3pTtPYzrxNcg@mail.gmail.com> (raw)
In-Reply-To: <CAK+ULv5VYSM_DBh6Tj7NhUJzMHuetT2Y_xgk21sHjRQeycX4wg@mail.gmail.com>

El jue, 7 mar 2024, 18:21, Kieran Kunhya <kierank@obe.tv> escribió:

> On Thu, 7 Mar 2024, 17:16 Sergio Garcia Murillo, <
> sergio.garcia.murillo@gmail.com> wrote:
>
> > El jue, 7 mar 2024, 16:30, Kieran Kunhya <kierank@obe.tv> escribió:
> >
> > > On Thu, 7 Mar 2024 at 15:07, Sergio Garcia Murillo <
> > > sergio.garcia.murillo@gmail.com> wrote:
> > >
> > > >
> > > > Could anyone give me any pointers on what is the best way of doing
> > this?
> > > >
> > >
> > > You should use a well known crypto library to implement this in FFmpeg
> > (e.g
> > > libgcrypt, openssl
> > >
> >
> > In fact, the sigv library allows to pass the crypto implementation you
> want
> > to use:
> >
> >
> >
> https://github.com/aws/SigV4-for-AWS-IoT-embedded-sdk/blob/dc530f7a21ec96db62afe73e21e3b7dfad0d648c/source/include/sigv4.h#L235
> >
> > So the patch is already using whatever crypto library ffmpeg is
> configured
> > to use.
> >
> > Anyway, not sure if i understood your feedback correctly, but my question
> > was about what is the best way of adding the sigv4 library as an optional
> > dependency in the configuration file and how to modify the patch so the
> > sigv4 specific code is only compiled if it is enabled by the
> configuration.
> >
>
> The point is we don't want to use the external lib.
>

For what? This is aws lib implementing the aws s3 signatures and using
ffmpeg crypto libs.

Best regards
Sergio

>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-03-07 17:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-07 15:06 Sergio Garcia Murillo
2024-03-07 15:30 ` Kieran Kunhya
2024-03-07 17:16   ` Sergio Garcia Murillo
2024-03-07 17:20     ` Kieran Kunhya
2024-03-07 17:30       ` Sergio Garcia Murillo [this message]
2024-03-07 18:02         ` Rémi Denis-Courmont
2024-03-07 20:16           ` Sergio Garcia Murillo
2024-03-07 20:56             ` Kieran Kunhya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+ag07YEPLmedE3v8wVOm1s=rzayZw3oujsKtB3pTtPYzrxNcg@mail.gmail.com' \
    --to=sergio.garcia.murillo@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git