From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 91BCA40F2C for ; Sat, 1 Jan 2022 16:54:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 68B3C68B10D; Sat, 1 Jan 2022 18:54:43 +0200 (EET) Received: from mail-ua1-f48.google.com (mail-ua1-f48.google.com [209.85.222.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 404BF68B109 for ; Sat, 1 Jan 2022 18:54:37 +0200 (EET) Received: by mail-ua1-f48.google.com with SMTP id c36so25673483uae.13 for ; Sat, 01 Jan 2022 08:54:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=kRjIZyydynKi5AW2WqfbqpnvwcCwfswrpSfzSaqW/Cw=; b=RzCFMY2WShuy/G9UNJt2TPm+xTpJebXvDZLybm4KcUWTtMmcIx6G4co0cNrTJ0fWO/ 0MFG+GSbb6wnVb268+IT6MnQhaXn+4Ld5+3oklW/qV+5YaInTlCXweoArVv+QZJYbM9o iEjN8I9n0WJNWIOf/oWWV88ANKjbexkttSGvIJtsUOOD7PTilSNxvLr0t7oZqfA1/FRA uZMw3OdVx9rXUTQkZXOxjDp7dvHp2pg2bWV+c+FJHxd2JMurmeHF6VRgoSOi+BSopLtu yBKv62T/uTrN8KYf+r6o7aU2B9m5I+7tiZOOLzcWikJ+Bnk9XgvCXYReM/0JdgXxS4bl jDkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=kRjIZyydynKi5AW2WqfbqpnvwcCwfswrpSfzSaqW/Cw=; b=lPjc+vvdKaeaKXA2y69ZLz9I9Ok4xejHexwShs5K2qbm1QiEwByLPjyPF2oinU03y+ 4KIFbpjm+FiEi8Ybs5pe4cJG+WIXMicea+lcQsZPfomauuF0ORse6F8KKbcyjRYV/NKv jIcBIH+RyM4C1k8tz6sKoFAjbZ8YHkzyFKe9hmcLiq0buy2TZ1FWott1FMoQVflbFHtN 8TZJPBR5j6nQeeKOFOlXL54culj8jpMnXZ/5tdDcFca2ohpzxz63zQYACcbc3toZUQ8H IfdYWBGG0HucaqfEPrXWQgJVBMwQsGMwSP1FHr+yItfSDFO7YFPmYndb1hqiv7X0fIyt 52KA== X-Gm-Message-State: AOAM530JMFYs9odXfEqKBXbRYLVJui6gyVblxHrbjsStqjHOZEnCfv0C PBnKcfzAiZc8ujc9YHvqUl4OfzG9q5kQAmFvKZl3d0cfe/zpow== X-Google-Smtp-Source: ABdhPJxlBGP9F1YLoUBAJI4VdOdFQgxDGPRKIPVtQ+BPmub09tHPE2HPpJjr2KgcSbZf2DklWlFJ7ViYKYNu5B/vWvk= X-Received: by 2002:a05:6102:cca:: with SMTP id g10mr4246603vst.75.1641056075409; Sat, 01 Jan 2022 08:54:35 -0800 (PST) MIME-Version: 1.0 References: <20220101041621.427012-1-tcChlisop0@gmail.com> <20220101041621.427012-6-tcChlisop0@gmail.com> In-Reply-To: From: quietvoid Date: Sat, 1 Jan 2022 11:54:24 -0500 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v11 5/5] fate/matroska: Add tests for reading/writing BlockAdditionMapping elements X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, Jan 1, 2022 at 2:57 AM Andreas Rheinhardt wrote: > > quietvoid: > > Tests the parsing and writing of AVDOVIDecoderConfigurationRecord, > > when it is present as a Dolby Vision configuration block addition mapping. > > > > Signed-off-by: quietvoid > > --- > > The required regression test file is available here: https://0x0.st/-hWK.mkv > > Should be moved to fate-suite/mkv/dovi-p5.mkv > > > > It is a blank frame encoded with x265. > > --- > > tests/fate/matroska.mak | 9 + > > tests/ref/fate/matroska-dovi-config-profile5 | 13 ++ > > tests/ref/fate/matroska-dovi-write-config | 223 +++++++++++++++++++ > > 3 files changed, 245 insertions(+) > > create mode 100644 tests/ref/fate/matroska-dovi-config-profile5 > > create mode 100644 tests/ref/fate/matroska-dovi-write-config > > > > diff --git a/tests/fate/matroska.mak b/tests/fate/matroska.mak > > index e117a0f6a6..ec2a0607b2 100644 > > --- a/tests/fate/matroska.mak > > +++ b/tests/fate/matroska.mak > > @@ -138,6 +138,15 @@ FATE_MATROSKA_FFMPEG_FFPROBE-$(call ALLYES, FILE_PROTOCOL WEBVTT_DEMUXER \ > > += fate-webm-webvtt-remux > > fate-webm-webvtt-remux: CMD = transcode webvtt $(TARGET_SAMPLES)/sub/WebVTT_capability_tester.vtt webm "-map 0 -map 0 -map 0 -map 0 -c:s copy -disposition:0 original+descriptions+hearing_impaired -disposition:1 lyrics+default+metadata -disposition:2 comment+forced -disposition:3 karaoke+captions+dub" "-map 0:0 -map 0:1 -c copy" "" "-show_entries stream_disposition:stream=index,codec_name:packet=stream_index,pts:packet_side_data_list -show_data_hash CRC32" > > > > +FATE_MATROSKA_FFMPEG_FFPROBE-$(call ALLYES, MATROSKA_DEMUXER) += fate-matroska-dovi-config-profile5 > > This should be FATE_MATROSKA_FFPROBE, not FATE_MATROSKA_FFMPEG_FFPROBE. > And actually, you need the file protocol; if you don't check for it, > you can just use FATE_MATROSKA_FFPROBE-$(CONFIG_MATROSKA_DEMUXER). > > > +fate-matroska-dovi-config-profile5: CMD = run ffprobe$(PROGSSUF)$(EXESUF) -show_entries stream_side_data_list -select_streams v -v 0 $(TARGET_SAMPLES)/mkv/dovi-p5.mkv > > + > > +FATE_MATROSKA_FFMPEG_FFPROBE-$(call ALLYES, FILE_PROTOCOL PIPE_PROTOCOL \ > > + MOV_DEMUXER MATROSKA_MUXER \ > > + FRAMECRC_MUXER) \ > > You will need the MATROSKA_DEMUXER, too; after all, the created file is > read and demuxed. Thanks again. Fixed along with the other comments (for the other patches). v12: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-January/290630.html > > + += fate-matroska-dovi-write-config > > +fate-matroska-dovi-write-config: CMD = transcode mov $(TARGET_SAMPLES)/hevc/dv84.mov matroska "-c:v copy" "-map 0 -c copy" "" "-show_entries stream_side_data_list -select_streams v -v 0" > > + > > FATE_SAMPLES_AVCONV += $(FATE_MATROSKA-yes) > > FATE_SAMPLES_FFPROBE += $(FATE_MATROSKA_FFPROBE-yes) > > FATE_SAMPLES_FFMPEG_FFPROBE += $(FATE_MATROSKA_FFMPEG_FFPROBE-yes) > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".