From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2467742A8A for ; Fri, 9 Sep 2022 22:50:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 629A768BAE1; Sat, 10 Sep 2022 01:50:50 +0300 (EEST) Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AC96668B9F3 for ; Sat, 10 Sep 2022 01:50:44 +0300 (EEST) Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-333a4a5d495so35228967b3.10 for ; Fri, 09 Sep 2022 15:50:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date; bh=Vr2ug4QA0jSCoBX2PAtmYRo1K8RFQTLugDeIBtoe/o0=; b=VjTgGTAU0EttClcjb1wAmAqdP+zybZXzyW4ZsKFlbHLIqYxK//n1ix559uEWY8XFAP EFPXJX8oWv7xlquo65w+OpcJVA8+KvQLQu+qalHPlAlJALCjlw8MDF5yP8vKXlxk8W7m /xUDBpNsppPsuDzKijWnVHVJaNzGwNdREY4Ng= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date; bh=Vr2ug4QA0jSCoBX2PAtmYRo1K8RFQTLugDeIBtoe/o0=; b=FwTJ4NjEH/EmJ8CUzvQYXNLOhpPjz2y1rED2sjMYeXCG5G5Se+8bMpl9+saxb1Mjbw AG/fnM+WqYT4xiP2LFU+Fk0bRgi11TFzH74CwFcLwT43YunOioK1AfEgtUoP0vlbREkD ZAddgMxDzRN7XLjyFEfSmmYbrhseOW79xhNT6LBFVpSaZthWOD/nsFRvgVQ/KRHw2EkN xfVlKjx48KjPF70CkAQSQlAJqjFlXHmcbgSnAb9wf23CMzUH5y3MucDOkxos7TCPLjq4 06qTqJxXJSnHzaKIehf0g+wE4Doqd7ArMUYSkUhDVfXCUyZwdOhnsrb/YXRQ76C4qta5 E8gw== X-Gm-Message-State: ACgBeo2QHNkD54iudGlroKnA8z3xHf9p3wNewC61T8Zf1qzbrkcHvnSN H1Pe4NZxyNG1E4IScBJC9Xm8FgwDlhu9gUjx4x7/yeTS3YwAxS33e3NXy8aK X-Google-Smtp-Source: AA6agR6v5VY7IdlKHPjGEupsdRGpS+h6BvzLBjWon8BJMZC1vj1/ACxlZ1U+N/6eybIjOT5gb8YuG77c1HSmNhj9d3U= X-Received: by 2002:a81:df14:0:b0:324:e852:5895 with SMTP id c20-20020a81df14000000b00324e8525895mr13754717ywn.200.1662763842997; Fri, 09 Sep 2022 15:50:42 -0700 (PDT) MIME-Version: 1.0 From: Will Cassella Date: Fri, 9 Sep 2022 22:50:32 +0000 Message-ID: To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH] libavformat/riffec: Zero-initialize `channels` in `ff_get_wav_header` X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Clang's static analyzer complains that leaving the `channels` variable uninitialized could lead to a code path where the uninitialized value is written to `par->ch_layout.nb_channels` at the end of this function. This patch simply zero-initializes that variable to avoid that. Signed-off-by: Will Cassella --- libavformat/riffdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/riffdec.c b/libavformat/riffdec.c index 3946ecb72f..fc75500d1f 100644 --- a/libavformat/riffdec.c +++ b/libavformat/riffdec.c @@ -94,7 +94,7 @@ static void parse_waveformatex(AVFormatContext *s, AVIOContext *pb, AVCodecParam int ff_get_wav_header(AVFormatContext *s, AVIOContext *pb, AVCodecParameters *par, int size, int big_endian) { - int id, channels; + int id, channels = 0; uint64_t bitrate = 0; if (size < 14) { -- 2.37.2.789.g6183377224-goog _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".