From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CCB2C4A300 for ; Tue, 26 Mar 2024 15:48:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ED0DB68D54F; Tue, 26 Mar 2024 17:48:31 +0200 (EET) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CFCF768D471 for ; Tue, 26 Mar 2024 17:48:24 +0200 (EET) Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-5cfb8126375so79273a12.1 for ; Tue, 26 Mar 2024 08:48:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711468103; x=1712072903; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VoB/mLlVgRMPClOE2edOpsSOc0j4+GKJNOnys0Hab4Y=; b=rgXDYITXFeHkPrMKbPqi6k8U+ZVmMZeYR0cqsr/k8j592HDCk8lyATT71X3hD3HVx+ PbtdsAeu0lDnzzaNMNNyXMoKisC6qvrduD8zwb9tF4OY0zB+etWdgiEZj96O1XtatHjf IHdHhZi0698Ne7Duzp9goX+mvqUsqrKBiOQM0QsMcnkAwWoGFktuEH7frMjPgFmKQZZ7 D//g7LAZtAD0VIqwMjGsQ69DGQXiJHgFojyJ8xTEf37dWv2SyF/H1CMaPhATfu8XPUIc ZgtgMIxO1AC8iT/rKymjl334TsEwNIxaBuUXvhh/MYU3BsHwdA+6z1isGmV2c6zlzaUK eN7A== X-Gm-Message-State: AOJu0YyVANjrGdhjHc6HI3hJ/Q31SJqTiHKU7mr0SfPAVkNZF+/5KzIN 24faXL6RXWITPTamncinIKCMc3yiisKXZEU3/7zD5rQxVdTMnf7n9Vc2HUYG7wf2J6qjMuDVvgI jw6MnJFKBtDPkvQL9flHUmWMKi9WQZ5i5WaZzOaBIYdPuCxejzz4= X-Google-Smtp-Source: AGHT+IF9yy2de2KgNQgSA91zq0ZEA/h9lQhSDqWkDw0etas1KZFhVkIT0SOjLSUEQr/ot7uQvAjkNDhHmxskyhsK6wA= X-Received: by 2002:a05:6a21:6da3:b0:1a3:713d:1059 with SMTP id wl35-20020a056a216da300b001a3713d1059mr12570194pzb.4.1711468102839; Tue, 26 Mar 2024 08:48:22 -0700 (PDT) MIME-Version: 1.0 References: <20240324022504.1419451-1-marth64@proxyid.net> <20240324022504.1419451-2-marth64@proxyid.net> In-Reply-To: From: Marth64 Date: Tue, 26 Mar 2024 10:48:12 -0500 Message-ID: To: FFmpeg development discussions and patches , Marth64 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v9 1/5] avformat/subtitles: extend ff_subtitles_queue_insert() to support not yet available events X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > is the move needed? (but not blocking) It is not needed, but the code flows better I think in terms of readability. I think it feels cleaner to say, "set up `sub` then add it to the array" vs. "set up sub's data, add it to the array, then set up its other fields". But, I am good either way and on stand by if you request me to change it. Thank you for the review. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".