From: Marth64 <marth64@proxyid.net>
To: FFmpeg development discussions and patches
<ffmpeg-devel@ffmpeg.org>, Marth64 <marth64@proxyid.net>
Subject: Re: [FFmpeg-devel] [PATCH v9 1/5] avformat/subtitles: extend ff_subtitles_queue_insert() to support not yet available events
Date: Tue, 26 Mar 2024 10:48:12 -0500
Message-ID: <CA+28BfDsQJmUEsy+mUrpGJrVJ7zmbgEv4kFbc1TB7Zm2Wc0iFg@mail.gmail.com> (raw)
In-Reply-To: <ZgLtGSqLC/kA654o@mariano>
> is the move needed? (but not blocking)
It is not needed, but the code flows better I think in terms of
readability. I think it feels cleaner to say, "set up `sub` then add it to
the array" vs. "set up sub's data, add it to the array, then set up its
other fields". But, I am good either way and on stand by if you request me
to change it.
Thank you for the review.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-26 15:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-24 2:24 [FFmpeg-devel] [PATCH v9 0/5] RCWT Closed Captions demuxer (v9) Marth64
2024-03-24 2:25 ` [FFmpeg-devel] [PATCH v9 1/5] avformat/subtitles: extend ff_subtitles_queue_insert() to support not yet available events Marth64
2024-03-26 15:43 ` Stefano Sabatini
2024-03-26 15:48 ` Marth64 [this message]
2024-03-26 16:16 ` Andreas Rheinhardt
2024-03-24 2:25 ` [FFmpeg-devel] [PATCH v9 2/5] avformat/rcwtdec: add RCWT Closed Captions demuxer Marth64
2024-03-26 16:04 ` Stefano Sabatini
2024-03-24 2:25 ` [FFmpeg-devel] [PATCH v9 3/5] avformat/rcwtenc: remove repeated documentation Marth64
2024-03-26 16:04 ` Stefano Sabatini
2024-03-24 2:25 ` [FFmpeg-devel] [PATCH v9 4/5] doc/muxers: refresh the RCWT muxer's doc to be consistent with the demuxer Marth64
2024-03-24 2:25 ` [FFmpeg-devel] [PATCH v9 5/5] doc/indevs: update CC extraction example to use RCWT muxer Marth64
2024-03-26 15:29 ` [FFmpeg-devel] [PATCH v9 0/5] RCWT Closed Captions demuxer (v9) Marth64
2024-03-26 16:07 ` Stefano Sabatini
2024-03-28 18:03 ` Stefano Sabatini
2024-03-28 18:29 ` Marth64
2024-03-28 19:24 ` Marth64
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+28BfDsQJmUEsy+mUrpGJrVJ7zmbgEv4kFbc1TB7Zm2Wc0iFg@mail.gmail.com \
--to=marth64@proxyid.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git