From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 939B547C84 for ; Sun, 14 Jan 2024 16:58:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ACA2868BAC9; Sun, 14 Jan 2024 18:58:08 +0200 (EET) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 98A7A68BAC9 for ; Sun, 14 Jan 2024 18:58:01 +0200 (EET) Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-58962bf3f89so1002005a12.0 for ; Sun, 14 Jan 2024 08:58:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705251479; x=1705856279; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U6zJmCMNEQRWrT7eP09QW8o3BJPpFocAdj5K1PWNNPk=; b=TZNKFF9d/DxCVlxN0/P1OtvemHLGeMm/l1yfd6cAt4lFziYNCzcRutzV+UneKR7XxJ ipz2hDDQC9+Oc6lOI2y0IN44TnSDwxtBZG78SOkDlKIqh3yDeZfLnxGkWwrn5b7EM3kG wuhbeOAtWJUbIQ/vpaqfZPI3JAIxTB3Ms5zyB7F5AlBQj2s1G/dpwa27Fg4cDS0Jlt+T N5JPUqoSoBwlGnKh5gkvCWsUd6qWftYOxGv0amSb/uZDPwrPNG4zDx7rBctF1pxbesb7 rLi98uFWOqSpvqablTWs6jNBZ0DJ6csALJMPRAPpn3GTrsiYTArlcGmBlhiRQ9HVnm7E BkQA== X-Gm-Message-State: AOJu0YyqzMhgU0hCdSqI2peu1cAoyvJoY/0xj66YbNtsVGdI8JlBxi7T mBjHsDy1DICRmKxMmmTwgJdLGNUeC2i9N8JnOSCiaakHWAQK53DyXcbw48Ft X-Google-Smtp-Source: AGHT+IGu70/tVxuu2/MCGqZbH3Iv+AawcEVugpyOVUT/xq8Y10URjm9UbtpoHc19fv/bYP9B/bLhCD6P8vspz+pq1co= X-Received: by 2002:a17:90b:1d07:b0:28e:230f:8e09 with SMTP id on7-20020a17090b1d0700b0028e230f8e09mr4926098pjb.3.1705251479642; Sun, 14 Jan 2024 08:57:59 -0800 (PST) MIME-Version: 1.0 References: <20240107150700.1604665-1-marth64@proxyid.net> In-Reply-To: From: Marth64 Date: Sun, 14 Jan 2024 10:57:48 -0600 Message-ID: To: FFmpeg development discussions and patches , Marth64 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v3] libavformat: add RCWT closed caption muxer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Thank you, Stefano. I had thought I did , but next time I will also test applying the patch too on local : ) On Sun, Jan 14, 2024 at 08:16 Stefano Sabatini wrote: > On date Sunday 2024-01-07 16:24:07 +0100, Stefano Sabatini wrote: > > On date Sunday 2024-01-07 09:07:01 -0600, Marth64 wrote: > > > Thanks, long night. Should come together nicer now. > > > > > > Signed-off-by: Marth64 > > > --- > > > Changelog | 1 + > > > doc/muxers.texi | 22 +++++ > > > libavformat/Makefile | 1 + > > > libavformat/allformats.c | 1 + > > > libavformat/rcwtenc.c | 202 +++++++++++++++++++++++++++++++++++++++ > > > tests/fate/subtitles.mak | 3 + > > > tests/ref/fate/sub-rcwt | 1 + > > > 7 files changed, 231 insertions(+) > > > create mode 100644 libavformat/rcwtenc.c > > > create mode 100644 tests/ref/fate/sub-rcwt > > > > > LGTM, I'll wait a few days to see if there are more comments before > > pushing (if I forget please ping). > > Applied, thanks. > > (BTW for the future when updating a patch, generate the patch with git > format-patch and attach it to the email, in order to avoid manual > editing on the committer side). > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".