From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9D7594C4EB for ; Sun, 28 Jul 2024 15:30:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DCE5868D88A; Sun, 28 Jul 2024 18:30:22 +0300 (EEST) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D841E68D6C1 for ; Sun, 28 Jul 2024 18:30:16 +0300 (EEST) Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2cb5eafd585so375711a91.2 for ; Sun, 28 Jul 2024 08:30:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722180615; x=1722785415; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NLXbrZ9PILkcdndjF7Aonm5gcPgFCeExT+cibTfRc88=; b=INtsIqfPC3jgI84DxdEWDff6QtmjBDGbtcMy024RBIdoXkNf8EaruuW/Lo4xlIxioH ke0zCF1Fd+lLYhdNLUWTSxjQ6P3UtuaRxglkyqaN1uwpcKRi4SNYqBXaP15WfuDyWFxj KGN0VZt4aspbdeagPmhrS8p33mHGtxpALZet8wnbdecJeNPExYxhkLPTQAZHZ/RYymV4 98Yza6lN2iNHptCDnXNyRrSK+l/CJ511mVTLjunQlAhBefFjZons4+5yyHcbCPnTF8QN UkXkceaMel1ns+EVXPV2iXh3GcaMTl+lB34+QujUsVwz46S4cTvCi/fcsrArR7KOwx/A RzxA== X-Gm-Message-State: AOJu0Yw1WHi4r/TB5scXcna7MkImdte8vtAZoyk9Aj72xTLeRTHoxCKR jkt2QoQ+YPdG3WOiH92GZUtVxHwkYZxuZwSSLUf9kygMtfo/B8H1+ZxMgzsXPV73tDaxfaFHBut 0qGS1UcVnHoBkkO7BxMPY/Y8bg43pAmumMqjpJeP2M7Ma8L2gbWE= X-Google-Smtp-Source: AGHT+IGVFo4idve9+6LmlsMq6+TZ1qCKqebZhTgme+gZdPkzhQnfIFBaNDiX1WYzX32KgzPluWSJ1eezZvJh5ZwWR6E= X-Received: by 2002:a17:90a:9a93:b0:2c9:6920:d2b2 with SMTP id 98e67ed59e1d1-2cf24fe6961mr8338521a91.1.1722180614848; Sun, 28 Jul 2024 08:30:14 -0700 (PDT) MIME-Version: 1.0 References: <20240728073445.725161-1-marth64@proxyid.net> <20240728073445.725161-3-marth64@proxyid.net> In-Reply-To: From: Marth64 Date: Sun, 28 Jul 2024 10:30:04 -0500 Message-ID: To: Sean McGovern Subject: Re: [FFmpeg-devel] [PATCH 2/7] avformat/dvdvideodec: Implement seeking X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marth64 , FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi Sean_McG, good day, First of all, there is a typo in the commit message. It should say "at the mercy of dvdnav_time_search()" > I think avpriv_report_missing_feature() might be more appropriate here. But there is no missing feature, the implementation is working great with dvdnav_time_search(). However, dvdnav_jump_to_sector_by_time() is slightly more reliable than dvdnav_time_search(). Currently, VLC player, my reference for DVD at this time, is using dvdnav_jump_to_sector_by_time() via a workaround that I am not willing to bring to FFmpeg: https://code.videolan.org/videolan/vlc/-/blob/master/modules/access/dvdnav.c#L60 The point of this "PATCHWELCOME" is to say swap to dvdnav_jump_to_sector_by_time(), when or if libdvdnav is eventually released again. > Also, does this build properly if a user does not have libdvdnav? Since the demuxer was already introduced in march and relies on dvdnav, dvdnav is a dependency. The demuxer will not be included in the build at all if the build is not configured with dvdnav and dvdread. This is the case and is documented sinc March 2024, and has not changed. Thank you! _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".