Re: [FFmpeg-devel] [PATCH 2/7] avformat/dvdvideodec: Implement seeking

From: Marth64 <marth64@proxyid.net>
To: Sean McGovern <gseanmcg@gmail.com>
Cc: Marth64 <marth64@proxyid.net>,
	FFmpeg development discussions and patches
	<ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/7] avformat/dvdvideodec: Implement seeking
Date: Sun, 28 Jul 2024 10:30:04 -0500
Message-ID: <CA+28BfCn19AGSkE=qtswDOYfr6TR5XMvqkiAU_NfwXTu=XHAbQ@mail.gmail.com> (raw)
In-Reply-To: <CAPBf_Ok6wr+4LduVJM=yrd0qg8SBH=vZFdmd5Adz4Fo7LFk98g@mail.gmail.com>

Hi Sean_McG, good day,

First of all, there is a typo in the commit message. It should say
"at the mercy of dvdnav_time_search()"

> I think avpriv_report_missing_feature() might be more appropriate here.
But there is no missing feature, the implementation is working great
with dvdnav_time_search().
However, dvdnav_jump_to_sector_by_time() is slightly more reliable
than dvdnav_time_search().
Currently, VLC player, my reference for DVD at this time, is using
dvdnav_jump_to_sector_by_time()
via a workaround that I am not willing to bring to FFmpeg:
https://code.videolan.org/videolan/vlc/-/blob/master/modules/access/dvdnav.c#L60

The point of this "PATCHWELCOME" is to say swap to
dvdnav_jump_to_sector_by_time(),
when or if libdvdnav is eventually released again.

> Also, does this build properly if a user does not have libdvdnav?
Since the demuxer was already introduced in march and relies on
dvdnav, dvdnav is a
dependency. The demuxer will not be included in the build at all if the build
is not configured with dvdnav and dvdread. This is the case and is documented
sinc March 2024, and has not changed.

Thank you!
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".