From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A8F1E456F1 for ; Sat, 18 Feb 2023 19:35:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D7A3968BEDD; Sat, 18 Feb 2023 21:35:54 +0200 (EET) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9845368BC0F for ; Sat, 18 Feb 2023 21:35:48 +0200 (EET) Received: by mail-pg1-f175.google.com with SMTP id 22so681992pgh.6 for ; Sat, 18 Feb 2023 11:35:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676748946; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Si3Y9NbUhqjcw8pgNLJr0viRe8Smo1+nfPg8m962oX8=; b=icpMEptmNPmzp1a4Msqfd6FWMMzv1kY/3lUtX8OSxa1MGpDWCvl/pW8qTqP8znPSHg Hp0VXASlZlQFuMiAuiNoBWUb4tER4tboMe+Pa3pFGJolq+rtB0qbPLs+opTE+ql6oe6l gteLkNJkE22skLZSQ+tK9GBUu1lU1YcwkE6nxvo289Y34d/d5cO5LJWXFqAPADw9EC32 EXNt7zcPEIFSJMVqdsRIWT4BY9ofbzDkb0qw1DQkEfScm4U1p6FW/8CcWS/qrWG3qrMG uDzn7rg3MwAKpS6BzPjomWkfeAfyhvvyCKI/rQ16vudJjccaN9lCDWpsNMXc3qSa8R6W vKeQ== X-Gm-Message-State: AO0yUKW+w6LiJ7pI5XA6SOgvNT9jHkrPDVit/UvuBnDz4KJ5Gk2W+sIk Mo6OyTss4bakpaAcO30e4wqcm9R1wg07T90D0zgaxzKheN/XPVMN X-Google-Smtp-Source: AK7set/fHYJIEN6bmFglsqYpGMFRBSupyMrP80GZt4KS3LvqaMExSURVoSCoLQv8V0/O8O3bnVWyBq4Z4iJCcdCj6d4= X-Received: by 2002:aa7:9a5d:0:b0:5a8:a9f1:48f with SMTP id x29-20020aa79a5d000000b005a8a9f1048fmr399153pfj.21.1676748946197; Sat, 18 Feb 2023 11:35:46 -0800 (PST) MIME-Version: 1.0 References: <20230218174955.372237-1-marth64@proxyid.net> In-Reply-To: From: Marth64 Date: Sat, 18 Feb 2023 13:35:35 -0600 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/eac3dec: add detection of Atmos spatial extension profile X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Embarrassing, good eye. Fixing now! On Sat, Feb 18, 2023 at 12:59 PM Hendrik Leppkes wrote: > On Sat, Feb 18, 2023 at 6:50 PM Marth64 wrote: > > > > Signed-off-by: Marth64 > > --- > > - Missed adding the profiles to actual codec descriptor in ac3dec_float > > - Formatting tidyness > > > > libavcodec/ac3dec.c | 3 +++ > > libavcodec/ac3dec.h | 1 + > > libavcodec/ac3dec_float.c | 2 ++ > > libavcodec/avcodec.h | 2 ++ > > libavcodec/codec_desc.c | 1 + > > libavcodec/eac3dec.c | 11 ++++++++++- > > libavcodec/profiles.c | 5 +++++ > > libavcodec/profiles.h | 1 + > > 8 files changed, 25 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c > > index 0b120e6140..b5f4b166d3 100644 > > --- a/libavcodec/ac3dec.c > > +++ b/libavcodec/ac3dec.c > > @@ -1714,6 +1714,9 @@ skip: > > if (!err) { > > avctx->sample_rate = s->sample_rate; > > avctx->bit_rate = s->bit_rate + s->prev_bit_rate; > > + > > + if (s->eac3_extension_type_a == 1) > > + avctx->profile = s->eac3_extension_type_a == 1 ? > FF_PROFILE_EAC3_DDP_ATMOS : FF_PROFILE_UNKNOWN; > > } > > You have to leave out the if(..) for this to make sense. :) > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".