From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0E77D45131 for ; Thu, 9 Feb 2023 04:49:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AD15568BE7B; Thu, 9 Feb 2023 06:49:48 +0200 (EET) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1AF3668BB67 for ; Thu, 9 Feb 2023 06:49:42 +0200 (EET) Received: by mail-pf1-f180.google.com with SMTP id y4so577526pfe.4 for ; Wed, 08 Feb 2023 20:49:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ehUzEjoTq7OGKMICOZPWZECS4Z4SZvlCCDfcQnpGzxs=; b=gvzcd3YVkt2GMj6cMymoNcQ7ZCq/G5ZBqEvu5/gAqNbxvqLJYWXkhwvKFI5+fK/eMu 0KzghDYAMON0X3Q6re7yr9ZxMItE/QiOPdDGGdZ6oakoA2XtjKwHxmIwt0NR6NxarQVx ruehq4PaqGrhjZeVD8PXSB7zDrmvkEm5lvV0Vg7TkrGBzpaugbNfgI+jcrlF5thcaK3e 7cfCpYmqgI3/onFTqo6N4AeChwsE5QUYLsBbKpiUJ3/2/wHle0ZnedXUM7so1ZQGHahZ w8be76w6nKw6ucar0XkFZhKvn/TPX62LrnsHd+uNHS/N7uAHymHR8sbBHWuYAB8MlDmR VeCg== X-Gm-Message-State: AO0yUKUEbBdqET+eoSKqg5RJggHzG1d4+Kh4EtxsBSmxhafZnRzMJAHB wWYTs/fv9psQG5hdwRGw3gnZxkHi7tJeMclj3Xe2lh/lqpAUR+4M X-Google-Smtp-Source: AK7set9nQXAWD75ue9CSkDtyXdSopynTVgGzc28DlMPdVZmFTO6jwdAQuAztDFyXVAdPLVjpea3JYM3y3PoKjupfIss= X-Received: by 2002:a62:55c4:0:b0:593:92e9:991e with SMTP id j187-20020a6255c4000000b0059392e9991emr2483119pfb.43.1675918180179; Wed, 08 Feb 2023 20:49:40 -0800 (PST) MIME-Version: 1.0 References: <20230206181215.2577927-1-marth64@proxyid.net> <167591240250.10789.4906950446642573791@lain.khirnov.net> In-Reply-To: <167591240250.10789.4906950446642573791@lain.khirnov.net> From: Marth64 Date: Wed, 8 Feb 2023 22:49:29 -0600 Message-ID: To: FFmpeg development discussions and patches , Marth64 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: move help text for -ab/-b:a to audio category X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Thank you On Wed, Feb 8, 2023 at 9:13 PM Anton Khirnov wrote: > Quoting Marth64 (2023-02-06 19:12:15) > > Since at least 4.4.3, -ab/-b:a help text was in the video section > > of ffmpeg -h, but these are audio options. > > > > Signed-off-by: Marth64 > > --- > > fftools/ffmpeg_opt.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c > > index 204be38c94..799dcf071e 100644 > > --- a/fftools/ffmpeg_opt.c > > +++ b/fftools/ffmpeg_opt.c > > @@ -1637,8 +1637,6 @@ const OptionDef options[] = { > > { "force_key_frames", OPT_VIDEO | OPT_STRING | HAS_ARG | OPT_EXPERT > | > > OPT_SPEC | OPT_OUTPUT, > { .off = OFFSET(forced_key_frames) }, > > "force key frames at specified timestamps", "timestamps" }, > > - { "ab", OPT_VIDEO | HAS_ARG | OPT_PERFILE | OPT_OUTPUT, > { .func_arg = opt_bitrate }, > > - "audio bitrate (please use -b:a)", "bitrate" }, > > { "b", OPT_VIDEO | HAS_ARG | OPT_PERFILE | OPT_OUTPUT, > { .func_arg = opt_bitrate }, > > "video bitrate (please use -b:v)", "bitrate" }, > > { "hwaccel", OPT_VIDEO | OPT_STRING | HAS_ARG | OPT_EXPERT > | > > @@ -1680,6 +1678,8 @@ const OptionDef options[] = { > > { "acodec", OPT_AUDIO | HAS_ARG | OPT_PERFILE | > > OPT_INPUT | OPT_OUTPUT, > { .func_arg = opt_audio_codec }, > > "force audio codec ('copy' to copy stream)", "codec" }, > > + { "ab", OPT_AUDIO | HAS_ARG | OPT_PERFILE | > OPT_OUTPUT, { .func_arg = opt_bitrate }, > > + "audio bitrate (please use -b:a)", "bitrate" }, > > { "atag", OPT_AUDIO | HAS_ARG | OPT_EXPERT | OPT_PERFILE > | > > OPT_OUTPUT, > { .func_arg = opt_old2new }, > > "force audio tag/fourcc", "fourcc/tag" }, > > Looks ok, will push > > -- > Anton Khirnov > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".