[FFmpeg-devel] [PATCH] avformat/dvdvideodec: add explicit inttypes.h include

[FFmpeg-devel] [PATCH] avformat/dvdvideodec: add explicit inttypes.h include

[Marth64]

Since log statements printing int64 were made portable in
4464b7eeb194e98ac115f18d2b6be67361407c8a, let us include
inttypes.h explicitly (as it is unclear where PRId64 and
such are coming from now).

Reported-by: Traneptora
Signed-off-by: Marth64 <marth64@proxyid.net>
---
 libavformat/dvdvideodec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
index 761ac97ec6..959b267e69 100644
--- a/libavformat/dvdvideodec.c
+++ b/libavformat/dvdvideodec.c
@@ -30,6 +30,7 @@
  * 7) Close the dvdnav VM, and free dvdread's IFO structures
  */
 
+#include <inttypes.h>
 #include <dvdnav/dvdnav.h>
 #include <dvdread/dvd_reader.h>
 #include <dvdread/ifo_read.h>
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: add explicit inttypes.h include

[Leo Izen]

On 3/23/24 22:24, Marth64 wrote:
> Since log statements printing int64 were made portable in
> 4464b7eeb194e98ac115f18d2b6be67361407c8a, let us include
> inttypes.h explicitly (as it is unclear where PRId64 and
> such are coming from now).
> 
> Reported-by: Traneptora
> Signed-off-by: Marth64 <marth64@proxyid.net>
> ---
>   libavformat/dvdvideodec.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
> index 761ac97ec6..959b267e69 100644
> --- a/libavformat/dvdvideodec.c
> +++ b/libavformat/dvdvideodec.c
> @@ -30,6 +30,7 @@
>    * 7) Close the dvdnav VM, and free dvdread's IFO structures
>    */
>   
> +#include <inttypes.h>
>   #include <dvdnav/dvdnav.h>
>   #include <dvdread/dvd_reader.h>
>   #include <dvdread/ifo_read.h>

I would add a space between the inttypes.h include and the dvdread 
include because inttypes is a standard C library and the others are an 
external library.

If you don't want to do this you'll have to put it afterward in order to 
alphabetize it.

- Leo Izen (Traneptora)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: add explicit inttypes.h include

[Marth64]

Will send v2 with fix. I actually prefer it, I wasn't sure if it would be
seen the same way.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: add explicit inttypes.h include

[Marth64]

v2 on the way.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2] avformat/dvdvideodec: add explicit inttypes.h include

[Marth64]

Since log statements printing int64 were made portable in
4464b7eeb194e98ac115f18d2b6be67361407c8a, let us include
inttypes.h explicitly (as it is unclear where PRId64 and
such are coming from now).

Reported-by: Traneptora
Signed-off-by: Marth64 <marth64@proxyid.net>
---
 libavformat/dvdvideodec.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
index 761ac97ec6..4959edab5c 100644
--- a/libavformat/dvdvideodec.c
+++ b/libavformat/dvdvideodec.c
@@ -30,6 +30,8 @@
  * 7) Close the dvdnav VM, and free dvdread's IFO structures
  */
 
+#include <inttypes.h>
+
 #include <dvdnav/dvdnav.h>
 #include <dvdread/dvd_reader.h>
 #include <dvdread/ifo_read.h>
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] avformat/dvdvideodec: add explicit inttypes.h include

[Stefano Sabatini]

On date Monday 2024-03-25 16:21:02 -0500, Marth64 wrote:
> Since log statements printing int64 were made portable in
> 4464b7eeb194e98ac115f18d2b6be67361407c8a, let us include
> inttypes.h explicitly (as it is unclear where PRId64 and
> such are coming from now).
> 
> Reported-by: Traneptora
> Signed-off-by: Marth64 <marth64@proxyid.net>
> ---
>  libavformat/dvdvideodec.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
> index 761ac97ec6..4959edab5c 100644
> --- a/libavformat/dvdvideodec.c
> +++ b/libavformat/dvdvideodec.c
> @@ -30,6 +30,8 @@
>   * 7) Close the dvdnav VM, and free dvdread's IFO structures
>   */
>  
> +#include <inttypes.h>
> +
>  #include <dvdnav/dvdnav.h>
>  #include <dvdread/dvd_reader.h>
>  #include <dvdread/ifo_read.h>
> -- 
> 2.34.1

LGTM, will apply.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] avformat/dvdvideodec: add explicit inttypes.h include

[Marth64]

Was already applied. Thanks Stefano and Leo!
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".