From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6E7024105E for ; Fri, 10 Feb 2023 00:08:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 72EDA68BE21; Fri, 10 Feb 2023 02:08:15 +0200 (EET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 500B768BC49 for ; Fri, 10 Feb 2023 02:08:09 +0200 (EET) Received: by mail-pl1-f173.google.com with SMTP id f6so4728766pln.12 for ; Thu, 09 Feb 2023 16:08:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j+/S09+LTFWJ0gTa7wB0VxKqhsXY6cetlkbWgTSDfJg=; b=nDtiEgE/2fLQnlhLxk8CWXcAdEOTMyjTLn4aw95C3KdRTO/X+gNUN6a6A5FEVDYyNQ ojdxAOM0HLNzgOw4vEYtVAqSYRrkIzD6QYHhTGwbvhF059kdpoco52wCGGjSOAUkYJuy 4pR3A4IgnzmeCZgOtAbRPLkoqOTYg+GAgYNPaoR/Ayoiq8T698xYtUKRbwITmMad32Gx d6q+48FMEucgGdwcpm18IBzBgFfOA93xengG0lJnf91qZhpc8QvTSaLHhz6gIlogV1U5 wSje82QIIqWYk24QEl1Ug1bmCPkBOOz9fm/IL+1EesjAaBfNWM9rAcoW4UcdxV74jdBG BLAg== X-Gm-Message-State: AO0yUKU0/jpI2ZugjHWkqVzEnAvXNHX/RaswO9eQ37SoUpI3V0YU2aMN 4Gx2F6hbtSpOrnqPpZmKiptHBjpFnMd5alV2kLAnSLo1lrOwatYz X-Google-Smtp-Source: AK7set/ITKp+Vg9fDMHTbC53jLjZ8iBPbe9yclNRpRi4jUvC8vcKzYb0jzeVZYOzfUhEMUkY0n9kEwmwzWAZKIMPf0I= X-Received: by 2002:a17:90a:760f:b0:231:233c:dba8 with SMTP id s15-20020a17090a760f00b00231233cdba8mr1475569pjk.81.1675987687133; Thu, 09 Feb 2023 16:08:07 -0800 (PST) MIME-Version: 1.0 References: <20230209044058.2872534-1-marth64@proxyid.net> <20230209223456.GX1949656@pb2> In-Reply-To: <20230209223456.GX1949656@pb2> From: Marth64 Date: Thu, 9 Feb 2023 18:07:56 -0600 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Ack'd. Nice catch. Thank you! On Thu, Feb 9, 2023 at 4:35 PM Michael Niedermayer wrote: > On Wed, Feb 08, 2023 at 10:41:00PM -0600, Marth64 wrote: > > Signed-off-by: Marth64 > > --- > > Adds detection of spatial/object-based audio extensions in E-AC-3, > > TrueHD, and DCA XLL (DTS). This includes Atmos, DTS:X, and IMAX formats. > > Please let me know what I could improve, I'm learning still. > > Thank you. > [...] > > @@ -1054,10 +1055,23 @@ static int parse_frame(DCAXllDecoder *s, const > uint8_t *data, int size, DCAExssA > > return ret; > > if ((ret = parse_band_data(s)) < 0) > > return ret; > > + > > + extradata_peek_pos = (get_bits_count(&s->gb) + 31) & ~31; > > + if (s->frame_size * 8 > extradata_peek_pos) { > > + unsigned int extradata_syncword = show_bits(&s->gb, 32); > > show_bits_long() > > > [..] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > The misfortune of the wise is better than the prosperity of the fool. > -- Epicurus > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".