From: Marth64 <marth64@proxyid.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions
Date: Thu, 9 Feb 2023 18:07:56 -0600
Message-ID: <CA+28BfAvXEiHrzqDWFqZ04nKYKyOfTgFa2aONDx2DYy1GaYViA@mail.gmail.com> (raw)
In-Reply-To: <20230209223456.GX1949656@pb2>
Ack'd. Nice catch. Thank you!
On Thu, Feb 9, 2023 at 4:35 PM Michael Niedermayer <michael@niedermayer.cc>
wrote:
> On Wed, Feb 08, 2023 at 10:41:00PM -0600, Marth64 wrote:
> > Signed-off-by: Marth64 <marth64@proxyid.net>
> > ---
> > Adds detection of spatial/object-based audio extensions in E-AC-3,
> > TrueHD, and DCA XLL (DTS). This includes Atmos, DTS:X, and IMAX formats.
> > Please let me know what I could improve, I'm learning still.
> > Thank you.
> [...]
> > @@ -1054,10 +1055,23 @@ static int parse_frame(DCAXllDecoder *s, const
> uint8_t *data, int size, DCAExssA
> > return ret;
> > if ((ret = parse_band_data(s)) < 0)
> > return ret;
> > +
> > + extradata_peek_pos = (get_bits_count(&s->gb) + 31) & ~31;
> > + if (s->frame_size * 8 > extradata_peek_pos) {
> > + unsigned int extradata_syncword = show_bits(&s->gb, 32);
>
> show_bits_long()
>
>
> [..]
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> The misfortune of the wise is better than the prosperity of the fool.
> -- Epicurus
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-02-10 0:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 4:41 Marth64
2023-02-09 20:12 ` Hendrik Leppkes
2023-02-10 0:03 ` Marth64
2023-02-09 22:34 ` Michael Niedermayer
2023-02-10 0:07 ` Marth64 [this message]
[not found] <306450>
2023-02-12 0:31 ` Marth64
2023-02-17 10:59 ` Anton Khirnov
2023-02-17 14:51 ` Marth64
2023-02-20 16:41 ` Anton Khirnov
2023-02-20 16:57 ` Marth64
2023-03-10 2:17 ` Marth64
2023-03-10 11:53 ` Hendrik Leppkes
2023-03-10 22:00 ` Marth64
2023-02-12 0:52 ` Marth64
2023-02-16 12:36 ` Hendrik Leppkes
2023-02-16 23:20 ` Marth64
2023-02-17 4:46 ` Marth64
2023-02-17 19:46 ` Marth64
2023-02-17 22:43 ` James Almer
2023-02-17 23:09 ` Marth64
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+28BfAvXEiHrzqDWFqZ04nKYKyOfTgFa2aONDx2DYy1GaYViA@mail.gmail.com \
--to=marth64@proxyid.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git