From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8B1E8456AF for ; Fri, 17 Feb 2023 23:10:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AD99668BE5A; Sat, 18 Feb 2023 01:10:10 +0200 (EET) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2B1AF68B9F3 for ; Sat, 18 Feb 2023 01:10:04 +0200 (EET) Received: by mail-pl1-f172.google.com with SMTP id 19so3211839plo.7 for ; Fri, 17 Feb 2023 15:10:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LiSBEs5F6m+5C9IvQfYvrBRm88VTfCh9bKxp18ECFKE=; b=kI/bQ1MtWUDcadlTr2rbr81t/PTKDqLn/XZBNTnIS/l8hFJ0P/5FhwN5ne0ZgWCs8i KiZKNRhPm+wgOSFuemJbS/PRW9YC/wmzBRRUCu5eWAiOX7csclQ0J/uGQ1Y797znZXtv voZov7BNEZwuZqOKw5PQadWVRhlkF10UmXFMCFCY3BScsrT6LyK0xzOaTyUE/+isjEED uYM7Q/6XqNuR2+EKU9mB0lWk3N+yj1VIncmHoB4mg3dX5o4tCjelgnIyVifAg6VyDmNx iAVKhXyVjLAuwAnFvFxn8rAkEIwksBiuQj0/+WlL0AasYZss6thLHEu792R2mC6jYSLk MAFg== X-Gm-Message-State: AO0yUKV5caoIsgLq71b82EyMK/+5nXl3kkmCN/OJWk3dG1PD1+N2HJU/ Xd5zmjaH7Bu7TlsiBfcLKF6sZ/pN7EPEHVpnE22tzrpKTDThrzHv X-Google-Smtp-Source: AK7set8VuC3Skl0wEdB0BbC8QnPSqzowy0sUaLH/mMaVLrdEWeFi2ZmhMULcRwAE9aqy8WS6nt9twH4i1N9IcFIjTC4= X-Received: by 2002:a17:90a:e7cf:b0:22b:ef05:ea5b with SMTP id kb15-20020a17090ae7cf00b0022bef05ea5bmr1695065pjb.50.1676675401944; Fri, 17 Feb 2023 15:10:01 -0800 (PST) MIME-Version: 1.0 References: <20230217194634.4154710-1-marth64@proxyid.net> <4ad2565c-e1d6-39f2-2a9f-8e0bb6ed310c@gmail.com> In-Reply-To: <4ad2565c-e1d6-39f2-2a9f-8e0bb6ed310c@gmail.com> From: Marth64 Date: Fri, 17 Feb 2023 17:09:51 -0600 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Yes will take care of it, np On Fri, Feb 17, 2023 at 4:42 PM James Almer wrote: > On 2/17/2023 4:46 PM, Marth64 wrote: > > Signed-off-by: Marth64 > > --- > > Update doc/APIchanges and update libavcodec minor version > > > > doc/APIchanges | 4 ++++ > > libavcodec/ac3dec.c | 4 ++++ > > libavcodec/ac3dec.h | 1 + > > libavcodec/avcodec.h | 18 ++++++++++++------ > > libavcodec/codec_desc.c | 2 ++ > > libavcodec/dca_syncwords.h | 3 +++ > > libavcodec/dca_xll.c | 27 ++++++++++++++++++++++++++- > > libavcodec/dca_xll.h | 3 +++ > > libavcodec/eac3dec.c | 11 ++++++++++- > > libavcodec/mlpdec.c | 15 +++++++++++++-- > > libavcodec/profiles.c | 24 ++++++++++++++++++------ > > libavcodec/profiles.h | 2 ++ > > libavcodec/version.h | 2 +- > > 13 files changed, 99 insertions(+), 17 deletions(-) > > > > diff --git a/doc/APIchanges b/doc/APIchanges > > index 6baf914760..04dda4132e 100644 > > --- a/doc/APIchanges > > +++ b/doc/APIchanges > > @@ -14,6 +14,10 @@ libavutil: 2021-04-27 > > > > API changes, most recent first: > > > > +2023-0x-xx - xxxxxxxxxx - lavc 59.64.100 > > + Add DCA_SYNCWORD_XLL_X and DCA_SYNCWORD_XLL_X_IMAX syncword constants > > + as part of facilitating DTS:X and DTS:X IMAX detection. > > This should mention the new API that's exposed in public headers. In > this case it's the new FF_PROFILE_* defines. > > Also, could you split this in three patches? One for DTS, one for EAC3 > and one for TrueHD? The order is not important, and the version bump and > the APIChanges entry would then be added in the last patch. > Also, remove the mention about ffprobe since you're not touching it at > all. The new profiles will be reported by any tool that prints them, > like ffmpeg, not just ffprobe. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".