Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

[Marth64 <marth64@proxyid.net>]

Yes will take care of it, np

On Fri, Feb 17, 2023 at 4:42 PM James Almer <jamrial@gmail.com> wrote:

> On 2/17/2023 4:46 PM, Marth64 wrote:
> > Signed-off-by: Marth64 <marth64@proxyid.net>
> > ---
> > Update doc/APIchanges and update libavcodec minor version
> >
> >   doc/APIchanges             |  4 ++++
> >   libavcodec/ac3dec.c        |  4 ++++
> >   libavcodec/ac3dec.h        |  1 +
> >   libavcodec/avcodec.h       | 18 ++++++++++++------
> >   libavcodec/codec_desc.c    |  2 ++
> >   libavcodec/dca_syncwords.h |  3 +++
> >   libavcodec/dca_xll.c       | 27 ++++++++++++++++++++++++++-
> >   libavcodec/dca_xll.h       |  3 +++
> >   libavcodec/eac3dec.c       | 11 ++++++++++-
> >   libavcodec/mlpdec.c        | 15 +++++++++++++--
> >   libavcodec/profiles.c      | 24 ++++++++++++++++++------
> >   libavcodec/profiles.h      |  2 ++
> >   libavcodec/version.h       |  2 +-
> >   13 files changed, 99 insertions(+), 17 deletions(-)
> >
> > diff --git a/doc/APIchanges b/doc/APIchanges
> > index 6baf914760..04dda4132e 100644
> > --- a/doc/APIchanges
> > +++ b/doc/APIchanges
> > @@ -14,6 +14,10 @@ libavutil:     2021-04-27
> >
> >   API changes, most recent first:
> >
> > +2023-0x-xx - xxxxxxxxxx - lavc 59.64.100
> > +  Add DCA_SYNCWORD_XLL_X and DCA_SYNCWORD_XLL_X_IMAX syncword constants
> > +  as part of facilitating DTS:X and DTS:X IMAX detection.
>
> This should mention the new API that's exposed in public headers. In
> this case it's the new FF_PROFILE_* defines.
>
> Also, could you split this in three patches? One for DTS, one for EAC3
> and one for TrueHD? The order is not important, and the version bump and
> the APIChanges entry would then be added in the last patch.
> Also, remove the mention about ffprobe since you're not touching it at
> all. The new profiles will be reported by any tool that prints them,
> like ffmpeg, not just ffprobe.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".