From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id CD1DA491C1
	for <ffmpegdev@gitmailbox.com>; Wed,  6 Mar 2024 15:38:16 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4E5B568CB1D;
	Wed,  6 Mar 2024 17:38:15 +0200 (EET)
Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com
 [209.85.210.178])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 96D7568C92E
 for <ffmpeg-devel@ffmpeg.org>; Wed,  6 Mar 2024 17:38:08 +0200 (EET)
Received: by mail-pf1-f178.google.com with SMTP id
 d2e1a72fcca58-6e5d1a494e7so645307b3a.1
 for <ffmpeg-devel@ffmpeg.org>; Wed, 06 Mar 2024 07:38:08 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1709739487; x=1710344287;
 h=to:subject:message-id:date:from:in-reply-to:references:mime-version
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=eqnX+32ytUCTFy0zB9ENTGak7fFoO/8RiHh8AGTvq9g=;
 b=S9Io1LcH5j1CDFPd/tFBogkxDGft9YmLRE7jOKJAhpjb3BBpwLSUNOPWRwLY2stLIl
 gHv5dNa+Ab7RLQSrMiaYM1xwhuCgZz4i/gzOCLO4bJ5LwRXDvvAFM4SpaZE6nXMBjyyL
 yMf8TFEnU+vBpndB2TsrbJNU8bswZj7OT3KI0OXx4cnwnzvhEIg9R8SlZD4KEYFMfz3i
 Vdk4fj3CDzrY7MAuBa+QIHlK5tyD0p/k0FFxqJDqF9A58fhZkZkh/EW0ZLsuoX/yD3a5
 Nvfeung8uWRrA5MCC6iv3LGv+wjujnk8npQTYO48IRzx6egWRoSI+QEdzo1ROia3s6yg
 JM+g==
X-Gm-Message-State: AOJu0Yzxb+hpiN+i8uQlc2RxsiamVU5AAIhe6McC248OClFTQvl/Dl14
 9WA9Q4dolEU2kdMs2Afv/mGURUU59e4k7bGLm6dlwQ8k/0Nae6WLM+dLkRjEQ5fb5UJyX7cae6i
 QmGFl/WnzqOcNMQmpqyfQCm9i8TV70VP007amhH56jIExeTX0rFs=
X-Google-Smtp-Source: AGHT+IHVreRYw8qh17o2ZiFiL3BQ+468Qs3ibmGk/hakOVxYOs1x4iuBQNKlz2DQOzqPax7VnGVMl809LcwdjbHQvQk=
X-Received: by 2002:a05:6a21:999f:b0:1a1:3d79:82 with SMTP id
 ve31-20020a056a21999f00b001a13d790082mr4411859pzb.0.1709739486692; Wed, 06
 Mar 2024 07:38:06 -0800 (PST)
MIME-Version: 1.0
References: <20240306071913.2735832-1-marth64@proxyid.net>
 <20240306071913.2735832-3-marth64@proxyid.net>
 <ZeiHckFeeQrU0BMk@mariano>
In-Reply-To: <ZeiHckFeeQrU0BMk@mariano>
From: Marth64 <marth64@proxyid.net>
Date: Wed, 6 Mar 2024 09:37:55 -0600
Message-ID: <CA+28BfAiHBxq4WrCixkndAQ_sQXgYsWVhfcmiLyT8RPcuuk49g@mail.gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>,
 Marth64 <marth64@proxyid.net>
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [FFmpeg-devel] [PATCH 3/3] avformat/dvdvideodec: assign mono
 channel layout explicitly
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/CA+28BfAiHBxq4WrCixkndAQ_sQXgYsWVhfcmiLyT8RPcuuk49g@mail.gmail.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Good morning,
There do exist discs with mono tracks. This was to make the channel
assignment explicit rather than a guess, although if it is not necessary I
am happy to skip it.

Thank you!

On Wed, Mar 6, 2024 at 09:10 Stefano Sabatini <stefasab@gmail.com> wrote:

> On date Wednesday 2024-03-06 01:19:13 -0600, Marth64 wrote:
> > Signed-off-by: Marth64 <marth64@proxyid.net>
> > ---
> >  libavformat/dvdvideodec.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
> > index 2c7ffdd148..6136060288 100644
> > --- a/libavformat/dvdvideodec.c
> > +++ b/libavformat/dvdvideodec.c
> > @@ -1142,7 +1142,9 @@ static int
> dvdvideo_audio_stream_analyze(AVFormatContext *s, audio_attr_t audio_
> >          return AVERROR_INVALIDDATA;
> >      }
> >
> > -    if (nb_channels == 2)
> > +    if (nb_channels == 1)
> > +        ch_layout = (AVChannelLayout) AV_CHANNEL_LAYOUT_MONO;
> > +    else if (nb_channels == 2)
> >          ch_layout = (AVChannelLayout) AV_CHANNEL_LAYOUT_STEREO;
> >      else if (nb_channels == 6)
> >          ch_layout = (AVChannelLayout) AV_CHANNEL_LAYOUT_5POINT1;
>
> LGTM, but when this is needed?
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".