Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Marth64 <marth64@proxyid.net>
To: "Xiang, Haihao" <haihao.xiang@intel.com>
Cc: "marth64@proxyid.net" <marth64@proxyid.net>,
	"ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3] libavformat: add RCWT closed caption muxer
Date: Sun, 14 Jan 2024 22:33:21 -0600
Message-ID: <CA+28BfAWjEnj7_VT6DpZy86JBmYD_QuwX1mz6SCBojDgNRkCwA@mail.gmail.com> (raw)
In-Reply-To: <38f7d4afc044d8ad225eb2e8a989165387430668.camel@intel.com>

 Hello, seems this file didn't make it during merge. Patch coming very
shortly. Thank you,

On Sun, Jan 14, 2024 at 10:25 PM Xiang, Haihao <haihao.xiang@intel.com>
wrote:

> On So, 2024-01-14 at 15:16 +0100, Stefano Sabatini wrote:
> > On date Sunday 2024-01-07 16:24:07 +0100, Stefano Sabatini wrote:
> > > On date Sunday 2024-01-07 09:07:01 -0600, Marth64 wrote:
> > > > Thanks, long night. Should come together nicer now.
> > > >
> > > > Signed-off-by: Marth64 <marth64@proxyid.net>
> > > > ---
> > > >  Changelog                |   1 +
> > > >  doc/muxers.texi          |  22 +++++
> > > >  libavformat/Makefile     |   1 +
> > > >  libavformat/allformats.c |   1 +
> > > >  libavformat/rcwtenc.c    | 202
> +++++++++++++++++++++++++++++++++++++++
> > > >  tests/fate/subtitles.mak |   3 +
> > > >  tests/ref/fate/sub-rcwt  |   1 +
> > > >  7 files changed, 231 insertions(+)
> > > >  create mode 100644 libavformat/rcwtenc.c
> > > >  create mode 100644 tests/ref/fate/sub-rcwt
> > >
> >
> > > LGTM, I'll wait a few days to see if there are more comments before
> > > pushing (if I forget please ping).
> >
> > Applied, thanks.
> >
> > (BTW for the future when updating a patch, generate the patch with git
> > format-patch and attach it to the email, in order to avoid manual
> > editing on the committer side).
>
> $ make fate-sub-rcwt KEEP=1 V=2
> [...]
> reference file './tests/ref/fate/sub-rcwt' not found
>
> Thanks
> Haihao
>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-01-15  4:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-06  2:14 [FFmpeg-devel] [PATCH] " Marth64
2024-01-06 12:33 ` Stefano Sabatini
2024-01-06 21:41   ` [FFmpeg-devel] [PATCH v2] " Marth64
2024-01-07 12:02     ` Stefano Sabatini
2024-01-07 15:07       ` [FFmpeg-devel] [PATCH v3] " Marth64
2024-01-07 15:24         ` Stefano Sabatini
2024-01-14 14:16           ` Stefano Sabatini
2024-01-14 16:57             ` Marth64
2024-01-15  4:25             ` Xiang, Haihao
2024-01-15  4:33               ` Marth64 [this message]
2024-01-15  4:38               ` [FFmpeg-devel] [PATCH] rcwtenc: add sub-rcwt fate test ref Marth64
2024-01-15  5:06                 ` Xiang, Haihao
2024-01-15  5:20                   ` Marth64
2024-01-15 23:55                     ` Marth64

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+28BfAWjEnj7_VT6DpZy86JBmYD_QuwX1mz6SCBojDgNRkCwA@mail.gmail.com \
    --to=marth64@proxyid.net \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=haihao.xiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git