Re: [FFmpeg-devel] [PATCH v2] doc/t2h: Support texinfo 7.0

[epirat07@gmail.com]

On 7 Nov 2023, at 22:44, Frank Plowman wrote:

> On 07/11/2023 20:38, epirat07@gmail.com wrote:
>
>> On 7 Nov 2023, at 16:57, Frank Plowman wrote:
>>
>>> Resolves #10636 (http://trac.ffmpeg.org/ticket/10636)
>>>
>>> Texinfo 7.0, released in November 2022, changed the names of various
>>> functions. Compiling docs with Texinfo 7.0 results in warnings and
>>> improperly formatted documentation. More old names appear to have
>>> been removed in Texinfo 7.1, released October 2023, which causes docs
>>> compilation to fail.
>>>
>>> This PR addresses the issue by adding logic to switch between the old
>>> and new function names depending on the Texinfo version. Texinfo 6.8
>>> produces identical documentation before and after the patch. The change
>>> to the CSS makes the documentation generated by Texinfo >= 7.0 appear
>>> more similar to that generated by Texinfo <= 6.8.
>>>
>>> CC
>>> https://www.mail-archive.com/debian-bugs-dist@lists.debian.org/msg1938238.html
>>> https://bugs.gentoo.org/916104
>>>
>>> Signed-off-by: Frank Plowman <post@frankplowman.com>
>>>
>> Thanks!
>> Just had a quick look and was wondering why your patch touches the
>> bootstrap.min.css?
>
> Texinfo 7.0 produces quite different HTML to Texinfo 6.8. Without that change to the CSS, enumerated option flags (i.e. Possible values of x are...) render as white text on a white background with Texinfo 7.0 and are unreadable. The change removes a style for the selector `.table .table` which causes the background to turn white. As far as I can tell, it is not actually used anywhere in files generated by Texinfo 6.8.
>

Thanks for the clarification, I think it might be a good idea to split this change
into a second commit with the explanation you gave in the commit message. That way
if it ever causes an issue, it is easier to figure out, as this minified css is
nearly unreviewable…

> -- 
> https://www.frankplowman.com/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".