From: Marvin Scholz <epirat07-at-gmail.com@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/tls_openssl: add host verification Date: Tue, 08 Jul 2025 20:50:34 +0200 Message-ID: <C4FE008E-08FD-4270-AFA8-5C2A51B67BEF@gmail.com> (raw) In-Reply-To: <aG1kX5vemvRrtObU@phare.normalesup.org> On 8 Jul 2025, at 20:33, Nicolas George wrote: > Marvin Scholz (HE12025-07-08): >> That's already possible with `-tls_verify 0` > > Then the commit message inadequately explains what the patch does. > Please clarify. Sure, I will add a more verbose message. However note that verification was already done before my patch, when enabled, just not taking the host into account but all other aspects of the cert. > >> (which is actually the default, arguably shouldn't be IMHO but >> thats a different topic) > > A transition period where only a warning is printed would be necessary. How could that work though? Warn for every tls use in ffmpeg unless the user explicitly specifies -tls_verify 1 or -tls_verify 0? I think a lot of people would complain about that? But I agree we probably can't just change the behavior without making people aware of it before… > > Regards, > > -- > Nicolas George > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-07-08 18:50 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-07-08 18:06 Marvin Scholz 2025-07-08 18:06 ` [FFmpeg-devel] [PATCH 2/3] avformat/tls_openssl: verify setting hostname for SNI Marvin Scholz 2025-07-08 18:16 ` Nicolas George 2025-07-08 18:26 ` Marvin Scholz 2025-07-08 18:33 ` Nicolas George 2025-07-08 18:06 ` [FFmpeg-devel] [PATCH 3/3] avformat/tls_openssl: load default verify locations Marvin Scholz 2025-07-08 18:16 ` [FFmpeg-devel] [PATCH 1/3] avformat/tls_openssl: add host verification Nicolas George 2025-07-08 18:17 ` Marvin Scholz 2025-07-08 18:21 ` Nicolas George 2025-07-08 18:24 ` Marvin Scholz 2025-07-08 18:33 ` Nicolas George 2025-07-08 18:50 ` Marvin Scholz [this message] 2025-07-08 18:53 ` Nicolas George 2025-07-08 18:28 ` [FFmpeg-devel] [PATCH v2 " Marvin Scholz 2025-07-08 18:28 ` [FFmpeg-devel] [PATCH v2 2/3] avformat/tls_openssl: verify setting hostname for SNI Marvin Scholz 2025-07-08 18:28 ` [FFmpeg-devel] [PATCH v2 3/3] avformat/tls_openssl: load default verify locations Marvin Scholz 2025-07-08 18:53 ` [FFmpeg-devel] [PATCH v3 1/3] avformat/tls_openssl: add hostname for verification Marvin Scholz 2025-07-08 18:53 ` [FFmpeg-devel] [PATCH v3 2/3] avformat/tls_openssl: verify setting hostname for SNI Marvin Scholz 2025-07-08 18:53 ` [FFmpeg-devel] [PATCH v3 3/3] avformat/tls_openssl: load default verify locations Marvin Scholz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=C4FE008E-08FD-4270-AFA8-5C2A51B67BEF@gmail.com \ --to=epirat07-at-gmail.com@ffmpeg.org \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git