From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2C8E74300D for ; Thu, 13 Jan 2022 08:18:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9D3CB68B7AF; Thu, 13 Jan 2022 10:18:36 +0200 (EET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8830C688154 for ; Thu, 13 Jan 2022 10:18:27 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642061914; x=1673597914; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=Pj7ml/MajKQRAMyShWv5wnDZkn1RFs3eBimXoC/eZ3I=; b=f7Y+LR68vSK1+o+B0vjtr/imSOhr+BcO3UlvMeoNC39WTR8AWhbYanaE DQhRL/RQkOo3OP2UqU9ngj5VrEV7UUOUXYvq49kAFOQGOsCtGMtWdk7mD gl9TZlWRYO/WApkDynLF//Gck6epX0L4NVmxw3i9hPDN+Mr6Qe2zZk8c9 y3LR8aSeokbgToTjW7qZIWD8OffqZFPulD3fXZfxbErbXiNT+QAqMAlkN +SJ5esaC9bRSALvzTbYTiI/JyWfRbG3tQ3aUVvLlxPI2xyrtmiYRkMdIm D9xfdSFgidCOTuuO8FvDVkp87EA5tPI4KE7ybtMxu+7j7lYdg1rtfqSCt A==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="268309758" X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="268309758" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2022 00:18:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="473143947" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP; 13 Jan 2022 00:18:23 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 13 Jan 2022 00:18:22 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 13 Jan 2022 00:18:22 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 13 Jan 2022 00:18:22 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 13 Jan 2022 00:18:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a6wMtJo5C7pnIRn8HVl6l2OmldGlRyqckp8nC04RF96C8N/4fK0GU9Ef2KJdT9AUAW3gQEBEn+tnV4ZTnycHC5rWcoEo7Vd2E2Lk2LKQdx56IPKI6H4GwDS5mlaLztNDqljiGBRvsygEt99EyeDBFD91kY+9beclUedNayAZDvqOMUXV2yAZ2pg7bnHRZVPWB/KYur3DmZMPQFThZzts7wRm9uQscySr7zREuqDqAkH73Je12w5V+7QQx+ow/Vw/GzRspVfWypvV+qsfVcM0tyVywyIO80tjRWE+9/FtoLWQcqedyuF5eSUDAgEmgFg72PLD1g2/xfUZ4uMuSPfugg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YN0Dob0iFrMrC0I4nqpapE5xo1Ibd81NZgpbUCcLQ+o=; b=TmPdEilhykEcd8SVIC+0uP4tdAQT6n5NUBi3fCa/p28SQtUdcP0IyYObCoJBERl1JdizMtYLIvbF+byOoYfLpXcdu0jB+l5LlYNj1Wz9crpyiVLvJq6RaPy/c5HRd+KPHqdiU6/ZtPM5Yi7l97eqXc4kcZy/dIqb7PrV+YWEYtBhucK5pH+DzvGiKSyx1EceMceFrKR5BKh13zbproi4TMZhnnAmTSxRXJdsaIzk3jMjsrIImXVpuLIdqdc4KtulmHShgJo5KoecNyujILcDEPOLHrH/eS+uYH8M8Iz842qd9eo8mmfUHD9KJ3U/sZCJudC9p/3kPEypeoQsgljKxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB3879.namprd11.prod.outlook.com (2603:10b6:a03:18f::17) by BY5PR11MB4355.namprd11.prod.outlook.com (2603:10b6:a03:1c3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Thu, 13 Jan 2022 08:18:21 +0000 Received: from BY5PR11MB3879.namprd11.prod.outlook.com ([fe80::550:e7c7:13c4:7e0f]) by BY5PR11MB3879.namprd11.prod.outlook.com ([fe80::550:e7c7:13c4:7e0f%6]) with mapi id 15.20.4867.012; Thu, 13 Jan 2022 08:18:21 +0000 From: "Chen, Wenbin" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH V3 4/4] libavcodec/qsvenc: Add transform skip to hevc_qsv Thread-Index: AQHYCDyBGi7IHNSLJ0qwLMiGc9UdOaxgjuaAgAAMkgA= Date: Thu, 13 Jan 2022 08:18:21 +0000 Message-ID: References: <20220113051221.66453-1-wenbin.chen@intel.com> <20220113051221.66453-4-wenbin.chen@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6d79d289-2ecd-4fb8-5f25-08d9d66d42f6 x-ms-traffictypediagnostic: BY5PR11MB4355:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /3yl9spi2aZW+gOqPd09nGJSfdzfkfkZo3HSbKTLKEJagKp+9KjtJ0tPLNAFbe6MqoApzGjQ0yTWw6NoFEquTjZcys0wF+0mpBSBUlqqg1kbvOVL9RD3TBlu8noJieJ6RlKr2+t7s42iu8t549+jSdoCRoibyH3AAOASu8y41JUnXHI0diNdc0P4C7r/osjrjXJWwOyl6yo0BnA+9/z8kSof/pmCP69VHSW+j2qYqN1VMdkpFnTRy17LZ8VTAxerM272NYoD1qvi4k9DlIYiDj8walU59RPhNdyj/ECM70RlXV913YwvfYZ5uBLNZxH2JudUBbCljo9O6PIVSu4lerfrS2K1c7zj3xQ69Y9lMVpBGwGinZgm6Myr7jKKPmwRIxbVlMeqVnf/QCO7e9yTYAjXbuThKOE8NqiGG0CHt6pEKYvamg/CdYFal2Gr2nmk+sTrP0wOrJxRkYAKPBssbetr7QaA8KpbR8Q8yDh2KHsHOj8iWRt+/GeJkfX1HCiGtFV24K7szQIc8rnU9AXLBtHOnLqG89vYmPBXzp1Cw8czSU4X8s/MaIa0Tq1+4KbNvDt7IL9iCao6oQP3fdV+XkIdsD541W3yd0PD4U10C2srdGUlun6iKRD4BsERzyaEb0XUg6sQVpnDghcCdSAIh0dTw+2n/Jp46cbNVjGYy3xpGMfy+54QeZqE1foUvXew0Xa8TXwY0ZgyNYUy+ieOxlALZs454xi+xc9WJiRDCpCTdW5vGZZXq9wF8bt6PnsdZvqLrJukBF3no0IG//PycxP/AtzI1oz6oPYn82Q+p1w= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB3879.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(9686003)(52536014)(186003)(66446008)(64756008)(66476007)(66556008)(966005)(66946007)(122000001)(76116006)(38100700002)(2906002)(38070700005)(86362001)(508600001)(55016003)(7696005)(82960400001)(83380400001)(8936002)(71200400001)(6506007)(316002)(26005)(33656002)(8676002)(6916009)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yy7CIzkBYz7K4wY/Cl0aRtynnfrVw3no9xrCrfkqe6GULyITpiPg5EW7G7TZ?= =?us-ascii?Q?smqkcvKQW+R73wJ2qR/mIajx6sg+g/t9RKrDcXW4NOFyvflzPVMOAcMvwPgf?= =?us-ascii?Q?Yx1m/8owQFuX51YAHRt1zLCGl6kr2xPnFqjOJLbByfXNFeoX4Os1Ud7FrF7I?= =?us-ascii?Q?EAxhPZmUQklDqEqbk7QPbSJhax2aCGS7miXpbwEUmkEGRrhQQ6bCfo9ExO67?= =?us-ascii?Q?0Sy7ICd6NLog0c5bjrS5q0ZsSNh5geJCK/zKprZSgVo0Sx6L/PwwGyzZ6IJM?= =?us-ascii?Q?nzPSWrjkmDqoOQn6fJbjLkiUnH2oGV0SXLmcG5zrOZ+AwqHIQ3sZHMTqfXIF?= =?us-ascii?Q?/bm2RPY04ACmxK5cfVHVSuTc26Fw9NvZfjV/9FFWrREAvpavfSkKO2zQVNtZ?= =?us-ascii?Q?8Nd8+XPGkCFS4FJsfRcjzxQl1axZTfdNNgvDuaR7fFEFNd3uEc61SVLAC+JT?= =?us-ascii?Q?JNV2vZX2X35W0eWMq8KxSOI+eKX2IVluxF/jrqpC7mgwM1rv4MTpCHx8skkX?= =?us-ascii?Q?TpCoLbQBQjspPXdt0Jb6Qt1O6LW/q7nfGwojXCZFWA89MSK4ZyD4kzPqOzfS?= =?us-ascii?Q?fF6fbKVdGKOnZI7NSwgxwKiLxa+3idr13XA6MsVwRQzEej7Gtr+1ve5Rqen+?= =?us-ascii?Q?IkmWvZFt8UHGzoGSfPCHGGHz7wVaoCnSpED5lsFbHscgdYWGbhafqByuGcgL?= =?us-ascii?Q?VGLKriguRLpFDgvxqPHkxloro3ubeaQ0MT3LorYxrNhbHdpVm7P/QrzIe0SS?= =?us-ascii?Q?tlZRjwvJOs7XU//G8oRCU39YJK6wOChwTVyam1HGYTgkXzM4S4DsGtpY8eiG?= =?us-ascii?Q?MYqD3xjA1S5ulrWMtlkMGNYwDtau3/DnDSsE0PzQqXQB3i8IshZFTSyCUA4D?= =?us-ascii?Q?EvcqKS3aRSE+6+ATYH5ZQy6Zg8jZJADqkROmTCjSgJh4KKM/JUK3BWbJPVOO?= =?us-ascii?Q?4/OgaoJWd/X0t8V77MqWcjOmphCPS6Sq97tRpOtPI2mfjKVHe+9bQ7J3qwhC?= =?us-ascii?Q?0OpyB7wWfhdxiFtVitF1tRBxc2d8dxHjKBiJIukBqZ+M0iVuww6dBpeNwOUR?= =?us-ascii?Q?TIlbbUZF8cFvGGXpHJQC5edN4BT+Shm7DQERdY+/oLnug+HSEtWoJ/+jpIVB?= =?us-ascii?Q?SAf93D54qjLetlrbUbdhR40YO9cY3Gs87DrmZnY6NCxH31zQGTo6vZUS5ZUT?= =?us-ascii?Q?Lf9UnoLPz7sArxGHYfYSDMQNTVsnw50akjlssM+Ue3cWcm/Bgtfxo54a77N9?= =?us-ascii?Q?i0RUGyqTRJSFc1xum6yYJAaDmDpeWPFcRpDda3ttdd1xss79m0BpKEj0YR2G?= =?us-ascii?Q?1jevzfc+jYl/mRiLgaVtZwgngUveRq3diThzUNUxeDvAy0fOLRE32GNSLV/3?= =?us-ascii?Q?dkYGeex+JksqxLVEsA0HSCpeTkXxQnqnu26sTyUPVZoVAxLSkWWxaq1jXF1l?= =?us-ascii?Q?oM//DLZASdXHOfiBrPeALaXzX7rrI7pmKVCjMfhvpoK9QJi37utp/Ywd0V1x?= =?us-ascii?Q?KiyFwsliHyOdFwhKJeQhhPfkgs9orLyle6j91vNHkxAfOpjQhYf3Wjgk1DW8?= =?us-ascii?Q?i1SwHZPM+58bxHJyU8MauF+q+N3UoC2F91k76X6pSWamPru+oqspaUpiKLOJ?= =?us-ascii?Q?k84VKtsX8mEff6RYMx/L74s=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB3879.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d79d289-2ecd-4fb8-5f25-08d9d66d42f6 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 08:18:21.2232 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IE07O+jOxSnFhT/hxuXHL/2Wr37OlixRmJlldFFJZJYefOfCTFJNebt+RnnSNkqS89CldPq2pznka/qPGcyTtA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4355 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH V3 4/4] libavcodec/qsvenc: Add transform skip to hevc_qsv X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Thu, 2022-01-13 at 13:12 +0800, Wenbin Chen wrote: > > Add transform_skip option to hevc_qsv. By enabling this option, > > the transform_skip_enabled_flag in PPS will be set to 1. > > This option is supported on the platform equal or newer than CNL. > > > > Signed-off-by: Wenbin Chen > > --- > > doc/encoders.texi | 4 ++++ > > libavcodec/qsvenc.c | 10 +++++++++- > > libavcodec/qsvenc.h | 1 + > > libavcodec/qsvenc_hevc.c | 3 +++ > > 4 files changed, 17 insertions(+), 1 deletion(-) > > > > diff --git a/doc/encoders.texi b/doc/encoders.texi > > index 3d7c944fba..7714084864 100644 > > --- a/doc/encoders.texi > > +++ b/doc/encoders.texi > > @@ -3447,6 +3447,10 @@ Number of rows for tiled encoding. > > > > @item @var{aud} > > Insert the Access Unit Delimiter NAL. > > + > > +@item @var{transform_skip} > > +Turn this option ON to enable transformskip. It is supported on platform > > equal > > +or newer than CNL. > > @end table > > > > @subsection MPEG2 Options > > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > > index f2ba0241c6..4e5997c9ed 100644 > > --- a/libavcodec/qsvenc.c > > +++ b/libavcodec/qsvenc.c > > @@ -358,6 +358,9 @@ static void dump_video_param(AVCodecContext > *avctx, > > QSVEncContext *q, > > av_log(avctx, AV_LOG_VERBOSE, "DisableDeblockingIdc: %"PRIu32" \n", > co2- > > >DisableDeblockingIdc); > > #endif > > > > +#if QSV_VERSION_ATLEAST(1, 26) > > + av_log(avctx, AV_LOG_VERBOSE, "TransformSkip: %s \n", > > print_threestate(co3->TransformSkip)); > > +#endif > > } > > > > static void dump_video_vp9_param(AVCodecContext *avctx, > QSVEncContext *q, > > @@ -970,10 +973,15 @@ static int init_video_param(AVCodecContext > *avctx, > > QSVEncContext *q) > > #endif > > } > > > > + if (avctx->codec_id == AV_CODEC_ID_HEVC) { > > +#if QSV_VERSION_ATLEAST(1, 26) > > + q->extco3.TransformSkip = q->transform_skip ? > MFX_CODINGOPTION_ON > > : > > + MFX_CODINGOPTION_OF > > F; > > q->extco3.TransformSkip is set to MFX_CODINGOPTION_ON when q- > >transform_skip is > -1, right ? TransformSkip is tri-state flag, we may set it to > MFX_CODINGOPTION_UNKNOWN when q->transform_skip is -1. > > Thanks > Haihao I will fix this in the next submission Thanks Wenbin > > > > +#endif > > #if QSV_HAVE_GPB > > - if (avctx->codec_id == AV_CODEC_ID_HEVC) > > q->extco3.GPB = q->gpb ? MFX_CODINGOPTION_ON : > > MFX_CODINGOPTION_OFF; > > #endif > > + } > > q->extparam_internal[q->nb_extparam_internal++] = (mfxExtBuffer > *)&q- > > >extco3; > > #endif > > } > > diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h > > index 960604cb9a..5a574ada30 100644 > > --- a/libavcodec/qsvenc.h > > +++ b/libavcodec/qsvenc.h > > @@ -200,6 +200,7 @@ typedef struct QSVEncContext { > > int repeat_pps; > > int low_power; > > int gpb; > > + int transform_skip; > > > > int a53_cc; > > > > diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c > > index 08aba3011d..679c09c858 100644 > > --- a/libavcodec/qsvenc_hevc.c > > +++ b/libavcodec/qsvenc_hevc.c > > @@ -251,6 +251,9 @@ static const AVOption options[] = { > > { "tile_rows", "Number of rows for tiled > > encoding", OFFSET(qsv.tile_rows), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, > > UINT16_MAX, VE }, > > { "recovery_point_sei", "Insert recovery point SEI > > messages", OFFSET(qsv.recovery_point_sei), AV_OPT_TYPE_INT, > { .i64 > > = -1 }, -1, 1, VE }, > > { "aud", "Insert the Access Unit Delimiter NAL", OFFSET(qsv.aud), > > AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE}, > > +#if QSV_VERSION_ATLEAST(1, 26) > > + { "transform_skip", "Turn this option ON to enable > > transformskip", OFFSET(qsv.transform_skip), AV_OPT_TYPE_INT, { > > .i64 = -1}, -1, 1, VE}, > > +#endif > > > > { NULL }, > > }; > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".