From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AF8F24302A for ; Thu, 13 Jan 2022 08:17:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6556468B349; Thu, 13 Jan 2022 10:17:10 +0200 (EET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 093F368B188 for ; Thu, 13 Jan 2022 10:17:02 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642061828; x=1673597828; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=Q6QTmk1eKmPanGwYmSdqGGpq+bZ/hHNO5R8HfkRGwRM=; b=THuK4/+Ki1DgC2RrurUjuRopdNX3Urlzf9mDWAAzEH9OOZVPJXstfQaX p/rKqSw9qnLn9mgyfPLhLcngr9xvWrj6CXEdFwTnP2BiAG+Pq8PaybL3L M5a293z9+XO98AS7H/6k6xRwMj+yJuED0Z3d0cCo6x9xQ7mTLi3UXXTZs zYyu1HvxVwi+3YXlsBqO7ctyWfUCbvdjsygDq0dYENRd9QYw+ahHG0NL5 u376zV18Yzjgq3jz80xVpTfItJm0UEp2xwuF7Acb/iEpMA03uAQV5dvH6 Z/hqkDZnJMPiFLaQ76276MNfW0tSUUSD7nl1BPXWgojdVlz4rQ3W/uDU5 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="231301414" X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="231301414" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2022 00:16:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="528930990" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga007.fm.intel.com with ESMTP; 13 Jan 2022 00:16:58 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 13 Jan 2022 00:16:58 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 13 Jan 2022 00:16:58 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 13 Jan 2022 00:16:58 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eF0qSLIFwpT7rSL+lL0Be+y5EAYAm20JHoVGjxiw8e1RJ4R+gYxfVpTcNKNsVPB6SOFxosYYSEalvHpoP26NA9+0U8edGIoQOA1XvXaXwZ2Sivzs6zzXiXbxc/DITMY0dU1WVOHfzFNIliZ3H/5biDFS5yAXOYTHCVSB/J+N/O17Oy5zwXKLlicRpq8X7kpyDjVcmeJQQ9YHHQwJChZQZq222uAbSrfUum4YBo9j1UwTIkEewgfKDOryifwb7zZwzrLr6iJ7hwbqS+aThwPrP/WJadAi9wZ0y8+/xy2sae4+ydUnYYkZBtqZqCAjlng8C+wcB3vonX8sTYVVF1778w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OkK51eRCD8f2T26cYz1+T7uESpGyIm1MagKaaLcZr8s=; b=e1M94MDl60ax8D2wN7YmLFZv0QhJdbggRIYumHl9h4rQKmEhFXabjOtulv0mYWAYrcQnepP3ivKbyOUjt6WXZYb4OBWUvq8G8a+IiY9K0/u+Mi9ebk6LBEBLyfheFz78s9WIG3/5aAx8NgL1L54KCES2FeQDE78cNl6WGGMeyWxm95MpRZL5BQCGerJ5LVR2hIillVFjL4ymlYkIcaT4NP7ENTgTxJBoBE9IF6mRMIIj3T/Tmz8gCyHcvq/EeO1oMZ1f61pM5yVjycIDHhdo2T815V9waEscXJ6Waeukq1sNsJCtKoQHf78rHXF2MEtpfgz0x9Fz2LW/E+39PwZCyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB3879.namprd11.prod.outlook.com (2603:10b6:a03:18f::17) by BY5PR11MB4355.namprd11.prod.outlook.com (2603:10b6:a03:1c3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Thu, 13 Jan 2022 08:16:56 +0000 Received: from BY5PR11MB3879.namprd11.prod.outlook.com ([fe80::550:e7c7:13c4:7e0f]) by BY5PR11MB3879.namprd11.prod.outlook.com ([fe80::550:e7c7:13c4:7e0f%6]) with mapi id 15.20.4867.012; Thu, 13 Jan 2022 08:16:56 +0000 From: "Chen, Wenbin" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH V3 2/4] libavcodec/qsvenc: Add DisableDeblockingIdc support to qsv Thread-Index: AQHYCDxzEbZ1vV/vg0yXH3gclwsf+6xgiC4AgAASsQA= Date: Thu, 13 Jan 2022 08:16:56 +0000 Message-ID: References: <20220113051221.66453-1-wenbin.chen@intel.com> <20220113051221.66453-2-wenbin.chen@intel.com> <348ef3698f0d335d24bf86e47f7f83163ab2ec8f.camel@intel.com> In-Reply-To: <348ef3698f0d335d24bf86e47f7f83163ab2ec8f.camel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 647043d0-e862-4fdb-7ddc-08d9d66d105b x-ms-traffictypediagnostic: BY5PR11MB4355:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jRri5J29FovlVf2RVRPP4+w0/aBTu8CaWoqgUtbJQfrxr+h6Pqu7IJr0itvmzRuKaFgxaINIgKLpJ9gks4Atp6mzCv6sboYitXw0pZCf5PUSY/964Sw+Jf2igzmAhuzkT4kP+feSNFClzj7uK+7pIxiu9P2v7n+DmrOi96y4EGmOoiaVawDi91hCWAsEAeUMLOVCnYlNgvbhbMJt7/9PGeSjqSnyVqmlI1v5q9MwAxt3r9zOGNflgHpkVb6F7RWUsjCMydDnOpXN0KPoHY1Zh9Z9ZFlj1TgfsIGNzM6Q0NI2Q9vPRXBeIyD1IL+UC4jqSB+yhMmza+k+9gpyzG0iI0Fkso2adB/RILd3W+kFJfS9UAf+MA9VrM8XJRW7EiAvYa0NASmOybKHhKLFLOsvV+NbhaC1cMCcHoJE7gzHKVhxtJ+NapX+tHnVCaVtaKStV/04OVX3pTMewAUmbqpDEkcha/hcSdbCMhz4xLEavvBGEhDfDFIilxqTYviV0pKNxdO/mhlSssox80DonXs4cvMk7R7d0CHkO7FvOPjgTf/QynvAC5NT2ZOI7p7ERJx4Fjd5tpoZGTWejOQT1nIttSpzC9+ADYIRtxEN5ckjhzKHyffxd8w68udskeKEq57fLlP5orDNWnDEw6ItmZjAarLRgI9cnQ8LealtFMwxYouIPhkfUxp08535mwIiIbIRhuRKi474ocDZDs2RV30aqycG/FtJGJX2MpTC1ZGWngzGTf4bfmuxjnncWjmEX4PHmZZxnNsC3uNjcRQl+3ckK6TQC049mNwIo9AOaTaaW68= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB3879.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(9686003)(52536014)(186003)(66446008)(64756008)(66476007)(66556008)(966005)(66946007)(122000001)(76116006)(38100700002)(2906002)(38070700005)(86362001)(508600001)(55016003)(7696005)(82960400001)(83380400001)(8936002)(71200400001)(6506007)(316002)(26005)(33656002)(8676002)(6916009)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FY0CLkqYV/XXsMkeDIOVsnkQj4uM+d9hQnQ56lA/2dPWe12rVK5XdzBSl+sg?= =?us-ascii?Q?D6iYcWbRMNNe8FH7GPnCSoZ+35/MJNjF1IEA0cH2YrccUeCcrDRQHM0acVy+?= =?us-ascii?Q?pmxTYAwKqeZEHPHwjmHFprERXP9bdQkaGPWhNUBaJYf32ceuTjMV+/EDqF4O?= =?us-ascii?Q?CW61HXtQWJNJXrYoYZ8zPKyqtxgEWYEQ6Syvsc/PNR83/vz8vUH6anSeU3dR?= =?us-ascii?Q?i4TkysdZz+tcjzBAFEadOKE2QNK9KJ4PnpDIRjJm7ZtY4hCEjsID+FKn717N?= =?us-ascii?Q?OxNk2m+u82x5kzLCtb8Qfwzkac3fnACKO/kG6ZM3nEqpK7FUFymDALCWnK9u?= =?us-ascii?Q?YN7vbL0e3lkSw90c7rSMAS00zcG7RxE1sxqIkV2ODb7d4cO8KN2rMIrZhrGs?= =?us-ascii?Q?jDLuYM43yMga6Z4NB7eXrt56C9Kv8JvAJIDdnxjTuRlY+nXeGZz1nuLE32T3?= =?us-ascii?Q?xpSJUUFENpEHq3o+SW9Ftaou6S4lQyqKSDoHIf4mpfjtcomU7nYkhidPrMUL?= =?us-ascii?Q?f7XN89vmFdATGDqhpL74Iyesrf/rRwJUkdJazxgBGJ53lEBLYsJHl+kVOtxP?= =?us-ascii?Q?BZ0sNgrQB/l9gkcuI5lwC3UDUG2huBvinxPyIBdgI+CWQcK+p7KdcO7YtHg6?= =?us-ascii?Q?+Ktf5k9AbX7iNSz1as1Y12GXoznNeUXhfJHPlVB1LRqASxwMd7gifH8CjCi1?= =?us-ascii?Q?8kFV3kgo7JtsZk3b/TCUYr1rPsvbJgFBG3OmnVJdtsN+fYRJNJSIK9Qldwsc?= =?us-ascii?Q?/uxVaaWMk41+4EYt8g0V5/f3AB0Qv4djvD/ir1r2NrT41rr+TmNaKKShFgFc?= =?us-ascii?Q?M6SrB6MPNlSDPgsdXSvLOAQ9aI6Z9zw/CAq/d5i4nM7AoIt+sSXvE1pW/NqX?= =?us-ascii?Q?YjWwasDslRUDUn1CMWG+7qUtYbHZUy5PlLelaRA/gYfgkeaDM9I4mKfOWEV/?= =?us-ascii?Q?QfQx5SNkyIOn17+hLt0iG80b63nZZz6EaS/1dMf+qU8qegVjAC78j4twADWX?= =?us-ascii?Q?xcy9qYCGPgs67vYmWG9B3JRx1nax5eKxV6/I6/HSVzRZEsC0zlU9klvXDAvx?= =?us-ascii?Q?PdsbEp4NGjZfCmUAnS63o41taNu+L4WDzw2pMUs3k215nFwTc8qIU0ipbWl0?= =?us-ascii?Q?NHlOa4NSqsohIJHYpi6j5rvAxgRgjNPqCZcTBA6STTG6Jgp5ZsDIRwVBr3yp?= =?us-ascii?Q?C0vDikMXH4qJlHqYhbA7LKjU8EEXC+1kmih9s0Nqm5hsQi2kcoPXzFGgEXt7?= =?us-ascii?Q?704L2cAOv77c7pHIdD2O1X4HRWK4OF6JdoZ+gic8AbcovnGJcoZ/MNuQuPkQ?= =?us-ascii?Q?n3T/wl7uSINz22p6jeCU5dAuQQpwmUo8JnTJXO5elYpZd2XdMD9kgJ9ZLgMN?= =?us-ascii?Q?fvyfXfi0vqQOduROESYGaoS17PhcT2MlQkxW/HNszniEI6S0jqyRLisnV94U?= =?us-ascii?Q?AOXaTQwDobZPfkr6yNCl0Zv2+PaISOph4a2btLhZuJ5yqkbXAabkq8C6gDUT?= =?us-ascii?Q?IqA8pO7naH7iVO8fAO49I9csZ5Uyur/EHU4V6Gw4qNYUADRKYH5A9WWyBLX+?= =?us-ascii?Q?AJvgRR+UPcZpS/cnQSWgWBQsuyoj0uhmgnJ8IIaX0b40DUQFf4AJVpTOt035?= =?us-ascii?Q?C6ucf3Za8lK6bOOOr7cy184=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB3879.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 647043d0-e862-4fdb-7ddc-08d9d66d105b X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 08:16:56.1815 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6QA74TujS/YDEBldV2hFXk8UtuTrugIfzBgKkHNnRKm+DQs0udJAyPaHy5fxudXotIWIrZ4bVqc2i33apbNFAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4355 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH V3 2/4] libavcodec/qsvenc: Add DisableDeblockingIdc support to qsv X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Thu, 2022-01-13 at 13:12 +0800, Wenbin Chen wrote: > > Add dblk_idc option to 264_qsv and hevc_qsv. Turining on this opion can > > disable deblocking. > > > > Signed-off-by: Wenbin Chen > > --- > > doc/encoders.texi | 6 ++++++ > > libavcodec/qsvenc.c | 8 ++++++++ > > libavcodec/qsvenc.h | 3 +++ > > 3 files changed, 17 insertions(+) > > > > diff --git a/doc/encoders.texi b/doc/encoders.texi > > index 68921fbd40..6fc94daa11 100644 > > --- a/doc/encoders.texi > > +++ b/doc/encoders.texi > > @@ -3299,6 +3299,9 @@ This flag controls changing of frame type from B > to P. > > @item @var{b_strategy} > > This option controls usage of B frames as reference. > > > > +@item @var{dblk_idc} > > +This option disable deblocking. It has value in range 0~2. > > + > > @item @var{cavlc} > > If set, CAVLC is used; if unset, CABAC is used for encoding. > > > > @@ -3391,6 +3394,9 @@ Enable rate distortion optimization. > > @item @var{max_frame_size} > > Maximum encoded frame size in bytes. > > > > +@item @var{dblk_idc} > > +This option disable deblocking. It has value in range 0~2. > > + > > @item @var{idr_interval} > > Distance (in I-frames) between IDR frames. > > @table @samp > > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > > index b3728d28d5..e87b69369a 100644 > > --- a/libavcodec/qsvenc.c > > +++ b/libavcodec/qsvenc.c > > @@ -346,6 +346,10 @@ static void dump_video_param(AVCodecContext > *avctx, > > QSVEncContext *q, > > av_log(avctx, AV_LOG_VERBOSE, "FrameRateExtD: %"PRIu32"; > FrameRateExtN: > > %"PRIu32" \n", > > info->FrameInfo.FrameRateExtD, info->FrameInfo.FrameRateExtN); > > > > +#if QSV_HAVE_DISABLEDEBLOCKIDC > > + av_log(avctx, AV_LOG_VERBOSE, "DisableDeblockingIdc: %"PRIu32" \n", > co2- > > >DisableDeblockingIdc); > > +#endif > > + > > } > > > > static void dump_video_vp9_param(AVCodecContext *avctx, > QSVEncContext *q, > > @@ -889,6 +893,10 @@ static int init_video_param(AVCodecContext > *avctx, > > QSVEncContext *q) > > q->extco2.ExtBRC = q->extbrc ? MFX_CODINGOPTION_ON : > > MFX_CODINGOPTION_OFF; > > if (q->max_frame_size >= 0) > > q->extco2.MaxFrameSize = q->max_frame_size; > > +#if QSV_HAVE_DISABLEDEBLOCKIDC > > + if(q->dblk_idc >= 0) > > + q->extco2.DisableDeblockingIdc = q->dblk_idc; > > +#endif > > > > #if QSV_VERSION_ATLEAST(1, 9) > > if (avctx->qmin >= 0 && avctx->qmax >= 0 && avctx->qmin > avctx- > > >qmax) { > > diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h > > index 31516b8e55..aa49b35f07 100644 > > --- a/libavcodec/qsvenc.h > > +++ b/libavcodec/qsvenc.h > > @@ -44,6 +44,7 @@ > > > > #define QSV_HAVE_TRELLIS QSV_VERSION_ATLEAST(1, 8) > > #define QSV_HAVE_MAX_SLICE_SIZE QSV_VERSION_ATLEAST(1, 9) > > +#define QSV_HAVE_DISABLEDEBLOCKIDC QSV_VERSION_ATLEAST(1, 9) > > #define QSV_HAVE_BREF_TYPE QSV_VERSION_ATLEAST(1, 8) > > > > #define QSV_HAVE_LA QSV_VERSION_ATLEAST(1, 7) > > @@ -97,6 +98,7 @@ > > { "b_strategy", "Strategy to choose between I/P/B-frames", > > OFFSET(qsv.b_strategy), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 1, VE > > }, \ > > { "forced_idr", "Forcing I frames as IDR > > frames", OFFSET(qsv.forced_idr), AV_OPT_TYPE_BOOL,{ .i64 = > > 0 }, 0, 1, VE }, \ > > { "low_power", "enable low power mode(experimental: many limitations > by mfx > > version, BRC modes, etc.)", OFFSET(qsv.low_power), AV_OPT_TYPE_BOOL, > { .i64 = > > -1}, -1, 1, VE},\ > > +{ "dblk_idc", "This option disable deblocking. It has value in range > > 0~2.", OFFSET(qsv.dblk_idc), AV_OPT_TYPE_INT, { .i64 = -1 }, - > > 1, 2, VE}, \ > > > The range is 0~2 in the help string, however the minimal value is -1, which > will > confuse user. We may set both the default and minimal values to 0 here. > > Thanks > Haihao Sorry, I miss your comment. I will fix this. Thanks Wenbin > > > > > extern const AVCodecHWConfigInternal *const ff_qsv_enc_hw_configs[]; > > > > @@ -169,6 +171,7 @@ typedef struct QSVEncContext { > > int rdo; > > int max_frame_size; > > int max_slice_size; > > + int dblk_idc; > > > > int tile_cols; > > int tile_rows; > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".